Changeset 46494 in vbox for trunk/src/libs/xpcom18a4/ipc/ipcd

Timestamp:

Jun 11, 2013 3:03:22 PM (12 years ago)

Author:

vboxsync

Message:

ipcdclient.cpp: Use a shared critical section instead of the slowlish PRMonitor thingy. The origianl code mentions that a monitor is a bit overkill and PRLock would've sufficed if it only was recursive. I've tried taking this a bit further by using a shared lock so that GetTarget() and IPC_OnMessageAvailable() doesn't need to do exclusive access.

Location:

trunk/src/libs/xpcom18a4/ipc/ipcd/client

Files:

• Makefile.kup (added)
• src/Makefile.kup (added)
• src/ipcdclient.cpp (modified) (11 diffs)

trunk/src/libs/xpcom18a4/ipc/ipcd/client/src/ipcdclient.cpp

@@ -59 +59 @@
 #include "pratom.h"
 
+#ifdef VBOX
+# include <iprt/critsect.h>
+# define VBOX_WITH_IPCCLIENT_RW_CS
+#endif
+
 /* ------------------------------------------------------------------------- */
 
@@ -147 +152 @@
   ~ipcClientState()
   {
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
     if (monitor)
       nsAutoMonitor::DestroyMonitor(monitor);
-  }
-
+#else
+    RTCritSectRwDelete(&critSect);
+#endif
+  }
+
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
   //
   // the monitor protects the targetMap and the connected and shutdown flags.
@@ -160 +170 @@
   //
   PRMonitor    *monitor;
+#else  /* VBOX_WITH_IPCCLIENT_RW_CS */
+  RTCRITSECTRW  critSect;
+#endif /* VBOX_WITH_IPCCLIENT_RW_CS */
   ipcTargetMap  targetMap;
   PRBool        connected;
@@ -172 +185 @@
 
   ipcClientState()
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
     : monitor(nsAutoMonitor::NewMonitor("ipcClientState"))
     , connected(PR_FALSE)
+#else
+    : connected(PR_FALSE)
+#endif
     , shutdown(PR_FALSE)
     , selfID(0)
-  {}
+  {
+#ifdef VBOX_WITH_IPCCLIENT_RW_CS
+    /* Not employing the lock validator here to keep performance up in debug builds. */
+    RTCritSectRwInitEx(&critSect, RTCRITSECT_FLAGS_NO_LOCK_VAL, NIL_RTLOCKVALCLASS, RTLOCKVAL_SUB_CLASS_NONE, NULL);
+#endif
+  }
 };
 
@@ -186 +208 @@
     return NULL;
 
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
   if (!cs->monitor || !cs->targetMap.Init())
+#else
+  if (!RTCritSectRwIsInitialized(&cs->critSect) || !cs->targetMap.Init())
+#endif
   {
     delete cs;
@@ -202 +228 @@
 GetTarget(const nsID &aTarget, ipcTargetData **td)
 {
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
   nsAutoMonitor mon(gClientState->monitor);
   return gClientState->targetMap.Get(nsIDHashKey(&aTarget).GetKey(), td);
+#else
+  RTCritSectRwEnterShared(&gClientState->critSect);
+  PRBool fRc = gClientState->targetMap.Get(nsIDHashKey(&aTarget).GetKey(), td);
+  RTCritSectRwLeaveShared(&gClientState->critSect);
+  return fRc;
+#endif
 }
 
@@ -209 +242 @@
 PutTarget(const nsID &aTarget, ipcTargetData *td)
 {
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
   nsAutoMonitor mon(gClientState->monitor);
   return gClientState->targetMap.Put(nsIDHashKey(&aTarget).GetKey(), td);
+#else
+  RTCritSectRwEnterExcl(&gClientState->critSect);
+  PRBool fRc = gClientState->targetMap.Put(nsIDHashKey(&aTarget).GetKey(), td);
+  RTCritSectRwLeaveExcl(&gClientState->critSect);
+  return fRc;
+#endif
 }
 
@@ -216 +256 @@
 DelTarget(const nsID &aTarget)
 {
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
   nsAutoMonitor mon(gClientState->monitor);
   gClientState->targetMap.Remove(nsIDHashKey(&aTarget).GetKey());
+#else
+  RTCritSectRwEnterExcl(&gClientState->critSect);
+  gClientState->targetMap.Remove(nsIDHashKey(&aTarget).GetKey());
+  RTCritSectRwLeaveExcl(&gClientState->critSect);
+#endif
 }
 
@@ -805 +851 @@
       // all targets but IPCM will not be able to use WaitTarget any more.
 
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
       nsAutoMonitor mon(gClientState->monitor);
+#else
+      RTCritSectRwEnterExcl(&gClientState->critSect);
+#endif
+
       gClientState->shutdown = PR_TRUE;
       gClientState->targetMap.EnumerateRead(EnumerateTargetMapAndNotify, nsnull);
+
+#ifdef VBOX_WITH_IPCCLIENT_RW_CS
+      RTCritSectRwLeaveExcl(&gClientState->critSect);
+#endif
     }
 
@@ -1290 +1345 @@
   // unblock any calls to WaitTarget.
 
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
   nsAutoMonitor mon(gClientState->monitor);
+#else
+  RTCritSectRwEnterExcl(&gClientState->critSect);
+#endif
+
   gClientState->connected = PR_FALSE;
   gClientState->targetMap.EnumerateRead(EnumerateTargetMapAndNotify, nsnull);
+
+#ifdef VBOX_WITH_IPCCLIENT_RW_CS
+  RTCritSectRwLeaveExcl(&gClientState->critSect);
+#endif
 }
 
@@ -1393 +1457 @@
         // targets) giving them an opportuninty to finish wait cycle because of
         // the peer client death, when appropriate.
+#ifndef VBOX_WITH_IPCCLIENT_RW_CS
         nsAutoMonitor mon(gClientState->monitor);
+#else
+        RTCritSectRwEnterShared(&gClientState->critSect);
+#endif
+
         gClientState->targetMap.EnumerateRead(EnumerateTargetMapAndPlaceMsg, msg);
 
+#ifdef VBOX_WITH_IPCCLIENT_RW_CS
+        RTCritSectRwLeaveShared(&gClientState->critSect);
+#endif
         delete msg;