Changeset 4693 in vbox for trunk/src/VBox

Timestamp:

Sep 11, 2007 10:14:38 AM (17 years ago)

Author:

vboxsync

Message:

PGMPhysGCPtr2CCPtr and ReadOnly versions.

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• PGMAllPhys.cpp (modified) (3 diffs)
• TRPMAll.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp

@@ -379 +379 @@
  * scarse resources (R0 and GC) in the mapping cache. When you're done
  * with the page, call PGMPhysReleasePageMappingLock() ASAP to release it.
+ * 
+ * This API will assume your intention is to write to the page, and will 
+ * therefore replace shared and zero pages. If you do not intend to modify 
+ * the page, use the PGMPhysGCPhys2CCPtrReadOnly() API.
  *
  * @returns VBox status code.
@@ -392 +396 @@
  * @remark  Avoid calling this API from within critical sections (other than
  *          the PGM one) because of the deadlock risk.
+ * @thread  Any thread.
  */
 PGMDECL(int) PGMPhysGCPhys2CCPtr(PVM pVM, RTGCPHYS GCPhys, void **ppv, PPGMPAGEMAPLOCK pLock)
 {
-# ifdef NEW_PHYS_CODE
-    int rc = pgmLock(pVM);
-    AssertRCReturn(rc);
-
+#ifdef NEW_PHYS_CODE
 #ifdef IN_GC
     /* Until a physical TLB is implemented for GC, let PGMGCDynMapGCPageEx handle it. */
     return PGMGCDynMapGCPageEx(pVM, GCPhys, ppv);
-
 #else
+    int rc = pgmLock(pVM);
+    AssertRCReturn(rc);
+
     /*
      * Query the Physical TLB entry for the page (may fail).
@@ -455 +459 @@
 
 /**
+ * Requests the mapping of a guest page into the current context.
+ *
+ * This API should only be used for very short term, as it will consume
+ * scarse resources (R0 and GC) in the mapping cache. When you're done
+ * with the page, call PGMPhysReleasePageMappingLock() ASAP to release it.
+ *
+ * @returns VBox status code.
+ * @retval  VINF_SUCCESS on success.
+ * @retval  VERR_PGM_PHYS_PAGE_RESERVED it it's a valid page but has no physical backing.
+ * @retval  VERR_PGM_INVALID_GC_PHYSICAL_ADDRESS if it's not a valid physical address.
+ *
+ * @param   pVM         The VM handle.
+ * @param   GCPhys      The guest physical address of the page that should be mapped.
+ * @param   ppv         Where to store the address corresponding to GCPhys.
+ * @param   pLock       Where to store the lock information that PGMPhysReleasePageMappingLock needs.
+ *
+ * @remark  Avoid calling this API from within critical sections (other than
+ *          the PGM one) because of the deadlock risk.
+ * @thread  Any thread.
+ */
+PGMDECL(int) PGMPhysGCPhys2CCPtrReadOnly(PVM pVM, RTGCPHYS GCPhys, void * const *ppv, PPGMPAGEMAPLOCK pLock)
+{
+    /** @todo implement this */
+    return PGMPhysGCPhys2CCPtr(pVM, GCPhys, (void **)ppv, pLock);
+}
+
+
+/**
+ * Requests the mapping of a guest page given by virtual address into the current context.
+ *
+ * This API should only be used for very short term, as it will consume
+ * scarse resources (R0 and GC) in the mapping cache. When you're done
+ * with the page, call PGMPhysReleasePageMappingLock() ASAP to release it.
+ *
+ * This API will assume your intention is to write to the page, and will 
+ * therefore replace shared and zero pages. If you do not intend to modify 
+ * the page, use the PGMPhysGCPtr2CCPtrReadOnly() API.
+ *
+ * @returns VBox status code.
+ * @retval  VINF_SUCCESS on success.
+ * @retval  VERR_PAGE_TABLE_NOT_PRESENT if the page directory for the virtual address isn't present.
+ * @retval  VERR_PAGE_NOT_PRESENT if the page at the virtual address isn't present.
+ * @retval  VERR_PGM_PHYS_PAGE_RESERVED it it's a valid page but has no physical backing.
+ * @retval  VERR_PGM_INVALID_GC_PHYSICAL_ADDRESS if it's not a valid physical address.
+ *
+ * @param   pVM         The VM handle.
+ * @param   GCPhys      The guest physical address of the page that should be mapped.
+ * @param   ppv         Where to store the address corresponding to GCPhys.
+ * @param   pLock       Where to store the lock information that PGMPhysReleasePageMappingLock needs.
+ *
+ * @remark  Avoid calling this API from within critical sections (other than
+ *          the PGM one) because of the deadlock risk.
+ * @thread  EMT
+ */
+PGMDECL(int) PGMPhysGCPtr2CCPtr(PVM pVM, RTGCPTR GCPtr, void **ppv, PPGMPAGEMAPLOCK pLock)
+{
+    RTGCPHYS GCPhys;
+    int rc = PGMPhysGCPtr2GCPhys(pVM, GCPtr, &GCPhys);
+    if (VBOX_SUCCESS(rc))
+        rc = PGMPhysGCPhys2CCPtr(pVM, GCPhys, ppv, pLock);
+    return rc;
+}
+
+
+/**
+ * Requests the mapping of a guest page given by virtual address into the current context.
+ *
+ * This API should only be used for very short term, as it will consume
+ * scarse resources (R0 and GC) in the mapping cache. When you're done
+ * with the page, call PGMPhysReleasePageMappingLock() ASAP to release it.
+ *
+ * @returns VBox status code.
+ * @retval  VINF_SUCCESS on success.
+ * @retval  VERR_PAGE_TABLE_NOT_PRESENT if the page directory for the virtual address isn't present.
+ * @retval  VERR_PAGE_NOT_PRESENT if the page at the virtual address isn't present.
+ * @retval  VERR_PGM_PHYS_PAGE_RESERVED it it's a valid page but has no physical backing.
+ * @retval  VERR_PGM_INVALID_GC_PHYSICAL_ADDRESS if it's not a valid physical address.
+ *
+ * @param   pVM         The VM handle.
+ * @param   GCPhys      The guest physical address of the page that should be mapped.
+ * @param   ppv         Where to store the address corresponding to GCPhys.
+ * @param   pLock       Where to store the lock information that PGMPhysReleasePageMappingLock needs.
+ *
+ * @remark  Avoid calling this API from within critical sections (other than
+ *          the PGM one) because of the deadlock risk.
+ * @thread  EMT
+ */
+PGMDECL(int) PGMPhysGCPtr2CCPtrReadOnly(PVM pVM, RTGCPTR GCPtr, void * const *ppv, PPGMPAGEMAPLOCK pLock)
+{
+    RTGCPHYS GCPhys;
+    int rc = PGMPhysGCPtr2GCPhys(pVM, GCPtr, &GCPhys);
+    if (VBOX_SUCCESS(rc))
+        rc = PGMPhysGCPhys2CCPtrReadOnly(pVM, GCPhys, ppv, pLock);
+    return rc;
+}
+
+
+/**
  * Release the mapping of a guest page.
  * 
- * This is the counter part of PGMPhysGCPhys2CCPtr.
+ * This is the counter part of PGMPhysGCPhys2CCPtr, PGMPhysGCPhys2CCPtrReadOnly
+ * PGMPhysGCPtr2CCPtr and PGMPhysGCPtr2CCPtrReadOnly.
  *
  * @param   pVM         The VM handle.

trunk/src/VBox/VMM/VMMAll/TRPMAll.cpp

@@ -591 +591 @@
                 if ((pTrapStackGC >> PAGE_SHIFT) != ((pTrapStackGC - 10*sizeof(uint32_t)) >> PAGE_SHIFT)) /* fail if we cross a page boundary */
                     goto failure;
-
-                /** @todo add PGMPhysGCPtr2CCPtr */
                 PGMPAGEMAPLOCK PageMappingLock;
-                RTGCPHYS GCPhysStack;
-                rc = PGMPhysGCPtr2GCPhys(pVM, pTrapStackGC, &GCPhysStack);
-                if (VBOX_SUCCESS(rc))
-                    rc = PGMPhysGCPhys2CCPtr(pVM, GCPhysStack, (void **)&pTrapStack, &PageMappingLock);
+                rc = PGMPhysGCPtr2CCPtr(pVM, pTrapStackGC, (void **)&pTrapStack, &PageMappingLock);
                 if (VBOX_FAILURE(rc))
                 {