Changeset 46980 in vbox for trunk/src/VBox/Main

Timestamp:

Jul 4, 2013 11:38:28 AM (12 years ago)

Author:

vboxsync

Message:

Deprecated the old manifest API. r=bird: IPRT does NOT use ugly C++ references, it pointers directly - no cloak and dagger pointers thank you. Please don't reformat if expressions into unreadability. RTDIGESTTYPE_UNKNOWN should be RTDIGESTTYPE_INVALID and there is actually no need to set output variables on failure, just check the status code.

File:

• trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp

@@ -965 +965 @@
                     uint64_t maxFileSize = _1M;
                     size_t cbRead = 0;
-                    void  *pBuf;
+                    void  *pBuf; /** @todo r=bird: You leak this buffer! throwing stuff is evil. */
 
                     vrc = RTFileGetSize(pFile, &cbFile);
@@ -993 +993 @@
                     RTFileClose(pFile);
 
-                    RTDIGESTTYPE digestType = RTDIGESTTYPE_UNKNOWN;
-                    vrc = RTManifestVerifyDigestType(pBuf, cbRead, digestType);
+                    RTDIGESTTYPE digestType;
+                    vrc = RTManifestVerifyDigestType(pBuf, cbRead, &digestType);
 
                     if (RT_FAILURE(vrc))