Changeset 47094 in vbox for trunk

Timestamp:

Jul 11, 2013 2:23:32 PM (12 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: Log exit reasons for more rare/improbable gurus.

Location:

trunk/src/VBox/VMM

Files:

• VMMR0/HMVMXR0.cpp (modified) (6 diffs)
• VMMR3/HM.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -7478 +7478 @@
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
     AssertMsgFailed(("Unexpected NMI-window exit.\n"));
+    pVCpu->hm.s.u32HMError = VMX_EXIT_NMI_WINDOW;
     return VERR_VMX_UNEXPECTED_EXIT_CODE;
 }
@@ -7540 +7541 @@
 
     AssertMsgFailed(("hmR0VmxExitGetsec: unexpected VM-exit when CR4.SMXE is 0.\n"));
+    pVCpu->hm.s.u32HMError = VMX_EXIT_GETSEC;
     return VERR_VMX_UNEXPECTED_EXIT_CODE;
 }
@@ -7728 +7730 @@
      * Execution of RSM outside of SMM mode causes #UD regardless of VMX root or VMX non-root mode. In theory, we should never
      * get this VM-exit. This can happen only if dual-monitor treatment of SMI and VMX is enabled, which can (only?) be done by
-     * executing VMCALL in VMX root operation. If we get here something funny is going on.
+     * executing VMCALL in VMX root operation. If we get here, something funny is going on.
      * See Intel spec. "33.15.5 Enabling the Dual-Monitor Treatment".
      */
     AssertMsgFailed(("Unexpected RSM VM-exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
+    pVCpu->hm.s.u32HMError = VMX_EXIT_RSM;
     return VERR_VMX_UNEXPECTED_EXIT_CODE;
 }
@@ -7743 +7746 @@
     /*
      * This can only happen if we support dual-monitor treatment of SMI, which can be activated by executing VMCALL in VMX
-     * root operation. If we get there there is something funny going on.
+     * root operation. Only an STM (SMM transfer monitor) would get this exit when we (the executive monitor) execute a VMCALL
+     * in VMX root mode or receive an SMI. If we get here, something funny is going on.
      * See Intel spec. "33.15.6 Activating the Dual-Monitor Treatment" and Intel spec. 25.3 "Other Causes of VM-Exits"
      */
     AssertMsgFailed(("Unexpected SMI VM-exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
+    pVCpu->hm.s.u32HMError = VMX_EXIT_SMI;
     return VERR_VMX_UNEXPECTED_EXIT_CODE;
 }
@@ -7758 +7763 @@
     /* Same treatment as VMX_EXIT_SMI. See comment in hmR0VmxExitSmi(). */
     AssertMsgFailed(("Unexpected IO SMI VM-exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
+    pVCpu->hm.s.u32HMError = VMX_EXIT_IO_SMI;
     return VERR_VMX_UNEXPECTED_EXIT_CODE;
 }
@@ -7773 +7779 @@
      */
     AssertMsgFailed(("Unexpected SIPI VM-exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
+    pVCpu->hm.s.u32HMError = VMX_EXIT_SIPI;
     return VERR_VMX_UNEXPECTED_EXIT_CODE;
 }

trunk/src/VBox/VMM/VMMR3/HM.cpp

@@ -2975 +2975 @@
                 break;
 
+            case VERR_VMX_UNEXPECTED_EXIT_CODE:
             case VERR_SVM_UNKNOWN_EXIT:
             case VERR_SVM_UNEXPECTED_EXIT: