Changeset 47102 in vbox for trunk

Timestamp:

Jul 11, 2013 3:45:20 PM (12 years ago)

Author:

vboxsync

Message:

Runtime: Missing checks for RTPROC_FLAGS_SAME_CONTRACT in the process creation code. Causes the child to end up with a different contract when forking a second time

File:

• trunk/src/VBox/Runtime/r3/posix/process-creation-posix.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/r3/posix/process-creation-posix.cpp

@@ -564 +564 @@
     {
 #ifdef RT_OS_SOLARIS
-        int templateFd = rtSolarisContractPreFork();
-        if (templateFd == -1)
-            return VERR_OPEN_FAILED;
+        if (!(fFlags & RTPROC_FLAGS_SAME_CONTRACT))
+        {
+            int templateFd = rtSolarisContractPreFork();
+            if (templateFd == -1)
+                return VERR_OPEN_FAILED;
+        }
 #endif /* RT_OS_SOLARIS */
         pid = fork();
@@ -572 +575 @@
         {
 #ifdef RT_OS_SOLARIS
-            rtSolarisContractPostForkChild(templateFd);
+            if (!(fFlags & RTPROC_FLAGS_SAME_CONTRACT))
+                rtSolarisContractPostForkChild(templateFd);
 #endif /* RT_OS_SOLARIS */
             if (!(fFlags & RTPROC_FLAGS_DETACHED))
@@ -659 +663 @@
         }
 #ifdef RT_OS_SOLARIS
-        rtSolarisContractPostForkParent(templateFd, pid);
+        if (!(fFlags & RTPROC_FLAGS_SAME_CONTRACT))
+            rtSolarisContractPostForkParent(templateFd, pid);
 #endif /* RT_OS_SOLARIS */
         if (pid > 0)