Changeset 47128 in vbox for trunk/src/VBox/NetworkServices

Timestamp:

Jul 13, 2013 8:02:38 AM (11 years ago)

Author:

vboxsync

Message:

note about missed condition for dhcp-opt-lease-time on DHCPACK.
rfc2131 declares MUST on DHCPREQUEST and MUST NOT on DHCPINFORM.
currently it's always sent (that should heal NetBSD and Debian VMs.)

When support of DHCPINFORM will be introduced I should return to DHCPACK generation.

File:

• trunk/src/VBox/NetworkServices/DHCP/Config.cpp (modified) (1 diff)

trunk/src/VBox/NetworkServices/DHCP/Config.cpp

@@ -513 +513 @@
     client->rawOptions.push_back(opt);
 
+    /* XXX: here should be condition MUST NOT on DHCPINFORM */
     opt.u8OptId = RTNET_DHCP_OPT_LEASE_TIME;
     *(uint32_t *)opt.au8RawOpt = RT_H2N_U32(ConfigurationManager::getConfigurationManager()->getLeaseTime());