Changeset 47202 in vbox for trunk/src/VBox/VMM/VMMR0

Timestamp:

Jul 16, 2013 4:55:11 PM (12 years ago)

Author:

vboxsync

Message:

VMM/HM: comments.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -3358 +3358 @@
     /* Validate segment registers. See Intel spec. 26.3.1.2 "Checks on Guest Segment Registers". */
     /* NOTE: The reason we check for attribute value 0 and not just the unusable bit here is because hmR0VmxWriteSegmentReg()
-     * only updates the VMCS bits with the unusable bit and doesn't change the guest-context value. */
+     * only updates the VMCS' copy of the value with the unusable bit and doesn't change the guest-context value. */
     if (   !pVM->hm.s.vmx.fUnrestrictedGuest
         && (   !CPUMIsGuestInRealModeEx(pCtx)
@@ -5593 +5593 @@
 
 /**
- * Saves the guest APIC state from the currentl VMCS into the guest-CPU context.
+ * Saves the guest APIC state from the current VMCS into the guest-CPU context.
  *
  * @returns VBox status code.
@@ -7802 +7802 @@
 {
     /*
-     * INIT signals are blocked in VMX root operation by VMXON and by SMI in SMM. See Intel spec. "33.14.1 Default Treatment of
-     * SMI Delivery" and "29.3 VMX Instructions" for "VMXON". It is -NOT- blocked in VMX non-root operation so we can potentially
-     * still get these exits. See Intel spec. "23.8 Restrictions on VMX operation".
+     * INIT signals are blocked in VMX root operation by VMXON and by SMI in SMM.
+     * See Intel spec. 33.14.1 Default Treatment of SMI Delivery" and Intel spec. 29.3 "VMX Instructions" for "VMXON".
+     *
+     * It is -NOT- blocked in VMX non-root operation so we can, in theory, still get these VM-exits.
+     * See Intel spec. "23.8 Restrictions on VMX operation".
      */
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
-    return VINF_SUCCESS;    /** @todo r=ramshankar: correct?. */
+    return VINF_SUCCESS;
 }