Changeset 47390 in vbox

Timestamp:

Jul 25, 2013 12:40:21 PM (11 years ago)

Author:

vboxsync

Message:

Main: Fix lock order violation in USBDeviceFiltersImpl

File:

• trunk/src/VBox/Main/src-server/USBDeviceFiltersImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/USBDeviceFiltersImpl.cpp

@@ -896 +896 @@
     AssertComRCReturn(autoCaller.rc(), false);
 
-    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
-
     /* It is not possible to work with USB device if there is no USB controller present. */
     if (!m->pParent->isUSBControllerPresent())
         return false;
+
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     /* apply self filters */
@@ -937 +937 @@
     AssertComRCReturn(autoCaller.rc(), false);
 
-    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
-
     /* It is not possible to work with USB device if there is no USB controller present. */
     if (!m->pParent->isUSBControllerPresent())
         return false;
+
+    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     HRESULT rc = S_OK;