Changeset 4743 in vbox for trunk/src/VBox/Additions/linux

Timestamp:

Sep 12, 2007 6:25:23 PM (17 years ago)

Author:

vboxsync

Message:

Fix for when open is called on a Linux guest shared folder with O_CREAT|O_EXCL

Location:

trunk/src/VBox/Additions/linux/sharedfolders

Files:

• dirops.c (modified) (1 diff)
• regops.c (modified) (2 diffs)
• vfsmod.c (modified) (1 diff)

trunk/src/VBox/Additions/linux/sharedfolders/dirops.c

@@ -409 +409 @@
         }
 
-        LogFunc(("sf_create_aux: calling vboxCallCreate, folder %s, flags %#x\n",
+        LogFunc(("calling vboxCallCreate, folder %s, flags %#x\n",
                  path->String.utf8, params.CreateFlags));
         rc = vboxCallCreate (&client_handle, &sf_g->map, path, &params);

trunk/src/VBox/Additions/linux/sharedfolders/regops.c

@@ -221 +221 @@
                 LogFunc(("O_CREAT set\n"));
                 params.CreateFlags |= SHFL_CF_ACT_CREATE_IF_NEW;
-                if (file->f_flags & O_EXCL) {
-                        LogFunc(("O_EXCL set\n"));
-                        params.CreateFlags |= SHFL_CF_ACT_FAIL_IF_EXISTS;
-                }
-                else {
+                /* We ignore O_EXCL, as the Linux kernel seems to call create
+                   beforehand itself, so O_EXCL should always fail. */
+//                if (file->f_flags & O_EXCL) {
+//                        LogFunc(("O_EXCL set\n"));
+//                        params.CreateFlags |= SHFL_CF_ACT_FAIL_IF_EXISTS;
+//                }
+//                else {
                         /* O_TRUNC combined with O_EXCL is undefined. */
                         if (file->f_flags & O_TRUNC) {
@@ -234 +236 @@
                                 params.CreateFlags |= SHFL_CF_ACT_OPEN_IF_EXISTS;
                         }
-                }
+//                }
         }
         else {

trunk/src/VBox/Additions/linux/sharedfolders/vfsmod.c

@@ -22 +22 @@
  */
 
+/**
+ * @note Anyone wishing to make changes here might wish to take a look at
+ *  http://www.atnf.csiro.au/people/rgooch/linux/vfs.txt
+ * which seems to be the closest there is to official documentation on
+ * writing filesystem drivers for Linux.
+ */
+
 /*
  * Suppress the definition of wchar_t from stddef.h that occurs below.