Changeset 47434 in vbox

Timestamp:

Jul 27, 2013 1:34:28 AM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

87588

Message:

HMR0VMX.cpp: INS/OUTS todo update.

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IOMAllMMIO.cpp (modified) (4 diffs)
• VMMR0/HMVMXR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IOMAllMMIO.cpp

@@ -2190 +2190 @@
 
 
+#if defined(VBOX_WITH_FIRST_IEM_STEP) || defined(IN_RC) /* Latter for IOMRCIOPortHandler */
 /**
  * [REP*] INSB/INSW/INSD
@@ -2232 +2233 @@
     return IOMInterpretINSEx(pVM, pVCpu, pRegFrame, Port, pCpu->fPrefix, (DISCPUMODE)pCpu->uAddrMode, cb);
 }
+#endif /* !IEM || RC */
 
 
@@ -2357 +2359 @@
 
 
+#if defined(VBOX_WITH_FIRST_IEM_STEP) || defined(IN_RC) /* Latter for IOMRCIOPortHandler */
 /**
  * [REP*] OUTSB/OUTSW/OUTSD
@@ -2401 +2404 @@
     return IOMInterpretOUTSEx(pVM, pVCpu, pRegFrame, Port, pCpu->fPrefix, (DISCPUMODE)pCpu->uAddrMode, cb);
 }
+#endif /* !IEM || RC */
 
 #ifndef IN_RC

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -8358 +8358 @@
          *        the VMCS. VMX_VMCS_RO_EXIT_GUEST_LINEAR_ADDR contains the flat pointer
          *        operand of the instruction. VMX_VMCS32_RO_EXIT_INSTR_INFO contains
-         *        segment prefix info. */
+         *        segment prefix info.
+         *  bird: The linear address isn't worth more than a few ticks, esp. for
+         *        32-bit guests where we'd have to do limit checks.  Main point,
+         *        though, is that AMD doesn't have it. They both have segment reg,
+         *        address mode (size) and operand size. Though, Intel didn't have the
+         *        segment+addrsize on the early models (Footnote 3 on table 27-8, volume
+         *        3, July 2013 edition). */
         PDISCPUSTATE pDis = &pVCpu->hm.s.DisState;
         rc = EMInterpretDisasCurrent(pVM, pVCpu, pDis, NULL);