Changeset 47592 in vbox for trunk

Timestamp:

Aug 7, 2013 1:58:24 PM (11 years ago)

Author:

vboxsync

Message:

Small changes to tidy up 6787 Contrl VboxSV release logging

File:

• trunk/src/VBox/Main/src-server/SystemPropertiesImpl.cpp (modified) (4 diffs)

trunk/src/VBox/Main/src-server/SystemPropertiesImpl.cpp

@@ -657 +657 @@
 
     Utf8Str useLoggingLevel(m->strLoggingLevel);
-    useLoggingLevel = (useLoggingLevel.isEmpty() ? VBOXSVC_LOG_DEFAULT : useLoggingLevel);
+    if (useLoggingLevel.isEmpty())
+        useLoggingLevel = VBOXSVC_LOG_DEFAULT;
 
     useLoggingLevel.cloneTo(aLoggingLevel);
@@ -679 +680 @@
     }
     else
-    {
-        LogRel(("Cannot set passed logging level=%ls, or the default one - Error=%Rrc \n", aLoggingLevel, rc));
-    }
+        LogRel(("Cannot set passed logging level=%ls, or the default one - Error=%Rhrc \n", aLoggingLevel, rc));
 
     return rc;
@@ -1288 +1287 @@
     rc = RTLogGroupSettings(RTLogRelDefaultInstance(), useLoggingLevel.c_str());
     //  If failed and not the default logging level - try to use the default logging level.
-    if (!RT_SUCCESS(rc))
+    if (RT_FAILURE(rc))
     {
         // If failed write message to the release log.
@@ -1297 +1296 @@
             rc = RTLogGroupSettings(RTLogRelDefaultInstance(), VBOXSVC_LOG_DEFAULT);
             // If failed report this to the release log.
-            if (!RT_SUCCESS(rc))
+            if (RT_FAILURE(rc))
                 LogRel(("Cannot set default logging level Error=%Rrc \n", rc));
         }