Changeset 47787 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Aug 16, 2013 9:00:01 AM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

88048

Message:

DevATA: Avoid truncating passthrough ATAPI transfers larger than I/O buffer size.

File:

• trunk/src/VBox/Devices/Storage/DevATA.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -1934 +1934 @@
     PSTAMPROFILEADV pProf = NULL;
 
-    cbTransfer = RT_MIN(s->cbElementaryTransfer, s->cbIOBuffer);
+    cbTransfer = RT_MIN(s->cbTotalTransfer, s->cbIOBuffer);
 
     if (s->uTxDir == PDMBLOCKTXDIR_TO_DEVICE)
@@ -2162 +2162 @@
             /*
              * Reply with the same amount of data as the real drive
-             * but only if the command wasn't splitted.
+             * but only if the command wasn't split.
              */
+#if 0   //@todo: This destroys commands where cbTotalTransfer > cbIOBuffer
             if (s->cbElementaryTransfer < s->cbIOBuffer)
                 s->cbTotalTransfer = cbTransfer;
+#endif
 
             if (   s->aATAPICmd[0] == SCSI_INQUIRY
@@ -3692 +3694 @@
             /*
              * Send a command to the drive, passing data in/out as required.
-             * Commands which exceed the I/O buffer size are splitted below
+             * Commands which exceed the I/O buffer size are split below
              * or aborted if splitting is not implemented.
              */