Changeset 47944 in vbox for trunk/src/VBox/Frontends

Timestamp:

Aug 21, 2013 7:36:55 AM (11 years ago)

Author:

vboxsync

Message:

FE/Qt: Settings Dialog: Reworking validation mechanism to reflect all the validation warnings.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings

Files:

• UISettingsDialog.cpp (modified) (2 diffs)
• UISettingsPage.h (modified) (2 diffs)
• global/UIGlobalSettingsInput.cpp (modified) (1 diff)
• global/UIGlobalSettingsInput.h (modified) (1 diff)
• global/UIGlobalSettingsNetwork.cpp (modified) (6 diffs)
• global/UIGlobalSettingsNetwork.h (modified) (2 diffs)
• global/UIGlobalSettingsProxy.cpp (modified) (2 diffs)
• global/UIGlobalSettingsProxy.h (modified) (1 diff)
• machine/UIMachineSettingsDisplay.cpp (modified) (1 diff)
• machine/UIMachineSettingsDisplay.h (modified) (1 diff)
• machine/UIMachineSettingsGeneral.cpp (modified) (2 diffs)
• machine/UIMachineSettingsGeneral.h (modified) (1 diff)
• machine/UIMachineSettingsNetwork.cpp (modified) (8 diffs)
• machine/UIMachineSettingsNetwork.h (modified) (2 diffs)
• machine/UIMachineSettingsParallel.cpp (modified) (1 diff)
• machine/UIMachineSettingsParallel.h (modified) (1 diff)
• machine/UIMachineSettingsSerial.cpp (modified) (1 diff)
• machine/UIMachineSettingsSerial.h (modified) (1 diff)
• machine/UIMachineSettingsStorage.cpp (modified) (4 diffs)
• machine/UIMachineSettingsStorage.h (modified) (1 diff)
• machine/UIMachineSettingsSystem.cpp (modified) (1 diff)
• machine/UIMachineSettingsSystem.h (modified) (1 diff)
• machine/UIMachineSettingsUSB.cpp (modified) (2 diffs)
• machine/UIMachineSettingsUSB.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsDialog.cpp

@@ -297 +297 @@
     /* Perform page revalidation: */
     UISettingsPage *pSettingsPage = pValidator->page();
-    QString strPageTitle = m_pSelector->itemTextByPage(pSettingsPage);
-    QString strMessageText;
-    bool fIsValid = pSettingsPage->validate(strMessageText, strPageTitle);
+    QList<UIValidationMessage> messages;
+    bool fIsValid = pSettingsPage->validate(messages);
 
     /* Remember revalidation result: */
@@ -305 +304 @@
 
     /* Remember warning/error message: */
-    if (strMessageText.isEmpty())
+    if (messages.isEmpty())
         pValidator->setLastMessage(QString());
     else
     {
-        pValidator->setLastMessage(tr("<b>%1</b> page:<br><br>%2").arg(strPageTitle, strMessageText));
+        /* Prepare title prefix: */
+        // Its the only thing preventing us from moving this method to validator.
+        const QString strTitlePrefix(m_pSelector->itemTextByPage(pSettingsPage));
+        /* Prepare text: */
+        QStringList text;
+        foreach (const UIValidationMessage &message, messages)
+        {
+            /* Prepare title: */
+            const QString strTitle(message.first.isNull() ? tr("<b>%1</b> page:").arg(strTitlePrefix) :
+                                                            tr("<b>%1: %2</b> page:").arg(strTitlePrefix, message.first));
+            /* Prepare paragraph: */
+            QStringList paragraph(message.second);
+            paragraph.prepend(strTitle);
+            /* Format text for iterated message: */
+            text << paragraph.join("<br>");
+        }
+        /* Remember text: */
+        pValidator->setLastMessage(text.join("<br><br>"));
         LogRel(("Settings Dialog:  Page validation FAILED: {%s}\n",
                 pValidator->lastMessage().toUtf8().constData()));

trunk/src/VBox/Frontends/VirtualBox/src/settings/UISettingsPage.h

@@ -72 +72 @@
 Q_DECLARE_METATYPE(UISettingsDataMachine);
 
+/* Validation message type: */
+typedef QPair<QString, QStringList> UIValidationMessage;
+
 /* Settings page base class: */
 class UISettingsPage : public QIWithRetranslateUI<QWidget>
@@ -96 +99 @@
     void setValidator(UIPageValidator *pValidator);
     void setValidatorBlocked(bool fIsValidatorBlocked) { m_fIsValidatorBlocked = fIsValidatorBlocked; }
-    virtual bool validate(QString& /* strWarningText */, QString& /* strTitle */) { return true; }
+    virtual bool validate(QList<UIValidationMessage>& /* messages */) { return true; }
 
     /* Navigation stuff: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsInput.cpp

@@ -161 +161 @@
 }
 
-bool UIGlobalSettingsInput::validate(QString &strWarning, QString &strTitle)
-{
-    /* Check for unique shortcuts: */
+bool UIGlobalSettingsInput::validate(QList<UIValidationMessage> &messages)
+{
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Check VirtualBox Manager page for unique shortcuts: */
     if (!m_pSelectorModel->isAllShortcutsUnique())
     {
-        strTitle += ": " + VBoxGlobal::removeAccelMark(m_pTabWidget->tabText(UIHotKeyTableIndex_Selector));
-        strWarning = tr("Some items have the same shortcuts assigned.");
-        return false;
-    }
-    else if (!m_pMachineModel->isAllShortcutsUnique())
-    {
-        strTitle += ": " + VBoxGlobal::removeAccelMark(m_pTabWidget->tabText(UIHotKeyTableIndex_Machine));
-        strWarning = tr("Some items have the same shortcuts assigned.");
-        return false;
-    }
-
-    /* Pass by default: */
-    return true;
+        UIValidationMessage message;
+        message.first = VBoxGlobal::removeAccelMark(m_pTabWidget->tabText(UIHotKeyTableIndex_Selector));
+        message.second << tr("Some items have the same shortcuts assigned.");
+        messages << message;
+        fPass = false;
+    }
+
+    /* Check Virtual Machine page for unique shortcuts: */
+    if (!m_pMachineModel->isAllShortcutsUnique())
+    {
+        UIValidationMessage message;
+        message.first = VBoxGlobal::removeAccelMark(m_pTabWidget->tabText(UIHotKeyTableIndex_Machine));
+        message.second << tr("Some items have the same shortcuts assigned.");
+        messages << message;
+        fPass = false;
+    }
+
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsInput.h

@@ -140 +140 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     /* Helper: Navigation stuff: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsNetwork.cpp

@@ -58 +58 @@
 
 /* Validation stuff: */
-bool UIHostInterfaceItem::validate(QString &strWarning, QString&)
-{
+bool UIHostInterfaceItem::validate(QList<UIValidationMessage> &messages)
+{
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Prepare message: */
+    UIValidationMessage message;
+
     /* Host-only interface validation: */
     if (!m_data.m_interface.m_fDhcpClientEnabled)
@@ -67 +73 @@
              QHostAddress(m_data.m_interface.m_strInterfaceAddress).protocol() != QAbstractSocket::IPv4Protocol))
         {
-            strWarning = UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid IPv4 address.").arg(text(0));
-            return false;
+            message.second << UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid IPv4 address.").arg(text(0));
+            fPass = false;
         }
         if (!m_data.m_interface.m_strInterfaceMask.isEmpty() &&
@@ -74 +80 @@
              QHostAddress(m_data.m_interface.m_strInterfaceMask).protocol() != QAbstractSocket::IPv4Protocol))
         {
-            strWarning = UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid IPv4 network mask.").arg(text(0));
-            return false;
+            message.second << UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid IPv4 network mask.").arg(text(0));
+            fPass = false;
         }
         if (m_data.m_interface.m_fIpv6Supported)
@@ -83 +89 @@
                  QHostAddress(m_data.m_interface.m_strInterfaceAddress6).protocol() != QAbstractSocket::IPv6Protocol))
             {
-                strWarning = UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid IPv6 address.").arg(text(0));
-                return false;
+                message.second << UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid IPv6 address.").arg(text(0));
+                fPass = false;
             }
         }
@@ -95 +101 @@
             QHostAddress(m_data.m_dhcpserver.m_strDhcpServerAddress).protocol() != QAbstractSocket::IPv4Protocol)
         {
-            strWarning = UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid DHCP server address.").arg(text(0));
-            return false;
+            message.second << UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid DHCP server address.").arg(text(0));
+            fPass = false;
         }
         if (QHostAddress(m_data.m_dhcpserver.m_strDhcpServerMask) == QHostAddress::Any ||
             QHostAddress(m_data.m_dhcpserver.m_strDhcpServerMask).protocol() != QAbstractSocket::IPv4Protocol)
         {
-            strWarning = UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid DHCP server mask.").arg(text(0));
-            return false;
+            message.second << UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid DHCP server mask.").arg(text(0));
+            fPass = false;
         }
         if (QHostAddress(m_data.m_dhcpserver.m_strDhcpLowerAddress) == QHostAddress::Any ||
             QHostAddress(m_data.m_dhcpserver.m_strDhcpLowerAddress).protocol() != QAbstractSocket::IPv4Protocol)
         {
-            strWarning = UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid DHCP server lower address bound.").arg(text(0));
-            return false;
+            message.second << UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid DHCP server lower address bound.").arg(text(0));
+            fPass = false;
         }
         if (QHostAddress(m_data.m_dhcpserver.m_strDhcpUpperAddress) == QHostAddress::Any ||
             QHostAddress(m_data.m_dhcpserver.m_strDhcpUpperAddress).protocol() != QAbstractSocket::IPv4Protocol)
         {
-            strWarning = UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid DHCP server upper address bound.").arg(text(0));
-            return false;
-        }
-    }
-    return true;
+            message.second << UIGlobalSettingsNetwork::tr("The host interface <b>%1</b> does not currently have a valid DHCP server upper address bound.").arg(text(0));
+            fPass = false;
+        }
+    }
+
+    /* Serialize message: */
+    if (!message.second.isEmpty())
+        messages << message;
+
+    /* Return result: */
+    return fPass;
 }
 
@@ -371 +383 @@
 
 /* Validation processing: */
-bool UIGlobalSettingsNetwork::validate(QString &strWarning, QString &strTitle)
+bool UIGlobalSettingsNetwork::validate(QList<UIValidationMessage> &messages)
 {
     /* Redirect validation to items: */
     UIHostInterfaceItem *pItem = static_cast<UIHostInterfaceItem*>(m_pInterfacesTree->currentItem());
-    return pItem ? pItem->validate(strWarning, strTitle) : true;
+    return pItem ? pItem->validate(messages) : true;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsNetwork.h

@@ -97 +97 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     /* API: Update stuff: */
@@ -164 +164 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     /* Navigation stuff: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsProxy.cpp

@@ -102 +102 @@
 }
 
-bool UIGlobalSettingsProxy::validate(QString &strWarning, QString&)
+bool UIGlobalSettingsProxy::validate(QList<UIValidationMessage> &messages)
 {
     /* Pass if proxy is disabled: */
@@ -108 +108 @@
         return true;
 
-    /* Check for host/port values: */
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Prepare message: */
+    UIValidationMessage message;
+
+    /* Check for host value: */
     if (m_pHostEditor->text().trimmed().isEmpty())
     {
-        strWarning = tr("No proxy host is currently specified.");
-        return false;
-    }
-    else if (m_pPortEditor->text().trimmed().isEmpty())
-    {
-        strWarning = tr("No proxy port is currently specified.");
-        return false;
+        message.second << tr("No proxy host is currently specified.");
+        fPass = false;
     }
 
-    /* Pass by default: */
-    return true;
+    /* Check for port value: */
+    if (m_pPortEditor->text().trimmed().isEmpty())
+    {
+        message.second << tr("No proxy port is currently specified.");
+        fPass = false;
+    }
+
+    /* Serialize message: */
+    if (!message.second.isEmpty())
+        messages << message;
+
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/global/UIGlobalSettingsProxy.h

@@ -62 +62 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     /* Helper: Navigation stuff: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsDisplay.cpp

@@ -301 +301 @@
 }
 
-bool UIMachineSettingsDisplay::validate(QString &strWarning, QString&)
+bool UIMachineSettingsDisplay::validate(QList<UIValidationMessage> &messages)
 {
     /* Check if video RAM requirement changed first: */
     checkVRAMRequirements();
 
-    if (m_pCheckbox3D->isChecked() && !vboxGlobal().is3DAvailable())
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Video tab: */
     {
-        strWarning = tr("The virtual machine is set to use hardware graphics acceleration. "
-                        "However the host system does not currently provide this, "
-                        "so you will not be able to start the machine.");
-        return true;
-    }
-
-    /* Video RAM amount test: */
-    if (shouldWeWarnAboutLowVideoMemory() && !m_guestOSType.isNull())
-    {
-        quint64 uNeedBytes = VBoxGlobal::requiredVideoMemory(m_guestOSType.GetId(), m_pEditorVideoScreenCount->value());
-
-        /* Basic video RAM amount test: */
-        if ((quint64)m_pEditorVideoMemorySize->value() * _1M < uNeedBytes)
+        /* Prepare message: */
+        UIValidationMessage message;
+        message.first = VBoxGlobal::removeAccelMark(m_pTabWidget->tabText(0));
+
+        /* 3D acceleration test: */
+        if (m_pCheckbox3D->isChecked() && !vboxGlobal().is3DAvailable())
         {
-            strWarning = tr("The virtual machine is currently assigned less than <b>%1</b> of video memory "
-                            "which is the minimum amount required to switch to fullscreen or seamless mode.")
-                            .arg(vboxGlobal().formatSize(uNeedBytes, 0, FormatSize_RoundUp));
-            return true;
+            message.second << tr("The virtual machine is set to use hardware graphics acceleration. "
+                                 "However the host system does not currently provide this, "
+                                 "so you will not be able to start the machine.");
         }
-#ifdef VBOX_WITH_VIDEOHWACCEL
-        /* 2D acceleration video RAM amount test: */
-        if (m_pCheckbox2DVideo->isChecked() && m_f2DVideoAccelerationSupported)
+
+        /* Video RAM amount test: */
+        if (shouldWeWarnAboutLowVideoMemory() && !m_guestOSType.isNull())
         {
-            uNeedBytes += VBoxGlobal::required2DOffscreenVideoMemory();
+            quint64 uNeedBytes = VBoxGlobal::requiredVideoMemory(m_guestOSType.GetId(), m_pEditorVideoScreenCount->value());
+
+            /* Basic video RAM amount test: */
             if ((quint64)m_pEditorVideoMemorySize->value() * _1M < uNeedBytes)
             {
-                strWarning = tr("The virtual machine is currently assigned less than <b>%1</b> of video memory "
-                                "which is the minimum amount required for High Definition Video to be played efficiently.")
-                                .arg(vboxGlobal().formatSize(uNeedBytes, 0, FormatSize_RoundUp));
-                return true;
+                message.second << tr("The virtual machine is currently assigned less than <b>%1</b> of video memory "
+                                     "which is the minimum amount required to switch to fullscreen or seamless mode.")
+                                     .arg(vboxGlobal().formatSize(uNeedBytes, 0, FormatSize_RoundUp));
             }
-        }
+#ifdef VBOX_WITH_VIDEOHWACCEL
+            /* 2D acceleration video RAM amount test: */
+            else if (m_pCheckbox2DVideo->isChecked() && m_f2DVideoAccelerationSupported)
+            {
+                uNeedBytes += VBoxGlobal::required2DOffscreenVideoMemory();
+                if ((quint64)m_pEditorVideoMemorySize->value() * _1M < uNeedBytes)
+                {
+                    message.second << tr("The virtual machine is currently assigned less than <b>%1</b> of video memory "
+                                         "which is the minimum amount required for High Definition Video to be played efficiently.")
+                                         .arg(vboxGlobal().formatSize(uNeedBytes, 0, FormatSize_RoundUp));
+                }
+            }
 #endif /* VBOX_WITH_VIDEOHWACCEL */
 #if 0
 # ifdef VBOX_WITH_CRHGSMI
-        if (m_pCheckbox3D->isChecked() && m_fWddmModeSupported)
-        {
-            int cGuestScreenCount = m_pEditorVideoScreenCount->value();
-            uNeedBytes += VBoxGlobal::required3DWddmOffscreenVideoMemory(m_guestOSType.GetId(), cGuestScreenCount);
-            uNeedBytes = qMax(uNeedBytes, 128 * _1M);
-            uNeedBytes = qMin(uNeedBytes, 256 * _1M);
-            if ((quint64)m_pEditorVideoMemorySize->value() * _1M < uNeedBytes)
+            /* 3D acceleration video RAM amount test: */
+            else if (m_pCheckbox3D->isChecked() && m_fWddmModeSupported)
             {
-                strWarning = tr("The virtual machine is set to use hardware graphics acceleration "
-                                "and the operating system hint is set to Windows Vista or later. "
-                                "For best performance you should set the machine's video memory to at least b>%1</b>.")
-                                .arg(vboxGlobal().formatSize(uNeedBytes, 0, FormatSize_RoundUp));
-                return true;
+                int cGuestScreenCount = m_pEditorVideoScreenCount->value();
+                uNeedBytes += VBoxGlobal::required3DWddmOffscreenVideoMemory(m_guestOSType.GetId(), cGuestScreenCount);
+                uNeedBytes = qMax(uNeedBytes, 128 * _1M);
+                uNeedBytes = qMin(uNeedBytes, 256 * _1M);
+                if ((quint64)m_pEditorVideoMemorySize->value() * _1M < uNeedBytes)
+                {
+                    message.second << tr("The virtual machine is set to use hardware graphics acceleration "
+                                         "and the operating system hint is set to Windows Vista or later. "
+                                         "For best performance you should set the machine's video memory to at least b>%1</b>.")
+                                         .arg(vboxGlobal().formatSize(uNeedBytes, 0, FormatSize_RoundUp));
+                }
             }
-        }
 # endif /* VBOX_WITH_CRHGSMI */
 #endif /* 0 */
+        }
+
+#ifdef VBOX_WITH_VIDEOHWACCEL
+        /* 2D video acceleration is available for Windows guests only: */
+        if (m_pCheckbox2DVideo->isChecked() && !m_f2DVideoAccelerationSupported)
+        {
+            message.second << tr("The virtual machine is set to use Video Stream Acceleration. "
+                                 "As this feature only works with Windows guest systems it will be disabled.");
+        }
+#endif /* VBOX_WITH_VIDEOHWACCEL */
+
+        /* Serialize message: */
+        if (!message.second.isEmpty())
+            messages << message;
     }
 
-    /* Check mode availability: */
-#ifdef VBOX_WITH_VIDEOHWACCEL
-    /* 2D video acceleration is available for Windows guests only: */
-    if (m_pCheckbox2DVideo->isChecked() && !m_f2DVideoAccelerationSupported)
+    /* Remote Display tab: */
     {
-        strWarning = tr("The virtual machine is set to use Video Stream Acceleration. "
-                        "As this feature only works with Windows guest systems it will be disabled.");
-        return true;
+        /* Prepare message: */
+        UIValidationMessage message;
+        message.first = VBoxGlobal::removeAccelMark(m_pTabWidget->tabText(1));
+
+        /* Check VRDE server port: */
+        if (m_pEditorRemoteDisplayPort->text().trimmed().isEmpty())
+        {
+            message.second << tr("The VRDE server port value is not currently specified.");
+            fPass = false;
+        }
+
+        /* Check VRDE server timeout: */
+        if (m_pEditorRemoteDisplayTimeout->text().trimmed().isEmpty())
+        {
+            message.second << tr("The VRDE authentication timeout value is not currently specified.");
+            fPass = false;
+        }
+
+        /* Serialize message: */
+        if (!message.second.isEmpty())
+            messages << message;
     }
-#endif /* VBOX_WITH_VIDEOHWACCEL */
-
-    /* Check VRDE server port: */
-    if (m_pEditorRemoteDisplayPort->text().trimmed().isEmpty())
-    {
-        strWarning = tr("The VRDE server port value is not currently specified.");
-        return false;
-    }
-
-    /* Check VRDE server timeout: */
-    if (m_pEditorRemoteDisplayTimeout->text().trimmed().isEmpty())
-    {
-        strWarning = tr("The VRDE authentication timeout value is not currently specified.");
-        return false;
-    }
-
-    /* Pass by default: */
-    return true;
+
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsDisplay.h

@@ -146 +146 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     /* Helper: Navigation stuff: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsGeneral.cpp

@@ -224 +224 @@
 }
 
-bool UIMachineSettingsGeneral::validate(QString &strWarning, QString&)
-{
+bool UIMachineSettingsGeneral::validate(QList<UIValidationMessage> &messages)
+{
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Prepare message: */
+    UIValidationMessage message;
+    message.first = VBoxGlobal::removeAccelMark(mTwGeneral->tabText(0));
+
     /* VM name validation: */
     if (m_pNameAndSystemEditor->name().trimmed().isEmpty())
     {
-        strWarning = tr("No name specified for the virtual machine.");
-        return false;
+        message.second << tr("No name specified for the virtual machine.");
+        fPass = false;
     }
 
@@ -236 +243 @@
     if (is64BitOSTypeSelected() && !m_fHWVirtExEnabled)
     {
-        strWarning = tr("The virtual machine operating system hint is set to a 64-bit type. "
-                        "64-bit guest systems require hardware virtualization, "
-                        "so this will be enabled automatically if you confirm the changes.");
-        return true;
+        message.second << tr("The virtual machine operating system hint is set to a 64-bit type. "
+                             "64-bit guest systems require hardware virtualization, "
+                             "so this will be enabled automatically if you confirm the changes.");
     }
 
-    /* Pass by default: */
-    return true;
+    /* Serialize message: */
+    if (!message.second.isEmpty())
+        messages << message;
+
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsGeneral.h

@@ -107 +107 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     void setOrderAfter (QWidget *aWidget);

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsNetwork.cpp

@@ -163 +163 @@
 }
 
-bool UIMachineSettingsNetwork::validate(QString &strWarning, QString &strTitle)
+bool UIMachineSettingsNetwork::validate(QList<UIValidationMessage> &messages)
 {
     /* Pass if adapter is disabled: */
@@ -169 +169 @@
         return true;
 
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Prepare message: */
+    UIValidationMessage message;
+    message.first = vboxGlobal().removeAccelMark(tabTitle());
+
     /* Validate alternatives: */
-    bool fValid = true;
     switch (attachmentType())
     {
@@ -177 +183 @@
             if (alternativeName().isNull())
             {
-                strWarning = tr("No bridged network adapter is currently selected.");
-                fValid = false;
+                message.second << tr("No bridged network adapter is currently selected.");
+                fPass = false;
             }
             break;
@@ -186 +192 @@
             if (alternativeName().isNull())
             {
-                strWarning = tr("No internal network name is currently specified.");
-                fValid = false;
+                message.second << tr("No internal network name is currently specified.");
+                fPass = false;
             }
             break;
@@ -195 +201 @@
             if (alternativeName().isNull())
             {
-                strWarning = tr("No host-only network adapter is currently selected.");
-                fValid = false;
+                message.second << tr("No host-only network adapter is currently selected.");
+                fPass = false;
             }
             break;
@@ -204 +210 @@
             if (alternativeName().isNull())
             {
-                strWarning = tr("No generic driver is currently selected.");
-                fValid = false;
+                message.second << tr("No generic driver is currently selected.");
+                fPass = false;
             }
             break;
@@ -214 +220 @@
 
     /* Validate MAC-address length: */
-    if (fValid && m_pMACEditor->text().size() < 12)
-    {
-        strWarning = tr("The MAC address must be 12 hexadecimal digits long.");
-        fValid = false;
-    }
+    if (m_pMACEditor->text().size() < 12)
+    {
+        message.second << tr("The MAC address must be 12 hexadecimal digits long.");
+        fPass = false;
+    }
+
     /* Make sure MAC-address is unicast: */
-    if (fValid && m_pMACEditor->text().size() >= 2)
+    if (m_pMACEditor->text().size() >= 2)
     {
         QRegExp validator("^[0-9A-Fa-f][02468ACEace]");
         if (validator.indexIn(m_pMACEditor->text()) != 0)
         {
-            strWarning = tr("The second digit in the MAC address may not be odd as only unicast addresses are allowed.");
-            fValid = false;
-        }
-    }
-
-    if (!fValid)
-        strTitle += ": " + vboxGlobal().removeAccelMark(tabTitle());
-
-    return fValid;
+            message.second << tr("The second digit in the MAC address may not be odd as only unicast addresses are allowed.");
+            fPass = false;
+        }
+    }
+
+    /* Serialize message: */
+    if (!message.second.isEmpty())
+        messages << message;
+
+    /* Return result: */
+    return fPass;
 }
 
@@ -938 +947 @@
 }
 
-bool UIMachineSettingsNetworkPage::validate(QString &strWarning, QString &strTitle)
+bool UIMachineSettingsNetworkPage::validate(QList<UIValidationMessage> &messages)
 {
     /* Pass by default: */
     bool fValid = true;
 
-    /* Delegate validation to adapters: */
+    /* Delegate validation to adapter tabs: */
     for (int i = 0; i < m_pTwAdapters->count(); ++i)
     {
         UIMachineSettingsNetwork *pTab = qobject_cast<UIMachineSettingsNetwork*>(m_pTwAdapters->widget(i));
-        Assert(pTab);
-        fValid = pTab->validate(strWarning, strTitle);
-        if (!fValid)
-            break;
-    }
-
+        AssertMsg(pTab, ("Can't get adapter tab!\n"));
+        if (!pTab->validate(messages))
+            fValid = false;
+    }
+
+    /* Return result: */
     return fValid;
 }

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsNetwork.h

@@ -110 +110 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     /* Navigation stuff: */
@@ -207 +207 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     /* Translation stuff: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsParallel.cpp

@@ -325 +325 @@
 }
 
-bool UIMachineSettingsParallelPage::validate(QString &strWarning, QString &strTitle)
-{
-    bool valid = true;
+bool UIMachineSettingsParallelPage::validate(QList<UIValidationMessage> &messages)
+{
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Validation stuff: */
     QList<QPair<QString, QString> > ports;
     QStringList paths;
 
-    int index = 0;
-    for (; index < mTabWidget->count(); ++ index)
-    {
-        QWidget *tab = mTabWidget->widget (index);
-        UIMachineSettingsParallel *page =
-            static_cast<UIMachineSettingsParallel*> (tab);
-
-        if (!page->mGbParallel->isChecked())
+    /* Validate all the ports: */
+    for (int iIndex = 0; iIndex < mTabWidget->count(); ++iIndex)
+    {
+        /* Get current tab/page: */
+        QWidget *pTab = mTabWidget->widget(iIndex);
+        UIMachineSettingsParallel *pPage = static_cast<UIMachineSettingsParallel*> (pTab);
+        if (!pPage->mGbParallel->isChecked())
             continue;
 
-        /* Check the predefined port attributes uniqueness: */
-        {
-            QString strIRQ = page->mLeIRQ->text();
-            QString strIOPort = page->mLeIOPort->text();
-            QPair<QString, QString> pair(strIRQ, strIOPort);
-            valid = !strIRQ.isEmpty() && !strIOPort.isEmpty() && !ports.contains(pair);
-            if (!valid)
-            {
-                if (strIRQ.isEmpty())
-                    strWarning = tr("No IRQ is currently specified.");
-                else if (strIOPort.isEmpty())
-                    strWarning = tr("No I/O port is currently specified.");
-                else
-                    strWarning = tr("Two or more ports have the same settings.");
-                strTitle += ": " +
-                    vboxGlobal().removeAccelMark(mTabWidget->tabText(mTabWidget->indexOf(tab)));
-            }
-            ports << pair;
-        }
-
-        /* Check the port path emptiness & unicity */
-        {
-            QString path = page->mLePath->text();
-            valid = !path.isEmpty() && !paths.contains (path);
-            if (!valid)
-            {
-                strWarning = path.isEmpty() ?
-                    tr("No port path is currently specified.") :
-                    tr("There are currently duplicate port paths specified.");
-                strTitle += ": " +
-                    vboxGlobal().removeAccelMark (mTabWidget->tabText (mTabWidget->indexOf (tab)));
-                break;
-            }
-            paths << path;
-        }
-    }
-
-    return valid;
+        /* Prepare message: */
+        UIValidationMessage message;
+        message.first = vboxGlobal().removeAccelMark(mTabWidget->tabText(mTabWidget->indexOf(pTab)));
+
+        /* Check the port attribute emptiness & uniqueness: */
+        const QString strIRQ(pPage->mLeIRQ->text());
+        const QString strIOPort(pPage->mLeIOPort->text());
+        const QString strPath(pPage->mLePath->text());
+        QPair<QString, QString> pair(strIRQ, strIOPort);
+
+        if (strIRQ.isEmpty())
+        {
+            message.second << tr("No IRQ is currently specified.");
+            fPass = false;
+        }
+        if (strIOPort.isEmpty())
+        {
+            message.second << tr("No I/O port is currently specified.");
+            fPass = false;
+        }
+        if (ports.contains(pair))
+        {
+            message.second << tr("Two or more ports have the same settings.");
+            fPass = false;
+        }
+        if (strPath.isEmpty())
+        {
+            message.second << tr("No port path is currently specified.");
+            fPass = false;
+        }
+        if (paths.contains(strPath))
+        {
+            message.second << tr("There are currently duplicate port paths specified.");
+            fPass = false;
+        }
+
+        ports << pair;
+        paths << strPath;
+
+        /* Serialize message: */
+        if (!message.second.isEmpty())
+            messages << message;
+    }
+
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsParallel.h

@@ -136 +136 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     void retranslateUi();

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSerial.cpp

@@ -368 +368 @@
 }
 
-bool UIMachineSettingsSerialPage::validate(QString &strWarning, QString &strTitle)
-{
-    bool valid = true;
+bool UIMachineSettingsSerialPage::validate(QList<UIValidationMessage> &messages)
+{
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Validation stuff: */
     QList<QPair<QString, QString> > ports;
     QStringList paths;
 
-    int index = 0;
-    for (; index < mTabWidget->count(); ++ index)
-    {
-        QWidget *tab = mTabWidget->widget (index);
-        UIMachineSettingsSerial *page =
-            static_cast<UIMachineSettingsSerial*> (tab);
-
+    /* Validate all the ports: */
+    for (int iIndex = 0; iIndex < mTabWidget->count(); ++iIndex)
+    {
+        /* Get current tab/page: */
+        QWidget *pTab = mTabWidget->widget(iIndex);
+        UIMachineSettingsSerial *page = static_cast<UIMachineSettingsSerial*>(pTab);
         if (!page->mGbSerial->isChecked())
             continue;
 
-        /* Check the predefined port attributes uniqueness: */
-        {
-            QString strIRQ = page->mLeIRQ->text();
-            QString strIOPort = page->mLeIOPort->text();
-            QPair<QString, QString> pair(strIRQ, strIOPort);
-            valid = !strIRQ.isEmpty() && !strIOPort.isEmpty() && !ports.contains(pair);
-            if (!valid)
+        /* Prepare message: */
+        UIValidationMessage message;
+        message.first = vboxGlobal().removeAccelMark(mTabWidget->tabText(mTabWidget->indexOf(pTab)));
+
+        /* Check the port attribute emptiness & uniqueness: */
+        const QString strIRQ(page->mLeIRQ->text());
+        const QString strIOPort(page->mLeIOPort->text());
+        QPair<QString, QString> pair(strIRQ, strIOPort);
+
+        if (strIRQ.isEmpty())
+        {
+            message.second << tr("No IRQ is currently specified.");
+            fPass = false;
+        }
+        if (strIOPort.isEmpty())
+        {
+            message.second << tr("No I/O port is currently specified.");
+            fPass = false;
+        }
+        if (ports.contains(pair))
+        {
+            message.second << tr("Two or more ports have the same settings.");
+            fPass = false;
+        }
+
+        ports << pair;
+
+        KPortMode mode = gpConverter->fromString<KPortMode>(page->mCbMode->currentText());
+        if (mode != KPortMode_Disconnected)
+        {
+            const QString strPath(page->mLePath->text());
+
+            if (strPath.isEmpty())
             {
-                if (strIRQ.isEmpty())
-                    strWarning = tr("No IRQ is currently specified.");
-                else if (strIOPort.isEmpty())
-                    strWarning = tr("No I/O port is currently specified.");
-                else
-                    strWarning = tr("Two or more ports have the same settings.");
-                strTitle += ": " +
-                    vboxGlobal().removeAccelMark(mTabWidget->tabText(mTabWidget->indexOf(tab)));
+                message.second << tr("No port path is currently specified.");
+                fPass = false;
             }
-            ports << pair;
-        }
-
-        /* Check the port path emptiness & unicity */
-        KPortMode mode =
-            gpConverter->fromString<KPortMode> (page->mCbMode->currentText());
-        if (mode != KPortMode_Disconnected)
-        {
-            QString path = page->mLePath->text();
-            valid = !path.isEmpty() && !paths.contains (path);
-            if (!valid)
+            if (paths.contains(strPath))
             {
-                if (!page->mGbSerial->isChecked())
-                    page->mCbMode->setCurrentIndex (KPortMode_Disconnected);
-                else
-                {
-                    strWarning = path.isEmpty() ?
-                        tr("No port path is currently specified.") :
-                        tr("There are currently duplicate port paths specified.");
-                    strTitle += ": " +
-                        vboxGlobal().removeAccelMark (mTabWidget->tabText (mTabWidget->indexOf (tab)));
-                    break;
-                }
+                message.second << tr("There are currently duplicate port paths specified.");
+                fPass = false;
             }
-            paths << path;
-        }
-    }
-
-    return valid;
+
+            paths << strPath;
+        }
+
+        /* Serialize message: */
+        if (!message.second.isEmpty())
+            messages << message;
+    }
+
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSerial.h

@@ -143 +143 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     void retranslateUi();

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp

@@ -2104 +2104 @@
 }
 
-bool UIMachineSettingsStorage::validate(QString &strWarning, QString&)
-{
+bool UIMachineSettingsStorage::validate(QList<UIValidationMessage> &messages)
+{
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Prepare message: */
+    UIValidationMessage message;
+
     /* Check controllers for name emptiness & coincidence.
      * Check attachments for the hd presence / uniqueness. */
@@ -2116 +2122 @@
         QModelIndex ctrIndex = rootIndex.child (i, 0);
         QString ctrName = mStorageModel->data (ctrIndex, StorageModel::R_CtrName).toString();
+
         /* Check for name emptiness: */
         if (ctrName.isEmpty())
         {
-            strWarning = tr("No name is currently specified for the controller at position <b>%1</b>.").arg(i + 1);
-            return false;
+            message.second << tr("No name is currently specified for the controller at position <b>%1</b>.").arg(i + 1);
+            fPass = false;
         }
         /* Check for name coincidence: */
         if (names.values().contains(ctrName))
         {
-            strWarning = tr("The controller at position <b>%1</b> has the same name as the controller at position <b>%2</b>.")
-                            .arg(i + 1).arg(names.key(ctrName) + 1);
-            return false;
-        }
-        else names.insert(i, ctrName);
+            message.second << tr("The controller at position <b>%1</b> has the same name as the controller at position <b>%2</b>.")
+                                 .arg(i + 1).arg(names.key(ctrName) + 1);
+            fPass = false;
+        }
+        else
+            names.insert(i, ctrName);
+
         /* For each attachment: */
         for (int j = 0; j < mStorageModel->rowCount (ctrIndex); ++ j)
@@ -2138 +2147 @@
             QString key (mStorageModel->data (attIndex, StorageModel::R_AttMediumId).toString());
             QString value (QString ("%1 (%2)").arg (ctrName, gpConverter->toString (attSlot)));
-            /* Check for emptiness */
+            /* Check for emptiness: */
             if (vboxGlobal().findMedium (key).isNull() && attDevice == KDeviceType_HardDisk)
             {
-                strWarning = tr("No hard disk is selected for <i>%1</i>.").arg (value);
-                return false;
+                message.second << tr("No hard disk is selected for <i>%1</i>.").arg (value);
+                fPass = false;
             }
-            /* Check for coincidence */
+            /* Check for coincidence: */
             if (!vboxGlobal().findMedium (key).isNull() && config.contains (key))
             {
-                strWarning = tr("<i>%1</i> is using a disk that is already attached to <i>%2</i>.")
-                                .arg (value).arg (config [key]);
-                return false;
+                message.second << tr("<i>%1</i> is using a disk that is already attached to <i>%2</i>.")
+                                     .arg (value).arg (config [key]);
+                fPass = false;
             }
-            else config.insert (key, value);
+            else
+                config.insert (key, value);
         }
     }
@@ -2173 +2183 @@
     if (!excessiveList.isEmpty())
     {
-        strWarning = tr("The machine currently has more storage controllers assigned than a %1 chipset supports. "
-                        "Please change the chipset type on the System settings page or reduce the number "
-                        "of the following storage controllers on the Storage settings page: %2")
-                        .arg(gpConverter->toString(mStorageModel->chipsetType()))
-                        .arg(excessiveList.join(", "));
-        return false;
-    }
-
-    /* Pass by default: */
-    return true;
+        message.second << tr("The machine currently has more storage controllers assigned than a %1 chipset supports. "
+                             "Please change the chipset type on the System settings page or reduce the number "
+                             "of the following storage controllers on the Storage settings page: %2")
+                             .arg(gpConverter->toString(mStorageModel->chipsetType()))
+                             .arg(excessiveList.join(", "));
+        fPass = false;
+    }
+
+    /* Serialize message: */
+    if (!message.second.isEmpty())
+        messages << message;
+
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.h

@@ -674 +674 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     void retranslateUi();

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp

@@ -285 +285 @@
 }
 
-bool UIMachineSettingsSystem::validate(QString &strWarning, QString&)
-{
-    /* RAM amount test: */
-    ulong uFullSize = vboxGlobal().host().GetMemorySize();
-    if (m_pSliderMemorySize->value() > (int)m_pSliderMemorySize->maxRAMAlw())
-    {
-        strWarning = tr(
-            "More than <b>%1%</b> of the host computer's memory (<b>%2</b>) is assigned to the virtual machine. "
-            "Not enough memory is left for the host operating system. Please select a smaller amount.")
-            .arg((unsigned)qRound((double)m_pSliderMemorySize->maxRAMAlw() / uFullSize * 100.0))
-            .arg(vboxGlobal().formatSize((uint64_t)uFullSize * _1M));
-        return false;
-    }
-    if (m_pSliderMemorySize->value() > (int)m_pSliderMemorySize->maxRAMOpt())
-    {
-        strWarning = tr(
-            "More than <b>%1%</b> of the host computer's memory (<b>%2</b>) is assigned to the virtual machine. "
-            "There might not be enough memory left for the host operating system. Please consider selecting a smaller amount.")
-            .arg((unsigned)qRound((double)m_pSliderMemorySize->maxRAMOpt() / uFullSize * 100.0))
-            .arg(vboxGlobal().formatSize((uint64_t)uFullSize * _1M));
-        return true;
-    }
-
-    /* VCPU amount test: */
-    int cTotalCPUs = vboxGlobal().host().GetProcessorOnlineCount();
-    if (m_pSliderCPUCount->value() > 2 * cTotalCPUs)
-    {
-        strWarning = tr(
-            "For performance reasons, the number of virtual CPUs attached to the virtual machine may not be more than twice the number "
-            "of physical CPUs on the host (<b>%1</b>). Please reduce the number of virtual CPUs.")
-            .arg(cTotalCPUs);
-        return false;
-    }
-    if (m_pSliderCPUCount->value() > cTotalCPUs)
-    {
-        strWarning = tr(
-            "More virtual CPUs are assigned to the virtual machine than the number of physical CPUs on the host system (<b>%1</b>). "
-            "This is likely to degrade the performance of your virtual machine. Please consider reducing the number of virtual CPUs.")
-            .arg(cTotalCPUs);
-        return true;
-    }
-
-    /* VCPU IO-APIC test: */
-    if (m_pSliderCPUCount->value() > 1 && !m_pCheckBoxApic->isChecked())
-    {
-        strWarning = tr(
-            "The IO APIC feature is not currently enabled in the Motherboard section of the System page. "
-            "This is needed in order to support more than one virtual processor. "
-            "It will be done automatically if you confirm your changes.");
-        return true;
-    }
-
-    /* VCPU VT-x/AMD-V test: */
-    if (m_pSliderCPUCount->value() > 1 && !m_pCheckBoxVirtualization->isChecked())
-    {
-        strWarning = tr(
-            "Hardware virtualization is not currently enabled in the Acceleration section of the System page. "
-            "This is needed in order to support more than one virtual processor. "
-            "It will be done automatically if you confirm your changes.");
-        return true;
-    }
-
-    /* CPU execution cap is low: */
-    if (m_pSliderCPUExecCap->value() < (int)m_uMedGuestCPUExecCap)
-    {
-        strWarning = tr(
-            "The processor execution cap is set to a low value. This may make the machine feel slow to respond.");
-        return true;
-    }
-
-    /* Chipset type & IO-APIC test: */
-    if ((KChipsetType)m_pComboChipsetType->itemData(m_pComboChipsetType->currentIndex()).toInt() == KChipsetType_ICH9 && !m_pCheckBoxApic->isChecked())
-    {
-        strWarning = tr(
-            "The I/O APIC feature is not currently enabled in the Motherboard section of the System page. "
-            "This is needed in order to support a chip set of type ICH9. "
-            "It will be done automatically if you confirm your changes.");
-        return true;
-    }
-
-    /* HID dependency from OHCI feature: */
-    if (isHIDEnabled() && !m_fOHCIEnabled)
-    {
-        strWarning = tr(
-            "USB controller emulation is not currently enabled on the USB page. "
-            "This is needed to support an emulated USB input device. "
-            "It will be done automatically if you confirm your changes.");
-        return true;
-    }
-
-    return true;
+bool UIMachineSettingsSystem::validate(QList<UIValidationMessage> &messages)
+{
+    /* Pass by default: */
+    bool fPass = true;
+
+    /* Motherboard tab: */
+    {
+        /* Prepare message: */
+        UIValidationMessage message;
+        message.first = VBoxGlobal::removeAccelMark(m_pTabWidgetSystem->tabText(0));
+
+        /* RAM amount test: */
+        ulong uFullSize = vboxGlobal().host().GetMemorySize();
+        if (m_pSliderMemorySize->value() > (int)m_pSliderMemorySize->maxRAMAlw())
+        {
+            message.second << tr(
+                "More than <b>%1%</b> of the host computer's memory (<b>%2</b>) is assigned to the virtual machine. "
+                "Not enough memory is left for the host operating system. Please select a smaller amount.")
+                .arg((unsigned)qRound((double)m_pSliderMemorySize->maxRAMAlw() / uFullSize * 100.0))
+                .arg(vboxGlobal().formatSize((uint64_t)uFullSize * _1M));
+            fPass = false;
+        }
+        else if (m_pSliderMemorySize->value() > (int)m_pSliderMemorySize->maxRAMOpt())
+        {
+            message.second << tr(
+                "More than <b>%1%</b> of the host computer's memory (<b>%2</b>) is assigned to the virtual machine. "
+                "There might not be enough memory left for the host operating system. Please consider selecting a smaller amount.")
+                .arg((unsigned)qRound((double)m_pSliderMemorySize->maxRAMOpt() / uFullSize * 100.0))
+                .arg(vboxGlobal().formatSize((uint64_t)uFullSize * _1M));
+        }
+
+        /* Chipset type vs IO-APIC test: */
+        if ((KChipsetType)m_pComboChipsetType->itemData(m_pComboChipsetType->currentIndex()).toInt() == KChipsetType_ICH9 && !m_pCheckBoxApic->isChecked())
+        {
+            message.second << tr(
+                "The I/O APIC feature is not currently enabled in the Motherboard section of the System page. "
+                "This is needed in order to support a chip set of type ICH9. "
+                "It will be done automatically if you confirm your changes.");
+        }
+
+        /* HID vs OHCI test: */
+        if (isHIDEnabled() && !m_fOHCIEnabled)
+        {
+            message.second << tr(
+                "USB controller emulation is not currently enabled on the USB page. "
+                "This is needed to support an emulated USB input device. "
+                "It will be done automatically if you confirm your changes.");
+        }
+
+        /* Serialize message: */
+        if (!message.second.isEmpty())
+            messages << message;
+    }
+
+    /* CPU tab: */
+    {
+        /* Prepare message: */
+        UIValidationMessage message;
+        message.first = VBoxGlobal::removeAccelMark(m_pTabWidgetSystem->tabText(1));
+
+        /* VCPU amount test: */
+        int cTotalCPUs = vboxGlobal().host().GetProcessorOnlineCount();
+        if (m_pSliderCPUCount->value() > 2 * cTotalCPUs)
+        {
+            message.second << tr(
+                "For performance reasons, the number of virtual CPUs attached to the virtual machine may not be more than twice the number "
+                "of physical CPUs on the host (<b>%1</b>). Please reduce the number of virtual CPUs.")
+                .arg(cTotalCPUs);
+            fPass = false;
+        }
+        else if (m_pSliderCPUCount->value() > cTotalCPUs)
+        {
+            message.second << tr(
+                "More virtual CPUs are assigned to the virtual machine than the number of physical CPUs on the host system (<b>%1</b>). "
+                "This is likely to degrade the performance of your virtual machine. Please consider reducing the number of virtual CPUs.")
+                .arg(cTotalCPUs);
+        }
+
+        /* VCPU vs IO-APIC test: */
+        if (m_pSliderCPUCount->value() > 1 && !m_pCheckBoxApic->isChecked())
+        {
+            message.second << tr(
+                "The IO APIC feature is not currently enabled in the Motherboard section of the System page. "
+                "This is needed in order to support more than one virtual processor. "
+                "It will be done automatically if you confirm your changes.");
+        }
+
+        /* VCPU vs VT-x/AMD-V test: */
+        if (m_pSliderCPUCount->value() > 1 && !m_pCheckBoxVirtualization->isChecked())
+        {
+            message.second << tr(
+                "Hardware virtualization is not currently enabled in the Acceleration section of the System page. "
+                "This is needed in order to support more than one virtual processor. "
+                "It will be done automatically if you confirm your changes.");
+        }
+
+        /* CPU execution cap test: */
+        if (m_pSliderCPUExecCap->value() < (int)m_uMedGuestCPUExecCap)
+        {
+            message.second << tr(
+                "The processor execution cap is set to a low value. This may make the machine feel slow to respond.");
+        }
+
+        /* Serialize message: */
+        if (!message.second.isEmpty())
+            messages << message;
+    }
+
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.h

@@ -153 +153 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarning, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     /* Helper: Navigation stuff: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsUSB.cpp

@@ -424 +424 @@
 }
 
-bool UIMachineSettingsUSB::validate(QString &strWarningText, QString&)
-{
-    NOREF(strWarningText);
+bool UIMachineSettingsUSB::validate(QList<UIValidationMessage> &messages)
+{
+    Q_UNUSED(messages);
+
+    /* Pass by default: */
+    bool fPass = true;
 
 #ifdef VBOX_WITH_EXTPACK
@@ -433 +436 @@
     if (mGbUSB->isChecked() && mCbUSB2->isChecked() && (extPack.isNull() || !extPack.GetUsable()))
     {
-        strWarningText = tr("USB 2.0 is currently enabled for this virtual machine. "
-                            "However, this requires the <b>%1</b> to be installed. "
-                            "Please install the Extension Pack from the VirtualBox download site. "
-                            "After this you will be able to re-enable USB 2.0. "
-                            "It will be disabled in the meantime unless you cancel the current settings changes.")
-                            .arg(GUI_ExtPackName);
+        /* Prepare message: */
+        UIValidationMessage message;
+        message.second << tr("USB 2.0 is currently enabled for this virtual machine. "
+                             "However, this requires the <b>%1</b> to be installed. "
+                             "Please install the Extension Pack from the VirtualBox download site. "
+                             "After this you will be able to re-enable USB 2.0. "
+                             "It will be disabled in the meantime unless you cancel the current settings changes.")
+                             .arg(GUI_ExtPackName);
+        /* Serialize message: */
+        if (!message.second.isEmpty())
+            messages << message;
+        /* Show message-center warning: */
         msgCenter().warnAboutUnsupportedUSB2(GUI_ExtPackName, this);
+        /* Disable USB2.0 if enabled: */
         mCbUSB2->setChecked(false);
-        return true;
     }
 #endif /* VBOX_WITH_EXTPACK */
 
-    /* Pass by default: */
-    return true;
+    /* Return result: */
+    return fPass;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsUSB.h

@@ -143 +143 @@
 
     /* API: Validation stuff: */
-    bool validate(QString &strWarningText, QString &strTitle);
+    bool validate(QList<UIValidationMessage> &messages);
 
     void setOrderAfter (QWidget *aWidget);