Changeset 48042 in vbox for trunk/src/VBox

Timestamp:

Aug 24, 2013 12:04:57 PM (11 years ago)

Author:

vboxsync

Message:

Solaris/LogRel: Update comment and some minor cosmetics.

Location:

trunk/src/VBox

Files:

• HostDrivers/Support/solaris/SUPDrv-solaris.c (modified) (1 diff)
• Runtime/r0drv/solaris/RTLogWriteDebugger-r0drv-solaris.c (modified) (2 diffs)

trunk/src/VBox/HostDrivers/Support/solaris/SUPDrv-solaris.c

@@ -1194 +1194 @@
     char        szMsg[512];
 
-    if (!RTThreadPreemptIsEnabled(NIL_RTTHREAD))    /** @todo this will change when preemption hooks are implemented. */
+    /* cmn_err() acquires adaptive mutexes. Not preemption safe, see @bugref{6657}. */
+    if (!RTThreadPreemptIsEnabled(NIL_RTTHREAD))
         return 0;
 

trunk/src/VBox/Runtime/r0drv/solaris/RTLogWriteDebugger-r0drv-solaris.c

@@ -46 +46 @@
     if (pch[cb] != '\0')
         AssertBreakpoint();
-    if (!RTThreadPreemptIsEnabled(NIL_RTTHREAD))    /** @todo this will change when preemptions hook are implemented. */
+
+    /* cmn_err() acquires adaptive mutexes. Not preemption safe, see @bugref{6657}. */
+    if (!RTThreadPreemptIsEnabled(NIL_RTTHREAD))
         return;
+
     if (    !g_frtSolSplSetsEIF
 #if defined(RT_ARCH_AMD64) || defined(RT_ARCH_X86)
@@ -55 +58 @@
 #endif
         )
+    {
         cmn_err(CE_CONT, pch);
+    }
+
     return;
 }