Changeset 48249 in vbox for trunk/src

Timestamp:

Sep 3, 2013 2:16:05 PM (11 years ago)

Author:

vboxsync

Message:

LegacyandAMD64.asm: Sanitize CR4 before loading the intermediate context into CR3 (from host) . This should hopefully fix the occational triple faults on windows 7.

File:

• trunk/src/VBox/VMM/VMMSwitcher/LegacyandAMD64.mac (modified) (3 diffs)

trunk/src/VBox/VMM/VMMSwitcher/LegacyandAMD64.mac

@@ -429 +429 @@
     mov     eax, cr3
     mov     [edx + CPUMCPU.Host.cr3], eax
-    mov     eax, cr4
-    mov     [edx + CPUMCPU.Host.cr4], eax
-%if 0 ; paranoia
-    test    eax, X86_CR4_VMXE
-    jz      .vmxe_fine
-    mov     eax, VERR_VMX_IN_VMX_ROOT_MODE
-    retf
-.vmxe_fine:
-%endif
+    mov     esi, cr4                      ; esi = cr4, we'll modify it further down.
+    mov     [edx + CPUMCPU.Host.cr4], esi
 
     DEBUG32_S_CHAR('c')
@@ -467 +460 @@
 
     ;;
+    ;; Clean up CR4.  X86_CR4_PGE, X86_CR4_PCE, X86_CR4_PCIDE (not really
+    ;; relevant for 32-bit, but whatever) and X86_CR4_VMXE must be cleared.
+    ;;
+    and     esi, X86_CR4_VME | X86_CR4_PVI | X86_CR4_TSD | X86_CR4_DE | X86_CR4_PSE | X86_CR4_PAE \
+               | X86_CR4_MCE | X86_CR4_OSFSXR | X86_CR4_OSXMMEEXCPT | X86_CR4_SMXE | X86_CR4_OSXSAVE
+    mov     cr4, esi
+
+    ;;
     ;; Load Intermediate memory context.
     ;;
@@ -475 +476 @@
 %ifdef VBOX_WITH_64ON32_CMOS_DEBUG
     DEBUG_CMOS_TRASH_AL 17h
-    jmp     .first_jmp
-    times 65 db 90h
-.first_jmp:
-    times 65 db 90h
-.second_jmp:
-    DEBUG_CMOS_TRASH_AL 18h
 %endif