Changeset 48328 in vbox for trunk/src/VBox/HostDrivers

Timestamp:

Sep 5, 2013 10:20:18 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

88756

Message:

VMM: Assert, doxygen, todo question.

File:

• trunk/src/VBox/HostDrivers/Support/SUPDrv.c (modified) (3 diffs)

trunk/src/VBox/HostDrivers/Support/SUPDrv.c

@@ -3371 +3371 @@
  * @returns VBox status code.
  * @retval  VERR_VMX_NO_VMX
- * @retval  VERR_VMX_MSR_LOCKED_OR_DISABLED
+ * @retval  VERR_VMX_MSR_SMX_VMXON_DISABLED
+ * @retval  VERR_VMX_MSR_VMXON_DISABLED
  * @retval  VERR_SVM_NO_SVM
  * @retval  VERR_SVM_DISABLED
@@ -3390 +3391 @@
     *pfCaps = 0;
 
+    /** @todo r=ramshankar: Although we're only reading CPUIDs/MSRs here which
+     *        should be identical on all CPUs on the system, it's probably
+     *        cleaner to prevent migration nonetheless? */
     if (ASMHasCpuId())
     {
@@ -3400 +3404 @@
 
         if (   ASMIsValidStdRange(uMaxId)
-            && (   ASMIsIntelCpuEx(    uVendorEBX, uVendorECX, uVendorEDX)
+            && (   ASMIsIntelCpuEx(     uVendorEBX, uVendorECX, uVendorEDX)
                 || ASMIsViaCentaurCpuEx(uVendorEBX, uVendorECX, uVendorEDX) )
            )