Changeset 48342 in vbox for trunk/src/VBox/Main

Timestamp:

Sep 6, 2013 7:22:36 AM (11 years ago)

Author:

vboxsync

Message:

Main/GuestCtrl: warnings, don't ignore the exit code

Location:

trunk/src/VBox/Main/src-client

Files:

• GuestCtrlImpl.cpp (modified) (1 diff)
• GuestSessionImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/GuestCtrlImpl.cpp

@@ -97 +97 @@
     uint32_t uContextID;
     int rc = pSvcCb->mpaParms[0].getUInt32(&uContextID);
-    AssertMsgRC(rc, ("Unable to extract callback context ID, pvData=%p\n", pSvcCb));
-    if (RT_FAILURE(rc))
-        return rc;
+    AssertMsgRCReturn(rc, ("Unable to extract callback context ID, pvData=%p\n", pSvcCb), rc);
 #ifdef DEBUG
     LogFlowFunc(("CID=%RU32, uSession=%RU32, uObject=%RU32, uCount=%RU32\n",

trunk/src/VBox/Main/src-client/GuestSessionImpl.cpp

@@ -1317 +1317 @@
     CALLBACKDATA_SESSION_NOTIFY dataCb;
     /* pSvcCb->mpaParms[0] always contains the context ID. */
-    pSvcCbData->mpaParms[1].getUInt32(&dataCb.uType);
-    pSvcCbData->mpaParms[2].getUInt32(&dataCb.uResult);
+    int vrc = pSvcCbData->mpaParms[1].getUInt32(&dataCb.uType);
+    AssertRCReturn(vrc, vrc);
+    vrc = pSvcCbData->mpaParms[2].getUInt32(&dataCb.uResult);
+    AssertRCReturn(vrc, vrc);
 
     LogFlowThisFunc(("ID=%RU32, uType=%RU32, guestRc=%Rrc\n",
                      mData.mSession.mID, dataCb.uType, dataCb.uResult));
-
-    int vrc = VINF_SUCCESS;
 
     GuestSessionStatus_T sessionStatus = GuestSessionStatus_Undefined;