Changeset 48462 in vbox for trunk/src/VBox/Runtime

Timestamp:

Sep 12, 2013 10:35:34 PM (11 years ago)

Author:

vboxsync

Message:

r0drv/linux: todos.

File:

• trunk/src/VBox/Runtime/r0drv/linux/thread-r0drv-linux.c (modified) (3 diffs)

trunk/src/VBox/Runtime/r0drv/linux/thread-r0drv-linux.c

@@ -88 +88 @@
     yield();
 #else
+    /** @todo r=ramshankar: Can we use cond_resched() instead?  */
     set_current_state(TASK_RUNNING);
     sys_sched_yield();
@@ -160 +161 @@
 RTDECL(bool) RTThreadPreemptIsPossible(void)
 {
+    /** @todo r=ramshankar: What about CONFIG_PREEMPT_VOLUNTARY? That can preempt
+     *        too but does so in voluntarily in explicit preemption points. */
 #ifdef CONFIG_PREEMPT
     return true;    /* yes, kernel preemption is possible. */
@@ -175 +178 @@
     Assert(pState->u32Reserved == 0);
     pState->u32Reserved = 42;
+    /* This ASSUMES that CONFIG_PREEMPT_COUNT is always defined with CONFIG_PREEMPT. */
     preempt_disable();
     RT_ASSERT_PREEMPT_CPUID_DISABLE(pState);