Changeset 49004 in vbox for trunk/src/VBox/VMM/VMMR0

Timestamp:

Oct 9, 2013 1:41:07 PM (12 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

89732

Message:

VMM/HMVMXR0: Comment update.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -1163 +1163 @@
  *          when NestedPaging is supported and providing @a enmFlush that is
  *          supported by the CPU.
+ * @remarks Can be called with interrupts disabled.
  */
 static void hmR0VmxFlushEpt(PVMCPU pVCpu, VMX_FLUSH_EPT enmFlush)
@@ -1197 +1198 @@
  * @param   GCPtr       Virtual address of the page to flush (can be 0 depending
  *                      on @a enmFlush).
+ *
+ * @remarks Can be called with interrupts disabled.
  */
 static void hmR0VmxFlushVpid(PVM pVM, PVMCPU pVCpu, VMX_FLUSH_VPID enmFlush, RTGCPTR GCPtr)
@@ -5624 +5627 @@
      * -> continue with VM-exit handling -> hmR0VmxSaveGuestControlRegs() and here we are.
      *
+     * The reason for such complicated handling is because VM-exits that call into PGM expect CR3 to be up-to-date and thus
+     * if any CR3-saves -before- the VM-exit (longjmp) postponed the CR3 update via the force-flag, any VM-exit handler that
+     * calls into PGM when it re-saves CR3 will end up here and we call PGMUpdateCR3(). This is why the code below should
+     * -NOT- check if HMVMX_UPDATED_GUEST_CR3 is already set or not!
+     *
      * The longjmp exit path can't check these CR3 force-flags and call code that takes a lock again. We cover for it here.
      */
@@ -6204 +6212 @@
  * @param   fSaveGuestState     Whether to save the guest state or not.
  *
+ * @remarks If you modify code here, make sure to check whether
+ *          hmR0VmxCallRing3Callback() needs to be updated too.
  * @remarks No-long-jmp zone!!!
  */
@@ -6450 +6460 @@
  *                          may be out-of-sync. Make sure to update the required
  *                          fields before using them.
+ * @remarks If you modify code here, make sure to check whether
+ *          hmR0VmxLeave() needs to be updated too.
  */
 DECLCALLBACK(int) hmR0VmxCallRing3Callback(PVMCPU pVCpu, VMMCALLRING3 enmOperation, void *pvUser)