Changeset 49029 in vbox for trunk/src/VBox

Timestamp:

Oct 10, 2013 1:17:09 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

89795

Message:

ovfreader: Don't check for xsi:type, just look for type. Dropped a bunch of unnecesary parenthese. Changed throw(xxx) with RT_THROW(xxx) on method declarations and definitions MSVC has been complaining about this for years.

Location:

trunk/src/VBox/Main

Files:

• include/ovfreader.h (modified) (7 diffs)
• xml/ovfreader.cpp (modified) (17 diffs)

trunk/src/VBox/Main/include/ovfreader.h

@@ -38 +38 @@
  * that one catch() for all xml::LogicError can handle all possible errors.
  */
-
 class OVFLogicError : public xml::LogicError
 {
@@ -44 +43 @@
     OVFLogicError(const char *aFormat, ...);
 };
+
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -371 +371 @@
     }
 
-    void checkConsistencyAndCompliance() throw (OVFLogicError)
+    void checkConsistencyAndCompliance() RT_THROW(OVFLogicError)
     {
         _checkConsistencyAndCompliance();
@@ -377 +377 @@
 
 protected:
-    virtual void _checkConsistencyAndCompliance() throw (OVFLogicError);
+    virtual void _checkConsistencyAndCompliance() RT_THROW(OVFLogicError);
     virtual const RTCString& getItemName()
     {
@@ -428 +428 @@
 
 protected:
-    virtual void _checkConsistencyAndCompliance() throw (OVFLogicError);
+    virtual void _checkConsistencyAndCompliance() RT_THROW(OVFLogicError);
 private:
     RTCString itemName;
@@ -474 +474 @@
 
 protected:
-    virtual void _checkConsistencyAndCompliance() throw (OVFLogicError);
+    virtual void _checkConsistencyAndCompliance() RT_THROW(OVFLogicError);
 private:
     RTCString itemName;
@@ -632 +632 @@
 </code>
  */
-
 class OVFReader
 {

trunk/src/VBox/Main/xml/ovfreader.cpp

@@ -133 +133 @@
     {
         const char *pcszElemName = pElem->getName();
-        const char *pcszTypeAttr = "";
-        const xml::AttributeNode *pTypeAttr;
-        if (    (pTypeAttr = pElem->findAttribute("type", "xsi")) != NULL
-             || (pTypeAttr = pElem->findAttribute("type")) != NULL
-           )
-            pcszTypeAttr = pTypeAttr->getValue();
-
-        if (    (!strcmp(pcszElemName, "DiskSection"))
-             || (    (!strcmp(pcszElemName, "Section"))
-                  && (!strcmp(pcszTypeAttr, "ovf:DiskSection_Type"))
+        const xml::AttributeNode *pTypeAttr = pElem->findAttribute("type");
+        const char *pcszTypeAttr = pTypeAttr ? pTypeAttr->getValue() : "";
+
+        if (    !strcmp(pcszElemName, "DiskSection")
+             || (    !strcmp(pcszElemName, "Section")
+                  && !strcmp(pcszTypeAttr, "ovf:DiskSection_Type")
                 )
            )
@@ -148 +144 @@
             HandleDiskSection(pReferencesElem, pElem);
         }
-        else if (    (!strcmp(pcszElemName, "NetworkSection"))
-                  || (    (!strcmp(pcszElemName, "Section"))
-                       && (!strcmp(pcszTypeAttr, "ovf:NetworkSection_Type"))
+        else if (    !strcmp(pcszElemName, "NetworkSection")
+                  || (    !strcmp(pcszElemName, "Section")
+                       && !strcmp(pcszTypeAttr, "ovf:NetworkSection_Type")
                      )
                 )
@@ -156 +152 @@
             HandleNetworkSection(pElem);
         }
-        else if (    (!strcmp(pcszElemName, "DeploymentOptionSection")))
+        else if (    !strcmp(pcszElemName, "DeploymentOptionSection"))
         {
             // TODO
         }
-        else if (    (!strcmp(pcszElemName, "Info")))
+        else if (    !strcmp(pcszElemName, "Info"))
         {
             // child of VirtualSystemCollection -- TODO
         }
-        else if (    (!strcmp(pcszElemName, "ResourceAllocationSection")))
+        else if (    !strcmp(pcszElemName, "ResourceAllocationSection"))
         {
             // child of VirtualSystemCollection -- TODO
         }
-        else if (    (!strcmp(pcszElemName, "StartupSection")))
+        else if (    !strcmp(pcszElemName, "StartupSection"))
         {
             // child of VirtualSystemCollection -- TODO
         }
-        else if (    (!strcmp(pcszElemName, "VirtualSystem"))
-                  || (    (!strcmp(pcszElemName, "Content"))
-                       && (!strcmp(pcszTypeAttr, "ovf:VirtualSystem_Type"))
+        else if (    !strcmp(pcszElemName, "VirtualSystem")
+                  || (    !strcmp(pcszElemName, "Content")
+                       && !strcmp(pcszTypeAttr, "ovf:VirtualSystem_Type")
                      )
                 )
@@ -180 +176 @@
             HandleVirtualSystemContent(pElem);
         }
-        else if (    (!strcmp(pcszElemName, "VirtualSystemCollection"))
-                  || (    (!strcmp(pcszElemName, "Content"))
-                       && (!strcmp(pcszTypeAttr, "ovf:VirtualSystemCollection_Type"))
+        else if (    !strcmp(pcszElemName, "VirtualSystemCollection")
+                  || (    !strcmp(pcszElemName, "Content")
+                       && !strcmp(pcszTypeAttr, "ovf:VirtualSystemCollection_Type")
                      )
                 )
@@ -215 +211 @@
         const char *pcszDiskId;
         const char *pcszFormat;
-        if (!(pelmDisk->getAttributeValue("diskId", pcszDiskId)))
+        if (!pelmDisk->getAttributeValue("diskId", pcszDiskId))
             pcszBad = "diskId";
-        else if (!(pelmDisk->getAttributeValue("format", pcszFormat)))
+        else if (!pelmDisk->getAttributeValue("format", pcszFormat))
             pcszBad = "format";
-        else if (!(pelmDisk->getAttributeValue("capacity", d.iCapacity)))
+        else if (!pelmDisk->getAttributeValue("capacity", d.iCapacity))
             pcszBad = "capacity";
         else
@@ -226 +222 @@
             d.strFormat = pcszFormat;
 
-            if (!(pelmDisk->getAttributeValue("populatedSize", d.iPopulatedSize)))
+            if (!pelmDisk->getAttributeValue("populatedSize", d.iPopulatedSize))
                 // optional
                 d.iPopulatedSize = -1;
@@ -239 +235 @@
                 const xml::ElementNode *pFileElem;
                 if (    pReferencesElem
-                     && ((pFileElem = pReferencesElem->findChildElementFromId(pcszFileRef)))
+                     && (pFileElem = pReferencesElem->findChildElementFromId(pcszFileRef)) != NULL
                    )
                 {
@@ -246 +242 @@
                     const char *pcszBadInFile = NULL;
                     const char *pcszHref;
-                    if (!(pFileElem->getAttributeValue("href", pcszHref)))
+                    if (!pFileElem->getAttributeValue("href", pcszHref))
                         pcszBadInFile = "href";
-                    else if (!(pFileElem->getAttributeValue("size", d.iSize)))
+                    else if (!pFileElem->getAttributeValue("size", d.iSize))
                         d.iSize = -1;       // optional
 
@@ -350 +346 @@
         if (!strcmp(pcszElemName, "Section"))       // OVF 0.9 used "Section" element always with a varying "type" attribute
         {
-            const xml::AttributeNode *pTypeAttr;
-            if (    (pTypeAttr = pelmThis->findAttribute("type")) != NULL
-                 || (pTypeAttr = pelmThis->findAttribute("type", "xsi")) != NULL
-               )
+            const xml::AttributeNode *pTypeAttr = pelmThis->findAttribute("type");
+            if (!pTypeAttr)
                 pcszTypeAttr = pTypeAttr->getValue();
             else
@@ -361 +355 @@
         }
 
-        if (    (!strcmp(pcszElemName, "EulaSection"))
-             || (!strcmp(pcszTypeAttr, "ovf:EulaSection_Type"))
+        if (    !strcmp(pcszElemName, "EulaSection")
+             || !strcmp(pcszTypeAttr, "ovf:EulaSection_Type")
            )
         {
@@ -374 +368 @@
                 vsys.strLicenseText = pelmLicense->getValue();
         }
-        if (    (!strcmp(pcszElemName, "ProductSection"))
-             || (!strcmp(pcszTypeAttr, "ovf:ProductSection_Type"))
+        if (    !strcmp(pcszElemName, "ProductSection")
+             || !strcmp(pcszTypeAttr, "ovf:ProductSection_Type")
            )
         {
@@ -402 +396 @@
                 vsys.strVendorUrl = pelmVendorUrl->getValue();
         }
-        else if (    (!strcmp(pcszElemName, "VirtualHardwareSection"))
-                  || (!strcmp(pcszTypeAttr, "ovf:VirtualHardwareSection_Type"))
+        else if (    !strcmp(pcszElemName, "VirtualHardwareSection")
+                  || !strcmp(pcszTypeAttr, "ovf:VirtualHardwareSection_Type")
                 )
         {
@@ -526 +520 @@
 
                     case ResourceType_Memory:        // 4
-                        if (    (i.strAllocationUnits == "MegaBytes")           // found in OVF created by OVF toolkit
-                             || (i.strAllocationUnits == "MB")                  // found in MS docs
-                             || (i.strAllocationUnits == "byte * 2^20")         // suggested by OVF spec DSP0243 page 21
+                        if (    i.strAllocationUnits == "MegaBytes"           // found in OVF created by OVF toolkit
+                             || i.strAllocationUnits == "MB"                  // found in MS docs
+                             || i.strAllocationUnits == "byte * 2^20"         // suggested by OVF spec DSP0243 page 21
                            )
                             vsys.ullMemorySize = i.ullVirtualQuantity * _1M;
@@ -797 +791 @@
             }
         }
-        else if (    (!strcmp(pcszElemName, "OperatingSystemSection"))
-                  || (!strcmp(pcszTypeAttr, "ovf:OperatingSystemSection_Type"))
+        else if (    !strcmp(pcszElemName, "OperatingSystemSection")
+                  || !strcmp(pcszTypeAttr, "ovf:OperatingSystemSection_Type")
                 )
         {
@@ -908 +902 @@
 }
 
-void VirtualHardwareItem::_checkConsistencyAndCompliance() throw (OVFLogicError)
+void VirtualHardwareItem::_checkConsistencyAndCompliance() RT_THROW(OVFLogicError)
 {
     RTCString name = getItemName();
@@ -987 +981 @@
 
 
-void StorageItem::_checkConsistencyAndCompliance() throw (OVFLogicError)
+void StorageItem::_checkConsistencyAndCompliance() RT_THROW(OVFLogicError)
 {
     VirtualHardwareItem::_checkConsistencyAndCompliance();
@@ -1044 +1038 @@
 }
 
-void EthernetPortItem::_checkConsistencyAndCompliance() throw (OVFLogicError)
+void EthernetPortItem::_checkConsistencyAndCompliance() RT_THROW(OVFLogicError)
 {
     VirtualHardwareItem::_checkConsistencyAndCompliance();