Changeset 49078 in vbox for trunk/src

Timestamp:

Oct 14, 2013 2:28:52 AM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

89885

Message:

dir-win.cpp/RTDirCreate: Aaaaaaaaaaaaaaaaarg!!!!!!!!!!

File:

• trunk/src/VBox/Runtime/r3/win/dir-win.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/win/dir-win.cpp

@@ -73 +73 @@
              * Turn off indexing of directory through Windows Indexing Service
              */
-            if (RT_SUCCESS(rc))
+            /** @todo This FILE_ATTRIBUTE_NOT_CONTENT_INDEXED hack (for .VDI files,
+             *        really) may cause failures on samba shares.  That really sweet and
+             *        need to be addressed differently.  We shouldn't be doing this
+             *        unless the caller actually asks for it, must less returning failure,
+             *        for crying out loud!  This is only important a couple of places in
+             *        main, if important is the right way to put it... */
+            if (   RT_SUCCESS(rc)
+                && !(fCreate & RTDIRCREATE_FLAGS_NOT_CONTENT_INDEXED_DONT_SET))
             {
-                if (SetFileAttributesW((LPCWSTR)pwszString, FILE_ATTRIBUTE_NOT_CONTENT_INDEXED))
+                if (   SetFileAttributesW((LPCWSTR)pwszString, FILE_ATTRIBUTE_NOT_CONTENT_INDEXED)
+                    || (fCreate & RTDIRCREATE_FLAGS_NOT_CONTENT_INDEXED_NOT_CRITICAL) )
                     rc = VINF_SUCCESS;
                 else