Changeset 49131 in vbox for trunk/src/VBox

Timestamp:

Oct 16, 2013 12:03:12 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

89984

Message:

Main/NATNetworkImpl.cpp: update comment in NATNetwork::COMSETTER(Network)(IN_BSTR) and NATNetwork::COMSETTER(IPv6Prefix) (IN_BSTR) about ignoring new value if there're registered port-forwarding rules. in TODO part of the comment how to resolve the conflict with different internal representation (guest address should be offset from network id, insted direct address, albeit additional check against network bounds should be added then).

File:

• trunk/src/VBox/Main/src-server/NATNetworkImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/NATNetworkImpl.cpp

@@ -373 +373 @@
         return S_OK;
         
-    /* silently ignore network cidr update */
+    /* silently ignore network cidr update for now. 
+     * todo: keep internally guest address of port forward rule 
+     * as offset from network id.
+     */
     if (m->mapName2PortForwardRule4.empty())
     {
@@ -445 +448 @@
         return S_OK;
 
-    /* silently ignore network cidr update */
+    /* silently ignore network IPv6 prefix update. 
+     * todo: see similar todo in NATNetwork::COMSETTER(Network)(IN_BSTR)
+     */
     if (m->mapName2PortForwardRule6.empty())
     {