Changeset 49159 in vbox for trunk/src/VBox/VMM/VMMR0

Timestamp:

Oct 17, 2013 9:16:43 AM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

90022

Message:

VMM/HMSVMR0: Comment nits.

File:

• trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp (modified) (15 diffs)

trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp

@@ -1056 +1056 @@
  * the corresponding VMCB Clean Bit.
  *
- * @param   pVmcb       Pointer to the VMCB.
+ * @param   pVmcb       Pointer to the VM control block.
  * @param   u32Xcpt     The value of the exception (X86_XCPT_*).
  */
@@ -1073 +1073 @@
  * updates the corresponding VMCB Clean Bit.
  *
- * @param   pVmcb       Pointer to the VMCB.
+ * @param   pVmcb       Pointer to the VM control block.
  * @param   u32Xcpt     The value of the exception (X86_XCPT_*).
  */
@@ -1095 +1095 @@
  * @returns VBox status code.
  * @param   pVM         Pointer to the VMCPU.
- * @param   pVmcb       Pointer to the VMCB.
+ * @param   pVmcb       Pointer to the VM control block.
  * @param   pCtx        Pointer to the guest-CPU context.
  *
@@ -1169 +1169 @@
  * @returns VBox status code.
  * @param   pVCpu       Pointer to the VMCPU.
- * @param   pVmcb       Pointer to the VMCB.
+ * @param   pVmcb       Pointer to the VM control block.
  * @param   pCtx        Pointer to the guest-CPU context.
  *
@@ -1269 +1269 @@
  * @returns VBox status code.
  * @param   pVCpu       Pointer to the VMCPU.
- * @param   pVmcb       Pointer to the VMCB.
+ * @param   pVmcb       Pointer to the VM control block.
  * @param   pCtx        Pointer to the guest-CPU context.
  *
@@ -1328 +1328 @@
  *
  * @param   pVCpu       Pointer to the VMCPU.
- * @param   pVmcb       Pointer to the VMCB.
+ * @param   pVmcb       Pointer to the VM control block.
  * @param   pCtx        Pointer to the guest-CPU context.
  *
@@ -1384 +1384 @@
  *
  * @param   pVCpu       Pointer to the VMCPU.
- * @param   pVmcb       Pointer to the VMCB.
+ * @param   pVmcb       Pointer to the VM control block.
  * @param   pCtx        Pointer to the guest-CPU context.
  *
@@ -1550 +1550 @@
  *
  * @returns VBox status code.
- * @param   pVCpu   Pointer to the VMCPU.
- * @param   pVmcb   Pointer to the VMCB.
- * @param   pCtx    Pointer to the guest-CPU context.
+ * @param   pVCpu       Pointer to the VMCPU.
+ * @param   pVmcb       Pointer to the VM control block.
+ * @param   pCtx        Pointer to the guest-CPU context.
  */
 static int hmR0SvmLoadGuestApicState(PVMCPU pVCpu, PSVMVMCB pVmcb, PCPUMCTX pCtx)
@@ -1818 +1818 @@
  *
  * @param   pVCpu       Pointer to the VMCPU.
- * @param   pVmcb       Pointer to the VMCB.
+ * @param   pVmcb       Pointer to the VM control block.
  * @param   pCtx        Pointer to the guest-CPU context.
  *
@@ -2242 +2242 @@
  *
  * @param   pVCpu       Pointer to the VMCPU.
- * @param   pVmcb       Pointer to the guest VMCB.
+ * @param   pVmcb       Pointer to the guest VM control block.
  * @param   pCtx        Pointer to the guest-CPU context.
  * @param   pEvent      Pointer to the event.
@@ -2428 +2428 @@
  * receive interrupts.
  *
- * @param pVmcb         Pointer to the VMCB.
+ * @param pVmcb         Pointer to the VM control block.
  */
 DECLINLINE(void) hmR0SvmSetVirtIntrIntercept(PSVMVMCB pVmcb)
@@ -3110 +3110 @@
             break;
 
+        /*
+         * No longjmps to ring-3 from this point on!!!
+         * Asserts() will still longjmp to ring-3 (but won't return), which is intentional, better than a kernel panic.
+         * This also disables flushing of the R0-logger instance (if any).
+         */
         hmR0SvmPreRunGuestCommitted(pVM, pVCpu, pCtx, &SvmTransient);
         rc = hmR0SvmRunGuest(pVM, pVCpu, pCtx);
@@ -3154 +3159 @@
  * @param   pVCpu       Pointer to the VMCPU.
  * @param   pCtx        Pointer to the guest-CPU context.
- * @param   pVmcb       The VM control block.
+ * @param   pVmcb       Pointer to the VM control block.
  */
 static int hmR0SvmRunGuestCodeStep(PVM pVM, PVMCPU pVCpu, PCPUMCTX pCtx, PSVMVMCB pVmcb)
@@ -3172 +3177 @@
                   (unsigned)RTMpCpuId(), cLoops));
 
-        /* Preparatory work for running guest code, this may return to ring-3 for some last minute updates. */
+        /* Preparatory work for running guest code, this may force us to return
+           to ring-3.  This bugger disables interrupts on VINF_SUCCESS! */
         STAM_PROFILE_ADV_START(&pVCpu->hm.s.StatEntry, x);
         rc = hmR0SvmPreRunGuest(pVM, pVCpu, pCtx, &SvmTransient);
@@ -3232 +3238 @@
 
     /*
-     * Clear the X86_EFL_TF if necessary .
+     * Clear the X86_EFL_TF if necessary.
      */
     if (pVCpu->hm.s.fClearTrapFlag)