Changeset 49423 in vbox for trunk/src/VBox

Timestamp:

Nov 8, 2013 4:25:35 PM (11 years ago)

Author:

vboxsync

Message:

Do not block input on keyboard queue level when VM is paused.

File:

• trunk/src/VBox/Devices/Input/DrvKeyboardQueue.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Input/DrvKeyboardQueue.cpp

@@ -52 +52 @@
     /** The queue handle. */
     PPDMQUEUE                   pQueue;
-    /** Discard input when this flag is set.
-     * We only accept input when the VM is running. */
+    /** Discard input when this flag is set. */
     bool                        fInactive;
+    /** When VM is suspended, queue full errors are not fatal. */
+    bool                        fSuspended;
 } DRVKBDQUEUE, *PDRVKBDQUEUE;
 
@@ -106 +107 @@
 {
     PDRVKBDQUEUE pDrv = IKEYBOARDPORT_2_DRVKBDQUEUE(pInterface);
+    /* Ignore any attempt to send events if queue is inactive. */
     if (pDrv->fInactive)
         return VINF_SUCCESS;
@@ -116 +118 @@
         return VINF_SUCCESS;
     }
-    AssertMsgFailed(("drvKbdQueuePutEvent: Queue is full!!!!\n"));
+    if (!pDrv->fSuspended)
+        AssertMsgFailed(("drvKbdQueuePutEvent: Queue is full!!!!\n"));
     return VERR_PDM_NO_QUEUE_ITEMS;
 }
@@ -209 +212 @@
 {
     PDRVKBDQUEUE        pThis = PDMINS_2_DATA(pDrvIns, PDRVKBDQUEUE);
-    pThis->fInactive = true;
+    pThis->fSuspended = true;
 }
 
@@ -222 +225 @@
 {
     PDRVKBDQUEUE        pThis = PDMINS_2_DATA(pDrvIns, PDRVKBDQUEUE);
-    pThis->fInactive = false;
+    pThis->fSuspended = false;
 }
 
@@ -259 +262 @@
      */
     pDrv->fInactive                         = true;
+    pDrv->fSuspended                        = false;
     /* IBase. */
     pDrvIns->IBase.pfnQueryInterface        = drvKbdQueueQueryInterface;