Changeset 49725 in vbox

Timestamp:

Nov 29, 2013 2:03:10 PM (11 years ago)

Author:

vboxsync

Message:

VMM/HM: Use unordered ASM atomics for safely updating HM flags.

Location:

trunk

Files:

• include/VBox/vmm/hm.h (modified) (1 diff)
• src/VBox/VMM/include/HMInternal.h (modified) (2 diffs)

trunk/include/VBox/vmm/hm.h

@@ -38 +38 @@
 
 RT_C_DECLS_BEGIN
-
-/** @def VMCPU_HMCF_CLEAR
- * Clears a HM-context flag for the given VCPU.
- *
- * @param   pVCpu   Pointer to the VMCPU.
- * @param   fFlag   The flag to clear.
- */
-#define VMCPU_HMCF_CLEAR(pVCpu, fFlag)              ((pVCpu)->hm.s.fContextUseFlags &= ~(fFlag))
-
-/** @def VMCPU_FF_SET
- * Sets a HM-context flag for the given VCPU.
- *
- * @param   pVCpu   Pointer to the VMCPU.
- * @param   fFlag   The flag to set.
- */
-#define VMCPU_HMCF_SET(pVCpu, fFlag)                ((pVCpu)->hm.s.fContextUseFlags |= (fFlag))
-
-/** @def VMCPU_HMCF_IS_SET
- * Checks if all the flags in the specified HM-context set is pending.
- *
- * @param   pVCpu   Pointer to the VMCPU.
- * @param   fFlag   The flag to check.
- */
-#define VMCPU_HMCF_IS_SET(pVCpu, fFlag)             (((pVCpu)->hm.s.fContextUseFlags & (fFlag)) == (fFlag))
-
-/** @def VMCPU_HMCF_IS_PENDING
- * Checks if one or more of the flags in the specified HM-context set is
- * pending.
- *
- * @param   pVCpu   Pointer to the VMCPU.
- * @param   fFlags  The flags to check for.
- */
-#define VMCPU_HMCF_IS_PENDING(pVCpu, fFlags)        RT_BOOL((pVCpu)->hm.s.fContextUseFlags & (fFlags))
-
-/** @def VMCPU_HMCF_IS_PENDING_ONLY
- * Checks if -only- one or more of the specified HM-context flags is pending.
- *
- * @param   pVCpu   Pointer to the VMCPU.
- * @param   fFlags  The flags to check for.
- */
-#define VMCPU_HMCF_IS_PENDING_ONLY(pVCpu, fFlags)   !RT_BOOL((pVCpu)->hm.s.fContextUseFlags & ~(fFlags))
-
-/** @def VMCPU_HMCF_IS_SET_ONLY
- * Checks if -only- all the flags in the specified HM-context set is pending.
- *
- * @param   pVCpu   Pointer to the VMCPU.
- * @param   fFlags  The flags to check for.
- */
-#define VMCPU_HMCF_IS_SET_ONLY(pVCpu, fFlags)       ((pVCpu)->hm.s.fContextUseFlags == (fFlags))
-
-/** @def VMCPU_HMCF_RESET_TO
- * Resets the HM-context flags to the specified value.
- *
- * @param   pVCpu   Pointer to the VMCPU.
- * @param   fFlags  The new value.
- */
-#define VMCPU_HMCF_RESET_TO(pVCpu, fFlags)          ((pVCpu)->hm.s.fContextUseFlags = (fFlags))
-
-/** @def VMCPU_HMCF_VALUE
- * Returns the current HM-context flags value.
- *
- * @param   pVCpu   Pointer to the VMCPU.
- */
-#define VMCPU_HMCF_VALUE(pVCpu)                     ((pVCpu)->hm.s.fContextUseFlags)
-
 
 /**

trunk/src/VBox/VMM/include/HMInternal.h

@@ -56 +56 @@
  * @{
  */
+
+/** @def VMCPU_HMCF_CLEAR
+ * Clears a HM-context flag for the given VCPU.
+ *
+ * @param   pVCpu   Pointer to the VMCPU.
+ * @param   fFlag   The flag to clear.
+ */
+#define VMCPU_HMCF_CLEAR(pVCpu, fFlag)              (ASMAtomicUoAndU32(&(pVCpu)->hm.s.fContextUseFlags, ~(fFlag)))
+
+/** @def VMCPU_FF_SET
+ * Sets a HM-context flag for the given VCPU.
+ *
+ * @param   pVCpu   Pointer to the VMCPU.
+ * @param   fFlag   The flag to set.
+ */
+#define VMCPU_HMCF_SET(pVCpu, fFlag)                (ASMAtomicUoOrU32(&(pVCpu)->hm.s.fContextUseFlags, (fFlag)))
+
+/** @def VMCPU_HMCF_IS_SET
+ * Checks if all the flags in the specified HM-context set is pending.
+ *
+ * @param   pVCpu   Pointer to the VMCPU.
+ * @param   fFlag   The flag to check.
+ */
+#define VMCPU_HMCF_IS_SET(pVCpu, fFlag)             ((ASMAtomicUoReadU32(&(pVCpu)->hm.s.fContextUseFlags) & (fFlag)) == (fFlag))
+
+/** @def VMCPU_HMCF_IS_PENDING
+ * Checks if one or more of the flags in the specified HM-context set is
+ * pending.
+ *
+ * @param   pVCpu   Pointer to the VMCPU.
+ * @param   fFlags  The flags to check for.
+ */
+#define VMCPU_HMCF_IS_PENDING(pVCpu, fFlags)        RT_BOOL(ASMAtomicUoReadU32(&(pVCpu)->hm.s.fContextUseFlags) & (fFlags))
+
+/** @def VMCPU_HMCF_IS_PENDING_ONLY
+ * Checks if -only- one or more of the specified HM-context flags is pending.
+ *
+ * @param   pVCpu   Pointer to the VMCPU.
+ * @param   fFlags  The flags to check for.
+ */
+#define VMCPU_HMCF_IS_PENDING_ONLY(pVCpu, fFlags)   !RT_BOOL(ASMAtomicUoReadU32(&(pVCpu)->hm.s.fContextUseFlags) & ~(fFlags))
+
+/** @def VMCPU_HMCF_IS_SET_ONLY
+ * Checks if -only- all the flags in the specified HM-context set is pending.
+ *
+ * @param   pVCpu   Pointer to the VMCPU.
+ * @param   fFlags  The flags to check for.
+ */
+#define VMCPU_HMCF_IS_SET_ONLY(pVCpu, fFlags)       (ASMAtomicUoReadU32(&(pVCpu)->hm.s.fContextUseFlags) == (fFlags))
+
+/** @def VMCPU_HMCF_RESET_TO
+ * Resets the HM-context flags to the specified value.
+ *
+ * @param   pVCpu   Pointer to the VMCPU.
+ * @param   fFlags  The new value.
+ */
+#define VMCPU_HMCF_RESET_TO(pVCpu, fFlags)          (ASMAtomicUoWriteU32(&(pVCpu)->hm.s.fContextUseFlags, (fFlags)))
+
+/** @def VMCPU_HMCF_VALUE
+ * Returns the current HM-context flags value.
+ *
+ * @param   pVCpu   Pointer to the VMCPU.
+ */
+#define VMCPU_HMCF_VALUE(pVCpu)                     (ASMAtomicUoReadU32(&(pVCpu)->hm.s.fContextUseFlags))
 
 
@@ -513 +577 @@
     volatile uint32_t           cWorldSwitchExits;
     /** HM_CHANGED_* flags. */
-    uint32_t                    fContextUseFlags;
+    volatile uint32_t           fContextUseFlags;
     /** Id of the last cpu we were executing code on (NIL_RTCPUID for the first
      *  time). */