Changeset 49950 in vbox for trunk/src/VBox/Additions

Timestamp:

Dec 17, 2013 10:51:16 AM (11 years ago)

Author:

vboxsync

Message:

Additions/common: !RT_SUCCESS => RT_FAILURE

Location:

trunk/src/VBox/Additions/common

Files:

• VBoxControl/VBoxControl.cpp (modified) (8 diffs)
• VBoxGuest/VBoxGuest.cpp (modified) (1 diff)
• VBoxGuestLib/VBoxGuestR3LibGuestProp.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/VBoxControl/VBoxControl.cpp

@@ -1177 +1177 @@
 
     rc = VbglR3GuestPropConnect(&u32ClientId);
-    if (!RT_SUCCESS(rc))
+    if (RT_FAILURE(rc))
         VBoxControlError("Failed to connect to the guest property service, error %Rrc\n", rc);
 
@@ -1221 +1221 @@
         if (VERR_TOO_MUCH_DATA == rc)
             VBoxControlError("Temporarily unable to retrieve the property\n");
-        else if (!RT_SUCCESS(rc) && (rc != VERR_NOT_FOUND))
+        else if (RT_FAILURE(rc) && rc != VERR_NOT_FOUND)
             VBoxControlError("Failed to retrieve the property value, error %Rrc\n", rc);
     }
@@ -1294 +1294 @@
     int rc = VINF_SUCCESS;
     rc = VbglR3GuestPropConnect(&u32ClientId);
-    if (!RT_SUCCESS(rc))
+    if (RT_FAILURE(rc))
         VBoxControlError("Failed to connect to the guest property service, error %Rrc\n", rc);
-    if (RT_SUCCESS(rc))
+    else
     {
         if (pszFlags != NULL)
@@ -1302 +1302 @@
         else
             rc = VbglR3GuestPropWriteValue(u32ClientId, pszName, pszValue);
-        if (!RT_SUCCESS(rc))
+        if (RT_FAILURE(rc))
             VBoxControlError("Failed to store the property value, error %Rrc\n", rc);
     }
@@ -1342 +1342 @@
     uint32_t u32ClientId = 0;
     int rc = VbglR3GuestPropConnect(&u32ClientId);
-    if (!RT_SUCCESS(rc))
+    if (RT_FAILURE(rc))
         VBoxControlError("Failed to connect to the guest property service, error %Rrc\n", rc);
-    if (RT_SUCCESS(rc))
+    else
     {
         rc = VbglR3GuestPropDelete(u32ClientId, pszName);
-        if (!RT_SUCCESS(rc))
+        if (RT_FAILURE(rc))
             VBoxControlError("Failed to delete the property value, error %Rrc\n", rc);
     }
@@ -1485 +1485 @@
 
     rc = VbglR3GuestPropConnect(&u32ClientId);
-    if (!RT_SUCCESS(rc))
+    if (RT_FAILURE(rc))
         VBoxControlError("Failed to connect to the guest property service, error %Rrc\n", rc);
 
@@ -1532 +1532 @@
             VBoxControlError("The request timed out or was interrupted\n");
 #ifndef RT_OS_WINDOWS  /* Windows guests do not do this right */
-        else if (!RT_SUCCESS(rc) && (rc != VERR_NOT_FOUND))
+        else if (RT_FAILURE(rc) && rc != VERR_NOT_FOUND)
             VBoxControlError("Failed to get a notification, error %Rrc\n", rc);
 #endif
@@ -1616 +1616 @@
     uint32_t u32ClientId;
     int rc = VbglR3SharedFolderConnect(&u32ClientId);
-    if (!RT_SUCCESS(rc))
+    if (RT_FAILURE(rc))
         VBoxControlError("Failed to connect to the shared folder service, error %Rrc\n", rc);
     else

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest.cpp

@@ -2646 +2646 @@
 
     int rc = VBoxGuestSetGuestCapabilities(fSessionOrCaps, fSessionNotCaps);
-    if (!RT_FAILURE(rc))
+    if (RT_FAILURE(rc))
     {
         LogRel(("VBoxGuestCommonGuestCapsAcquire: VBoxGuestSetGuestCapabilities failed, rc=%Rrc\n", rc));

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibGuestProp.cpp

@@ -559 +559 @@
     {
         int rc2 = VbglHGCMParmUInt32Get(&Msg.size, pcbBufActual);
-        if (!RT_SUCCESS(rc2))
+        if (RT_FAILURE(rc2))
             rc = rc2;
     }
@@ -842 +842 @@
     {
         rc = VbglR3GuestPropWriteValue(u32ClientId, pszName, NULL);
-        if (!RT_SUCCESS(rc))
+        if (RT_FAILURE(rc))
             break;