Changeset 50015 in vbox for trunk/src/VBox/Devices

Timestamp:

Dec 31, 2013 2:57:28 AM (11 years ago)

Author:

vboxsync

Message:

NAT/ip_icmp.c: icmp_error: addss assert statements of correct calculations.

File:

• trunk/src/VBox/Devices/Network/slirp/ip_icmp.c (modified) (2 diffs)

trunk/src/VBox/Devices/Network/slirp/ip_icmp.c

@@ -725 +725 @@
     m->m_data -= shlen + RT_OFFSETOF(struct icmp, icmp_ip); /* _m_: shifts m_data to the start of ICMP header */
     m->m_len += s_ip_len + shlen + RT_OFFSETOF(struct icmp, icmp_ip); /* _m_: m_len counts bytes in IP payload */
-    
+
+    /**
+     * It asserts if calculation above is wrong. 
+     */
+    Assert(icp == mtod(m, struct icmp*));
+
     icp->icmp_cksum = 0;
     icp->icmp_cksum = cksum(m, m->m_len);
@@ -743 +748 @@
     m->m_data -= hlen;
     m->m_len  += hlen;
+    
+    /**
+     * paranoid. if something goes wrong previous assert should be triggered.
+     */
+    Assert(ip == mtod(m, struct ip*));
     (void) ip_output0(pData, (struct socket *)NULL, m, 1);