Changeset 50051 in vbox for trunk/src/VBox/Additions

Timestamp:

Jan 10, 2014 1:23:37 PM (11 years ago)

Author:

vboxsync

Message:

VBoxService/GuestCtrl: Print some more help in case a guest session is unable to start. This most likely is the case when the specified guest user can't create/write the log file into the desired directory.

Location:

trunk/src/VBox/Additions/common/VBoxService

Files:

• VBoxService.cpp (modified) (7 diffs)
• VBoxServiceControlSession.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxService.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2007-2012 Oracle Corporation
+ * Copyright (C) 2007-2014 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -42 +42 @@
 #include <iprt/buildconfig.h>
 #include <iprt/initterm.h>
+#include <iprt/file.h>
 #ifdef DEBUG
 # include <iprt/memtracker.h>
@@ -231 +232 @@
     char szError[RTPATH_MAX + 128] = "";
     int rc = RTLogCreateEx(&g_pLoggerRelease, fFlags, "all",
-                           "VBOXSERVICE_RELEASE_LOG", RT_ELEMENTS(s_apszGroups), s_apszGroups,
+#ifdef DEBUG
+                           "VBOXSERVICE_LOG",
+#else
+                           "VBOXSERVICE_RELEASE_LOG",
+#endif
+                           RT_ELEMENTS(s_apszGroups), s_apszGroups,
                            RTLOGDEST_STDOUT,
                            VBoxServiceLogHeaderFooter, g_cHistory, g_uHistoryFileSize, g_uHistoryFileTime,
@@ -754 +760 @@
 {
     RTEXITCODE rcExit;
-    bool fUserSession = false;
 
     /*
@@ -779 +784 @@
 #endif
 
+    bool fUserSession = false;
 #ifdef VBOX_WITH_GUEST_CONTROL
     /*
@@ -796 +802 @@
      */
     if (fUserSession)
-    {
-        VBoxServiceVerbose(2, "Calling VbgR3InitUser()\n");
         rc = VbglR3InitUser();
-    }
     else
-    {
-        VBoxServiceVerbose(2, "Calling VbgR3Init()\n");
         rc = VbglR3Init();
-    }
+
     if (RT_FAILURE(rc))
     {
         if (rc == VERR_ACCESS_DENIED)
             return RTMsgErrorExit(RTEXITCODE_FAILURE, "Insufficient privileges to start %s! Please start with Administrator/root privileges!\n",
-                                    g_pszProgName);
+                                  g_pszProgName);
         return RTMsgErrorExit(RTEXITCODE_FAILURE, "VbglR3Init failed with rc=%Rrc\n", rc);
     }
@@ -997 +998 @@
     rc = VBoxServiceLogCreate(strlen(g_szLogFile) ? g_szLogFile : NULL);
     if (RT_FAILURE(rc))
-        return RTMsgErrorExit(RTEXITCODE_FAILURE, "Failed to create release log (%s, %Rrc)",
+        return RTMsgErrorExit(RTEXITCODE_FAILURE, "Failed to create release log \"%s\", rc=%Rrc\n",
                               strlen(g_szLogFile) ? g_szLogFile : "<None>", rc);
 

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp

@@ -6 +6 @@
 
 /*
- * Copyright (C) 2013 Oracle Corporation
+ * Copyright (C) 2013-2014 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -1259 +1259 @@
         if (!fProcessAlive)
         {
-            VBoxServiceVerbose(2, "Guest session ID=%RU32 process terminated with rc=%Rrc, reason=%ld, status=%d\n",
+            VBoxServiceVerbose(2, "Guest session process (ID=%RU32) terminated with rc=%Rrc, reason=%ld, status=%d\n",
                                uSessionID, rcWait,
                                ProcessStatus.enmReason, ProcessStatus.iStatus);
+            if (ProcessStatus.iStatus == RTEXITCODE_INIT)
+            {
+                VBoxServiceError("Guest session process (ID=%RU32) failed to initialize. Here some hints:\n",
+                                 uSessionID);
+                VBoxServiceError("- Is logging enabled and the output directory is read-only by the guest session user?\n");
+                /** @todo Add more here. */
+            }
         }
     }
@@ -2351 +2358 @@
     rc = GstCntlSessionInit(&g_Session, uSessionFlags);
     if (RT_FAILURE(rc))
-        return RTMsgErrorExit(RTEXITCODE_FAILURE, "Failed to initialize session object, rc=%Rrc\n", rc);
+        return RTMsgErrorExit(RTEXITCODE_INIT, "Failed to initialize session object, rc=%Rrc\n", rc);
 
     rc = VBoxServiceLogCreate(strlen(g_szLogFile) ? g_szLogFile : NULL);
     if (RT_FAILURE(rc))
-        return RTMsgErrorExit(RTEXITCODE_FAILURE, "Failed to create release log (%s, %Rrc)",
+        return RTMsgErrorExit(RTEXITCODE_INIT, "Failed to create log file \"%s\", rc=%Rrc\n",
                               strlen(g_szLogFile) ? g_szLogFile : "<None>", rc);