Devices

Timestamp:

Jan 22, 2014 1:52:13 AM (11 years ago)

Author:

vboxsync

Message:

NAT/slirp: comment updates to (r89055). Clarify the difference between NATState::fUseHostResolver and NATState::fUseHostResolverPermanent.

Location:

trunk/src/VBox/Devices/Network/slirp

Files:

trunk/src/VBox/Devices/Network/slirp/bootp.c

-              r48526
+              r50156
     if (!pu8RawDhcpObject)
         return;
     /*
+    /**
      * We're going update dns list at least once per DHCP transaction (!not on every operation
      * within transaction), assuming that transaction can't be longer than 1 min.
+     *
+     * @note: NATState::fUseHostResolver became (r89055) the flag signalling that Slirp
+     * wasn't able to fetch fresh host DNS info and fall down to use host-resolver, on one
+     * of the previous attempts to proxy dns requests to Host's name-resolving API
+     *
+     * @note: Checking NATState::fUseHostResolver == true, we want to try restore behaviour initialy
+     * wanted by user ASAP (P here when host serialize its  configuration in files parsed by Slirp).
      */
     if (   !pData->fUseHostResolverPermanent
         && (   pData->dnsLastUpdate == 0
             || curtime - pData->dnsLastUpdate > 60 * 1000
             || pData->fUseHostResolver)) /* one minute*/
+            || curtime - pData->dnsLastUpdate > 60 * 1000 /* one minute */
+            || pData->fUseHostResolver))
+    {
         uint8_t i = 2; /* i = 0 - tag, i == 1 - length */

-              r49347
+              r50156
 #endif
     uma_zone_t zone_ext_refcnt;
+    /**
+     * in (r89055) using of this behaviour has been changed and mean that Slirp
+     * can't parse hosts strucutures/files to provide to guest host name-resolving
+     * configuration, instead Slirp provides .{interface-number + 1}.3 as a nameserver
+     * and proxies DNS queiries to Host's Name Resolver API.
+     */
     bool fUseHostResolver;
+    /** Flag whether using the host resolver mode is permanent
+     * because the user configured it that way. */
+    /**
+     * Flag whether using the host resolver mode is permanent
+     * because the user configured it that way.
+     */
     bool fUseHostResolverPermanent;
     /* from dnsproxy/dnsproxy.h*/

Note: See TracChangeset for help on using the changeset viewer.