Changeset 50291 in vbox for trunk/src/VBox/Main

Timestamp:

Jan 30, 2014 4:22:55 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

91946

Message:

Main/SystemProperties: Add GetStorageControllerHotplugCapable to check whether a given controller type is hotplug capable

Location:

trunk/src/VBox/Main

Files:

• idl/VirtualBox.xidl (modified) (2 diffs)
• src-server/MachineImpl.cpp (modified) (1 diff)
• src-server/SystemPropertiesImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -8888 +8888 @@
     name="ISystemProperties"
     extends="$unknown"
-    uuid="1254a96a-ae57-4484-946a-22d86c1f98af"
+    uuid="29c295a2-346e-42cf-92c0-8db515d75397"
     wsmap="managed"
     >
@@ -9302 +9302 @@
       <param name="enabled" type="boolean" dir="return">
         <desc>Returned flag indicating the default value</desc>
+      </param>
+    </method>
+
+    <method name="getStorageControllerHotplugCapable">
+      <desc>Returns whether the given storage controller supports
+        hot-plugging devices.</desc>
+
+      <param name="controllerType" type="StorageControllerType" dir="in">
+        <desc>The storage controller to check for.</desc>
+      </param>
+
+      <param name="hotplugCapable" type="boolean" dir="return">
+        <desc>Returned flag indicating whether the controller is hotplug capable</desc>
       </param>
     </method>

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -12527 +12527 @@
 bool Machine::isControllerHotplugCapable(StorageControllerType_T enmCtrlType)
 {
-    switch (enmCtrlType)
-    {
-        case StorageControllerType_IntelAhci:
-        case StorageControllerType_USB:
-            return true;
-        case StorageControllerType_LsiLogic:
-        case StorageControllerType_LsiLogicSas:
-        case StorageControllerType_BusLogic:
-        case StorageControllerType_PIIX3:
-        case StorageControllerType_PIIX4:
-        case StorageControllerType_ICH6:
-        case StorageControllerType_I82078:
-        default:
-            return false;
-    }
+    ComPtr<ISystemProperties> systemProperties;
+    HRESULT rc = mParent->COMGETTER(SystemProperties)(systemProperties.asOutParam());
+    if (FAILED(rc))
+        return false;
+
+    BOOL aHotplugCapable = FALSE;
+    systemProperties->COMGETTER(StorageControllerHotplugCapable)(enmCtrlType, &aHotplugCapable);
+
+    return RT_BOOL(aHotplugCapable);
 }
 

trunk/src/VBox/Main/src-server/SystemPropertiesImpl.cpp

@@ -538 +538 @@
 }
 
+HRESULT SystemProperties::getStorageControllerHotplugCapable(StorageControllerType_T aControllerType,
+                                                             BOOL *aHotplugCapable)
+{
+    switch (aControllerType)
+    {
+        case StorageControllerType_IntelAhci:
+        case StorageControllerType_USB:
+            *aHotplugCapable = true;
+            break;
+        case StorageControllerType_LsiLogic:
+        case StorageControllerType_LsiLogicSas:
+        case StorageControllerType_BusLogic:
+        case StorageControllerType_PIIX3:
+        case StorageControllerType_PIIX4:
+        case StorageControllerType_ICH6:
+        case StorageControllerType_I82078:
+            *aHotplugCapable = false;
+            break;
+        default:
+            AssertMsgFailedReturn(("Invalid controller type %d\n", aControllerType), E_FAIL);
+    }
+
+    return S_OK;
+}
+
 HRESULT SystemProperties::getMaxInstancesOfUSBControllerType(ChipsetType_T aChipset,
                                                              USBControllerType_T aType,