Changeset 50330 in vbox

Timestamp:

Feb 5, 2014 2:29:31 PM (11 years ago)

Author:

vboxsync

Message:

FE/Qt: 4397: Medium Manager cleanup/rework (part 5): Information panes stuff encapsulation rework.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/medium

Files:

• UIMediumManager.cpp (modified) (4 diffs)
• UIMediumManager.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp

@@ -607 +607 @@
     updateActions();
 
-    /* Update information-panes: */
-    if (pMediumItem)
-    {
-        QString strDetails = pMediumItem->details();
-        QString strUsage = pMediumItem->usage().isNull() ?
-                           formatPaneText(QApplication::translate("VBoxMediaManagerDlg", "<i>Not&nbsp;Attached</i>"), false) :
-                           formatPaneText(pMediumItem->usage());
-        if (pMediumItem->treeWidget() == mTwHD)
-        {
-            m_pTypePane->setText(pMediumItem->hardDiskType());
-            m_pLocationPane->setText(formatPaneText(pMediumItem->location(), true, "end"));
-            m_pFormatPane->setText(pMediumItem->hardDiskFormat());
-            m_pDetailsPane->setText(strDetails);
-            m_pUsagePane->setText(strUsage);
-        }
-        else if (pMediumItem->treeWidget() == mTwCD)
-        {
-            mIpCD1->setText(formatPaneText(pMediumItem->location(), true, "end"));
-            mIpCD2->setText(strUsage);
-        }
-        else if (pMediumItem->treeWidget() == mTwFD)
-        {
-            mIpFD1->setText(formatPaneText(pMediumItem->location(), true, "end"));
-            mIpFD2->setText(strUsage);
-        }
-    }
-    else
-        clearInfoPanes();
-
-    /* Enable/disable information-pane containers: */
-    mHDContainer->setEnabled(pMediumItem);
-    mCDContainer->setEnabled(pMediumItem);
-    mFDContainer->setEnabled(pMediumItem);
+    /* Update current information-panes: */
+    updateInformationPanes(currentMediumType());
 }
 
@@ -735 +704 @@
     /* Populate content for tree-widgets: */
     populateTreeWidgets();
+
+    /* Update all information-panes: */
+    updateInformationPanes(UIMediumType_All);
 }
 
@@ -1182 +1154 @@
 }
 
+void UIMediumManager::updateInformationPanes(UIMediumType type /* = UIMediumType_Invalid */)
+{
+    /* Make sure type is valid: */
+    if (type == UIMediumType_Invalid)
+        type = currentMediumType();
+
+    /* Depending on required type: */
+    switch (type)
+    {
+        case UIMediumType_HardDisk: updateInformationPanesHD(); break;
+        case UIMediumType_DVD:      updateInformationPanesCD(); break;
+        case UIMediumType_Floppy:   updateInformationPanesFD(); break;
+        case UIMediumType_All:
+            updateInformationPanesHD();
+            updateInformationPanesCD();
+            updateInformationPanesFD();
+            break;
+        default: break;
+    }
+}
+
+void UIMediumManager::updateInformationPanesHD()
+{
+    /* Get current HD item: */
+    UIMediumItem *pCurrentItem = mediumItem(UIMediumType_HardDisk);
+
+    /* If current item is not set: */
+    if (!pCurrentItem)
+    {
+        /* Just clear information panes: */
+        m_pTypePane->clear();
+        m_pLocationPane->clear();
+        m_pFormatPane->clear();
+        m_pDetailsPane->clear();
+        m_pUsagePane->clear();
+    }
+    /* If current item is set: */
+    else
+    {
+        /* Acquire required details: */
+        QString strDetails = pCurrentItem->details();
+        QString strUsage = pCurrentItem->usage().isNull() ?
+                           formatPaneText(QApplication::translate("VBoxMediaManagerDlg", "<i>Not&nbsp;Attached</i>"), false) :
+                           formatPaneText(pCurrentItem->usage());
+        m_pTypePane->setText(pCurrentItem->hardDiskType());
+        m_pLocationPane->setText(formatPaneText(pCurrentItem->location(), true, "end"));
+        m_pFormatPane->setText(pCurrentItem->hardDiskFormat());
+        m_pDetailsPane->setText(strDetails);
+        m_pUsagePane->setText(strUsage);
+    }
+
+    /* Enable/disable information-panes container: */
+    mHDContainer->setEnabled(pCurrentItem);
+}
+
+void UIMediumManager::updateInformationPanesCD()
+{
+    /* Get current optical medium-item: */
+    UIMediumItem *pCurrentItem = mediumItem(UIMediumType_DVD);
+
+    /* If current item is not set: */
+    if (!pCurrentItem)
+    {
+        /* Just clear information panes: */
+        mIpCD1->clear();
+        mIpCD2->clear();
+    }
+    /* If current item is set: */
+    else
+    {
+        /* Update required details: */
+        QString strUsage = pCurrentItem->usage().isNull() ?
+                           formatPaneText(QApplication::translate("VBoxMediaManagerDlg", "<i>Not&nbsp;Attached</i>"), false) :
+                           formatPaneText(pCurrentItem->usage());
+        mIpCD1->setText(formatPaneText(pCurrentItem->location(), true, "end"));
+        mIpCD2->setText(strUsage);
+    }
+
+    /* Enable/disable information-panes container: */
+    mCDContainer->setEnabled(pCurrentItem);
+}
+
+void UIMediumManager::updateInformationPanesFD()
+{
+    /* Get current floppy medium-item: */
+    UIMediumItem *pCurrentItem = mediumItem(UIMediumType_Floppy);
+
+    /* If current item is not set: */
+    if (!pCurrentItem)
+    {
+        /* Just clear information panes: */
+        mIpFD1->clear();
+        mIpFD2->clear();
+    }
+    /* If current item is set: */
+    else
+    {
+        /* Update required details: */
+        QString strUsage = pCurrentItem->usage().isNull() ?
+                           formatPaneText(QApplication::translate("VBoxMediaManagerDlg", "<i>Not&nbsp;Attached</i>"), false) :
+                           formatPaneText(pCurrentItem->usage());
+        mIpFD1->setText(formatPaneText(pCurrentItem->location(), true, "end"));
+        mIpFD2->setText(strUsage);
+    }
+
+    /* Enable/disable information-panes container: */
+    mFDContainer->setEnabled(pCurrentItem);
+}
+
 #ifdef Q_WS_MAC
 void UIMediumManager::cleanupMacWindowMenu()
@@ -1687 +1768 @@
 }
 
-void UIMediumManager::clearInfoPanes()
-{
+void UIMediumManager::prepareToRefresh(int iTotal)
+{
+    /* Clear information panes: */
     m_pTypePane->clear(); m_pLocationPane->clear(); m_pFormatPane->clear(); m_pDetailsPane->clear(); m_pUsagePane->clear();
     mIpCD1->clear(); mIpCD2->clear();
     mIpFD1->clear(); mIpFD2->clear();
-}
-
-void UIMediumManager::prepareToRefresh(int iTotal)
-{
-    /* Info panel clearing: */
-    clearInfoPanes();
 
     /* Prepare progressbar: */

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.h

@@ -125 +125 @@
     /** Update tab icons according last @a action happened with @a pItem. */
     void updateTabIcons(UIMediumItem *pItem, ItemAction action);
+    /** Update information pane of passed medium @a type. */
+    void updateInformationPanes(UIMediumType type = UIMediumType_Invalid);
+    /** Update information pane for hard-drive tab. */
+    void updateInformationPanesHD();
+    /** Update information pane for optical-disk tab. */
+    void updateInformationPanesCD();
+    /** Update information pane for floppy-disk tab. */
+    void updateInformationPanesFD();
 
     /* Helpers: Cleanup stuff: */
@@ -168 +176 @@
     /* Helpers: Other stuff: */
     bool checkMediumFor(UIMediumItem *pItem, Action action);
-    void clearInfoPanes();
     void prepareToRefresh(int iTotal = 0);