Changeset 50372 in vbox for trunk/src

Timestamp:

Feb 9, 2014 4:05:37 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

92127

Message:

Additions/common/VBoxGuest: make CANCEL_ALL_WAITEVENTS cancel the next WAITEVENT if none is in progress.

Location:

trunk/src/VBox/Additions/common/VBoxGuest

Files:

• VBoxGuest.cpp (modified) (5 diffs)
• VBoxGuestInternal.h (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest.cpp

@@ -1373 +1373 @@
 {
     uint32_t fMatches = VBoxGuestCommonGetAndCleanPendingEventsLocked(pDevExt, pSession, fReqEvents);
-    if (fMatches)
+    if (fMatches || pSession->fPendingCancelWaitEvents)
     {
         RTSpinlockReleaseNoInts(pDevExt->EventSpinlock);
@@ -1383 +1383 @@
         else
             Log(("VBoxGuestCommonIOCtl: WAITEVENT: returns %#x/%d\n", pInfo->u32EventFlagsOut, iEvent));
+        pSession->fPendingCancelWaitEvents = false;
         return VINF_SUCCESS;
     }
@@ -1519 +1520 @@
     PVBOXGUESTWAIT          pSafe;
     int                     rc = 0;
+    /* Was as least one WAITEVENT in process for this session?  If not we
+     * set a flag that the next call should be interrupted immediately.  This
+     * is needed so that a user thread can reliably interrupt another one in a
+     * WAITEVENT loop. */
+    bool                    fCancelledOne = false;
 
     Log(("VBoxGuestCommonIOCtl: CANCEL_ALL_WAITEVENTS\n"));
@@ -1530 +1536 @@
         if (pWait->pSession == pSession)
         {
+            fCancelledOne = true;
             pWait->fResEvents = UINT32_MAX;
             RTListNodeRemove(&pWait->ListNode);
@@ -1540 +1547 @@
         }
     }
+    if (!fCancelledOne)
+        pSession->fPendingCancelWaitEvents = true;
     RTSpinlockReleaseNoInts(pDevExt->EventSpinlock);
     Assert(rc == 0);

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuestInternal.h

@@ -237 +237 @@
     /* Guest Caps Acquired & Reported by this session */
     uint32_t                    u32AquiredGuestCaps;
+    /** Whether a CANCEL_ALL_WAITEVENTS is pending.  This happens when
+     * CANCEL_ALL_WAITEVENTS is called, but no call to WAITEVENT is in process
+     * in the current session.  In that case the next call will be interrupted
+     * at once. */
+    bool volatile               fPendingCancelWaitEvents;
 } VBOXGUESTSESSION;