Changeset 50373 in vbox for trunk/src/VBox/Additions/x11

Timestamp:

Feb 9, 2014 4:12:28 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

92128

Message:

Additions/x11/VBoxClient: seamless: take advantage of improved CANCEL_ALL_WAITEVENTS.

Location:

trunk/src/VBox/Additions/x11/VBoxClient

Files:

• seamless.cpp (modified) (2 diffs)
• testcase/tstSeamlessX11.cpp (modified) (1 diff)

trunk/src/VBox/Additions/x11/VBoxClient/seamless.cpp

@@ -63 +63 @@
         rc = VERR_INTERNAL_ERROR;
         if (mHostEventThread)  /* Assertion */
+            break;
+        pszStage = "Testing event loop cancellation";
+        VbglR3InterruptEventWaits();
+        if (RT_FAILURE(VbglR3WaitEvent(VMMDEV_EVENT_VALID_EVENT_MASK, 0, NULL)))
+            break;
+        if (   VbglR3WaitEvent(VMMDEV_EVENT_VALID_EVENT_MASK, 0, NULL)
+            != VERR_TIMEOUT)
             break;
         pszStage = "Connecting to the X server";
@@ -221 +228 @@
 
     LogRelFlowFunc(("\n"));
-    /**
-     * @todo is this reasonable?  If the thread is in the event loop then the cancelEvent()
-     *       will cause it to exit.  If it enters or exits the event loop it will also
-     *       notice that we wish it to exit.  And if it is somewhere in-between, the
-     *       yield() should give it time to get to one of places mentioned above.
-     */
     mHostEventThreadStopping = true;
-    for (int i = 0; (i < 5) && mHostEventThreadRunning; ++i)
-    {
-        cancelEvent();
-        RTThreadYield();
-    }
+    cancelEvent();
     rc = RTThreadWait(mHostEventThread, RT_INDEFINITE_WAIT, NULL);
     if (RT_SUCCESS(rc))

trunk/src/VBox/Additions/x11/VBoxClient/testcase/tstSeamlessX11.cpp

@@ -63 +63 @@
     }
     else
-    {
         rc = RTSemEventWait(eventSem, RT_INDEFINITE_WAIT);
-        if (RT_SUCCESS(rc))
-        {
-            rc = VERR_INTERRUPTED;
-        }
-    }
     return rc;
+}
+
+int VbglR3WaitEvent(uint32_t , uint32_t cMillies, uint32_t *)
+{
+    return RTSemEventWait(eventSem, cMillies);
 }