Changeset 50396 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Feb 10, 2014 4:01:05 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

92156

Message:

FE/Qt: use after free in logging statement

File:

• trunk/src/VBox/Frontends/VirtualBox/src/platform/darwin/DarwinKeyboard.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/platform/darwin/DarwinKeyboard.cpp

@@ -1581 +1581 @@
             if (!darwinKbdCapsEventMatches(pEvent, pHidState->guestState.fCapsLockOn))
             {
-                free(pEvent);
                 CFArrayRemoveValueAtIndex(pHidState->pFifoEventQueue, iQueue);
 
@@ -1587 +1586 @@
                     "ago. Carbon event should not be triggered, removed from queue\n", (int)pKbd->idxPosition,
                     RTTimeSystemMilliTS() - pEvent->tsKeyDown));
+                free(pEvent);
             }
             else