Changeset 5040 in vbox for trunk/include/VBox

Timestamp:

Sep 26, 2007 9:03:00 AM (17 years ago)

Author:

vboxsync

Message:

GC phys/virt to HC virt functions are no longer accessible in our PDM interface.
Rewrote disassembly functions to use the mapping functions.

Code that runs in EMT (like CSAM/PATM) can still use the old conversion functions. Easier to use
and (far) less overhead.

Location:

trunk/include/VBox

Files:

• VBoxGuest.h (modified) (1 diff)
• pdmdev.h (modified) (4 diffs)
• pgm.h (modified) (5 diffs)

trunk/include/VBox/VBoxGuest.h

@@ -107 +107 @@
 #define VMMDEV_VERSION_MINOR (0x4)
 #define VMMDEV_VERSION ((VMMDEV_VERSION_MAJOR << 16) | VMMDEV_VERSION_MINOR)
+
+/* Maximum request packet size */
+#define VMMDEV_MAX_VMMDEVREQ_SIZE           _1M
 
 /**

trunk/include/VBox/pdmdev.h

@@ -2343 +2343 @@
 
     /**
-     * Convert a guest physical address to a host virtual address.
+     * Convert a guest physical address to a host virtual address. (OBSOLETE)
      *
      * @returns VBox status code.
@@ -2355 +2355 @@
      * @remark  Do not use the mapping after you return to the caller! (it could get invalidated/changed)
      */
-    DECLR3CALLBACKMEMBER(int, pfnPhys2HCVirt,(PPDMDEVINS pDevIns, RTGCPHYS GCPhys, RTUINT cbRange, PRTHCPTR ppvHC));
-
-    /**
-     * Convert a guest virtual address to a host virtual address.
+    DECLR3CALLBACKMEMBER(int, pfnObsoletePhys2HCVirt,(PPDMDEVINS pDevIns, RTGCPHYS GCPhys, RTUINT cbRange, PRTHCPTR ppvHC));
+
+    /**
+     * Convert a guest virtual address to a host virtual address. (OBSOLETE)
      *
      * @returns VBox status code.
@@ -2369 +2369 @@
      * @remark  Do not use the mapping after you return to the caller! (it could get invalidated/changed)
      */
-    DECLR3CALLBACKMEMBER(int, pfnPhysGCPtr2HCPtr,(PPDMDEVINS pDevIns, RTGCPTR GCPtr, PRTHCPTR pHCPtr));
+    DECLR3CALLBACKMEMBER(int, pfnObsoletePhysGCPtr2HCPtr,(PPDMDEVINS pDevIns, RTGCPTR GCPtr, PRTHCPTR pHCPtr));
 
     /**
@@ -3207 +3207 @@
 
 /**
- * @copydoc PDMDEVHLP::pfnPhys2HCVirt
- */
-DECLINLINE(int) PDMDevHlpPhys2HCVirt(PPDMDEVINS pDevIns, RTGCPHYS GCPhys, RTUINT cbRange, PRTHCPTR ppvHC)
-{
-    return pDevIns->pDevHlp->pfnPhys2HCVirt(pDevIns, GCPhys, cbRange, ppvHC);
-}
-
-/**
- * @copydoc PDMDEVHLP::pfnPhysGCPtr2HCPtr
- */
-DECLINLINE(int) PDMDevHlpPhysGCPtr2HCPtr(PPDMDEVINS pDevIns, RTGCPTR GCPtr, PRTHCPTR pHCPtr)
-{
-    return pDevIns->pDevHlp->pfnPhysGCPtr2HCPtr(pDevIns, GCPtr, pHCPtr);
-}
-
-/**
  * @copydoc PDMDEVHLP::pfnPhysGCPtr2GCPhys
  */

trunk/include/VBox/pgm.h

@@ -837 +837 @@
 typedef struct PGMPAGEMAPLOCK
 {
+    /** @todo see PGMPhysIsPageMappingLockValid for possibly incorrect assumptions */
 #ifdef IN_GC
     /** Just a dummy for the time being. */
@@ -965 +966 @@
 PGMDECL(void) PGMPhysReleasePageMappingLock(PVM pVM, PPGMPAGEMAPLOCK pLock);
 
+
+/**
+ * Checks if the lock structure is valid
+ * 
+ * @param   pVM         The VM handle.
+ * @param   pLock       The lock structure initialized by the mapping function.
+ */
+DECLINLINE(bool) PGMPhysIsPageMappingLockValid(PVM pVM, PPGMPAGEMAPLOCK pLock)
+{
+    /** @todo -> complete/change this  */
+#ifdef IN_GC
+    return !!(pLock->u32Dummy);
+#else
+    return !!(pLock->pvPage);
+#endif
+}
+
 /**
  * Converts a GC physical address to a HC pointer.
@@ -977 +995 @@
  * @param   cbRange Physical range
  * @param   pHCPtr  Where to store the HC pointer on success.
+ *
+ * @remark  Do *not* assume this mapping will be around forever!
  */
 PGMDECL(int) PGMPhysGCPhys2HCPtr(PVM pVM, RTGCPHYS GCPhys, RTUINT cbRange, PRTHCPTR pHCPtr);
@@ -989 +1009 @@
  * @param   GCPtr       The guest pointer to convert.
  * @param   pHCPtr      Where to store the HC virtual address.
+ *
+ * @remark  Do *not* assume this mapping will be around forever!
  */
 PGMDECL(int) PGMPhysGCPtr2HCPtr(PVM pVM, RTGCPTR GCPtr, PRTHCPTR pHCPtr);
@@ -1002 +1024 @@
  * @param   pHCPtr      Where to store the HC pointer.
  *
+ * @remark  Do *not* assume this mapping will be around forever!
  * @remark  This function is used by the REM at a time where PGM could
  *          potentially not be in sync. It could also be used by a