Changeset 50480 in vbox

Timestamp:

Feb 17, 2014 3:10:07 PM (11 years ago)

Author:

vboxsync

Message:

VBoxNetLwipNAT::natServicePfRegister: fix trivial constness XXX.

File:

• trunk/src/VBox/NetworkServices/NAT/VBoxNetLwipNAT.cpp (modified) (2 diffs)

trunk/src/VBox/NetworkServices/NAT/VBoxNetLwipNAT.cpp

@@ -650 +650 @@
     int rc = VINF_SUCCESS;
     int socketSpec = SOCK_STREAM;
-    char *pszHostAddr;
+    const char *pszHostAddr;
     int sockFamily = (natPf.Pfr.fPfrIPv6 ? PF_INET6 : PF_INET);
 
@@ -666 +666 @@
 
     pszHostAddr = natPf.Pfr.szPfrHostAddr;
-
-    /* XXX: workaround for inet_pton and an empty ipv4 address
-     * in rule declaration.
-     */
-    if (   sockFamily == PF_INET
-        && pszHostAddr[0] == 0)
-        pszHostAddr = (char *)"0.0.0.0"; /* XXX: fix it! without type cast */
-
+    if (sockFamily == PF_INET && pszHostAddr[0] == '\0')
+        pszHostAddr = "0.0.0.0";
 
     lrc = fwspec_set(&natPf.FWSpec,