Changeset 50548 in vbox

Timestamp:

Feb 21, 2014 7:53:11 PM (11 years ago)

Author:

vboxsync

Message:

6813 - src-client/GuestDirectoryImpl.cpp - changes backed out due to error on winrel clbr 92400

Location:

trunk/src/VBox/Main

Files:

• Makefile.kmk (modified) (1 diff)
• include/GuestDirectoryImpl.h (modified) (3 diffs)
• src-client/GuestDirectoryImpl.cpp (modified) (5 diffs)
• src-client/GuestSessionImpl.cpp (modified) (2 diffs)
• src-client/xpcom/module.cpp (modified) (1 diff)

trunk/src/VBox/Main/Makefile.kmk

@@ -1031 +1031 @@
         include/ConsoleImpl.h
 
+ifdef VBOX_WITH_GUEST_CONTROL
 VBoxC_VBOX_INTERMEDIATES   = $(VBOX_MAIN_APIWRAPPER_GEN_HDRS)
 VBoxC_VBOX_HEADERS += $(VBOX_MAIN_APIWRAPPER_INCS)
+endif # VBOX_WITH_GUEST_CONTROL
 
 VBoxC_VBOX_TRANSLATIONS = \

trunk/src/VBox/Main/include/GuestDirectoryImpl.h

@@ -20 +20 @@
 #define ____H_GUESTDIRECTORYIMPL
 
+#include "VirtualBoxBase.h"
 #include "GuestProcessImpl.h"
-#include "GuestDirectoryWrap.h"
 
 class GuestSession;
@@ -29 +29 @@
  */
 class ATL_NO_VTABLE GuestDirectory :
-    public GuestDirectoryWrap,
-    public GuestObject
+    public VirtualBoxBase,
+    public GuestObject,
+    VBOX_SCRIPTABLE_IMPL(IGuestDirectory)
 {
 public:
     /** @name COM and internal init/term/mapping cruft.
      * @{ */
+    VIRTUALBOXBASE_ADD_ERRORINFO_SUPPORT(GuestDirectory, IGuestDirectory)
+    DECLARE_NOT_AGGREGATABLE(GuestDirectory)
+    DECLARE_PROTECT_FINAL_CONSTRUCT()
+    BEGIN_COM_MAP(GuestDirectory)
+        VBOX_DEFAULT_INTERFACE_ENTRIES(IGuestDirectory)
+        COM_INTERFACE_ENTRY(IDirectory)
+    END_COM_MAP()
     DECLARE_EMPTY_CTOR_DTOR(GuestDirectory)
 
     int     init(Console *pConsole, GuestSession *pSession, ULONG uDirID, const GuestDirectoryOpenInfo &openInfo);
     void    uninit(void);
-
     HRESULT FinalConstruct(void);
     void    FinalRelease(void);
     /** @}  */
 
+    /** @name IDirectory interface.
+     * @{ */
+    STDMETHOD(COMGETTER(DirectoryName))(BSTR *aName);
+    STDMETHOD(COMGETTER(Filter))(BSTR *aFilter);
+    STDMETHOD(Close)(void);
+    STDMETHOD(Read)(IFsObjInfo **aInfo);
+    /** @}  */
 
 public:
@@ -49 +63 @@
      * @{ */
     int            callbackDispatcher(PVBOXGUESTCTRLHOSTCBCTX pCbCtx, PVBOXGUESTCTRLHOSTCALLBACK pSvcCb);
+    static Utf8Str guestErrorToString(int guestRc);
     int            onRemove(void);
-
-    static Utf8Str i_guestErrorToString(int guestRc);
-    static HRESULT i_setErrorExternal(VirtualBoxBase *pInterface, int guestRc);
+    static HRESULT setErrorExternal(VirtualBoxBase *pInterface, int guestRc);
     /** @}  */
 
 private:
 
-    /** @name Private Wrapped properties
+    /** @name Private internal methods.
      * @{ */
     /** @}  */
-    HRESULT getDirectoryName(com::Utf8Str &aDirectoryName);
-    HRESULT getFilter(com::Utf8Str &aFilter);
-
-    /** @name Wrapped Private internal methods.
-     * @{ */
-    /** @}  */
-     HRESULT close();
-     HRESULT read(ComPtr<IFsObjInfo> &aObjInfo);
 
     struct Data

trunk/src/VBox/Main/src-client/GuestDirectoryImpl.cpp

@@ -143 +143 @@
 }
 
-// implementation of private wrapped getters/setters for attributes
+// implementation of public getters/setters for attributes
 /////////////////////////////////////////////////////////////////////////////
 
-HRESULT GuestDirectory::getDirectoryName(com::Utf8Str &aDirectoryName)
-{
-    LogFlowThisFuncEnter();
+STDMETHODIMP GuestDirectory::COMGETTER(DirectoryName)(BSTR *aName)
+{
+    LogFlowThisFuncEnter();
+
+    CheckComArgOutPointerValid(aName);
+
+    AutoCaller autoCaller(this);
+    if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    aDirectoryName = mData.mOpenInfo.mPath;
+    mData.mOpenInfo.mPath.cloneTo(aName);
 
     return S_OK;
 }
 
-HRESULT GuestDirectory::getFilter(com::Utf8Str &aFilter)
-{
-    LogFlowThisFuncEnter();
+STDMETHODIMP GuestDirectory::COMGETTER(Filter)(BSTR *aFilter)
+{
+    LogFlowThisFuncEnter();
+
+    CheckComArgOutPointerValid(aFilter);
+
+    AutoCaller autoCaller(this);
+    if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    aFilter = mData.mOpenInfo.mFilter;
+    mData.mOpenInfo.mFilter.cloneTo(aFilter);
 
     return S_OK;
@@ -219 +229 @@
 
 /* static */
-Utf8Str GuestDirectory::i_guestErrorToString(int guestRc)
+Utf8Str GuestDirectory::guestErrorToString(int guestRc)
 {
     Utf8Str strError;
@@ -253 +263 @@
 
 /* static */
-HRESULT GuestDirectory::i_setErrorExternal(VirtualBoxBase *pInterface, int guestRc)
+HRESULT GuestDirectory::setErrorExternal(VirtualBoxBase *pInterface, int guestRc)
 {
     AssertPtr(pInterface);
     AssertMsg(RT_FAILURE(guestRc), ("Guest rc does not indicate a failure when setting error\n"));
 
-    return pInterface->setError(VBOX_E_IPRT_ERROR, GuestDirectory::i_guestErrorToString(guestRc).c_str());
+    return pInterface->setError(VBOX_E_IPRT_ERROR, GuestDirectory::guestErrorToString(guestRc).c_str());
 }
 
 // implementation of public methods
 /////////////////////////////////////////////////////////////////////////////
-HRESULT GuestDirectory::close()
+
+STDMETHODIMP GuestDirectory::Close(void)
 {
 #ifndef VBOX_WITH_GUEST_CONTROL
@@ -308 +319 @@
 }
 
-HRESULT GuestDirectory::read(ComPtr<IFsObjInfo> &aObjInfo)
+STDMETHODIMP GuestDirectory::Read(IFsObjInfo **aInfo)
 {
 #ifndef VBOX_WITH_GUEST_CONTROL
@@ -359 +370 @@
                 {
                     /* Return info object to the caller. */
-                    hr2 = pFsObjInfo.queryInterfaceTo(aObjInfo.asOutParam());
+                    hr2 = pFsObjInfo.queryInterfaceTo(aInfo);
                     if (FAILED(hr2))
                         rc = VERR_COM_UNEXPECTED;

trunk/src/VBox/Main/src-client/GuestSessionImpl.cpp

@@ -2780 +2780 @@
 
             case VERR_GSTCTL_GUEST_ERROR:
-                hr = GuestDirectory::i_setErrorExternal(this, guestRc);
+                hr = GuestDirectory::setErrorExternal(this, guestRc);
                 break;
 
@@ -2885 +2885 @@
 
             case VERR_GSTCTL_GUEST_ERROR:
-                hr = GuestDirectory::i_setErrorExternal(this, guestRc);
+                hr = GuestDirectory::setErrorExternal(this, guestRc);
                 break;
 

trunk/src/VBox/Main/src-client/xpcom/module.cpp

@@ -69 +69 @@
 NS_IMPL_THREADSAFE_ISUPPORTS1_CI(Guest, IGuest)
  #ifdef VBOX_WITH_GUEST_CONTROL
+NS_DECL_CLASSINFO(GuestDirectory)
+NS_IMPL_THREADSAFE_ISUPPORTS2_CI(GuestDirectory, IGuestDirectory, IDirectory)
 NS_DECL_CLASSINFO(GuestFile)
 NS_IMPL_THREADSAFE_ISUPPORTS2_CI(GuestFile, IGuestFile, IFile)