Changeset 50683 in vbox

Timestamp:

Mar 4, 2014 5:13:55 PM (11 years ago)

Author:

vboxsync

Message:

HID LEDs sync: return old behavior when new LEDs sync is OFF.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIExtraDataEventHandler.cpp (modified) (4 diffs)
• globals/UIExtraDataEventHandler.h (modified) (1 diff)
• runtime/UIKeyboardHandler.cpp (modified) (1 diff)
• runtime/UIMachineLogic.cpp (modified) (4 diffs)
• runtime/UIMachineLogic.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIExtraDataEventHandler.cpp

@@ -96 +96 @@
             }
         }
-#ifdef Q_WS_MAC
         else if (vboxGlobal().isVMConsoleProcess())
         {
+            /* Take care about HID LEDs sync */
+            if (strKey == GUI_HidLedsSync)
+            {
+                /* If extra data GUI/HidLedsSync is not present in VM config or set
+                 * to 1 then sync is enabled. Otherwise, it is disabled. */
+                bool f = (strValue.isEmpty() || strValue == "1") ? true : false;
+                emit sigHidLedsSyncStateChanged(f);
+            }
+
+#ifdef Q_WS_MAC
             /* Check for the currently running machine */
             if (strId == vboxGlobal().managedVMUuid())
@@ -109 +118 @@
                 }
             }
+#endif /* Q_WS_MAC */
         }
-#endif /* Q_WS_MAC */
     }
 
@@ -118 +127 @@
     void sigSelectorShortcutsChanged();
     void sigMachineShortcutsChanged();
+    void sigHidLedsSyncStateChanged(bool fEnabled);
 #ifdef RT_OS_DARWIN
     void sigPresentationModeChange(bool fEnabled);
@@ -191 +201 @@
             Qt::QueuedConnection);
 
+    connect(m_pHandler, SIGNAL(sigHidLedsSyncStateChanged(bool)),
+            this, SIGNAL(sigHidLedsSyncStateChanged(bool)),
+            Qt::QueuedConnection);
+
 #ifdef Q_WS_MAC
     connect(m_pHandler, SIGNAL(sigPresentationModeChange(bool)),

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIExtraDataEventHandler.h

@@ -39 +39 @@
     void sigSelectorShortcutsChanged();
     void sigMachineShortcutsChanged();
+    void sigHidLedsSyncStateChanged(bool fEnabled);
 #ifdef RT_OS_DARWIN
     void sigPresentationModeChange(bool fEnabled);

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIKeyboardHandler.cpp

@@ -1214 +1214 @@
     {
         /* Check if the guest has the same view on the modifier keys
-         * (NumLock, CapsLock, ScrollLock) as the X server.
-         * If not, send KeyPress events to synchronize the state: */
-#if !defined(Q_WS_MAC) && !defined(Q_WS_WIN)
-        if (fFlags & KeyPressed)
-            fixModifierState(pCodes, puCodesCount);
+         * (NumLock, CapsLock, ScrollLock) as the X server. */
+#if !defined(Q_WS_MAC)
+        /* If there is no HID LEDs sync enabled or supported
+         * we should re-sync keyboard LEDs and state following this way. */
+        if (!machineLogic()->isHidLedsSyncEnabled())
+            if (fFlags & KeyPressed)
+                fixModifierState(pCodes, puCodesCount);
 #endif
 

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineLogic.cpp

@@ -56 +56 @@
 #include "UIModalWindowManager.h"
 #include "UIMedium.h"
+#include "UIExtraDataEventHandler.h"
 #ifdef Q_WS_MAC
 # include "DockIconPreview.h"
@@ -535 +536 @@
 }
 
+void UIMachineLogic::sltHidLedsSyncStateChanged(bool fEnabled)
+{
+    m_isHidLedsSyncEnabled = fEnabled;
+}
+
 void UIMachineLogic::sltKeyboardLedsChanged()
 {
@@ -647 +653 @@
 #endif /* Q_WS_MAC */
     , m_pHostLedsState(NULL)
-{
+    , m_isHidLedsSyncEnabled(false)
+{
+    /* Setup HID LEDs synchronization. */
+#if defined(Q_WS_MAC) || defined(Q_WS_WIN)
+    /* Read initial extradata value. */
+    QString strHidLedsSyncSettings = session().GetMachine().GetExtraData(GUI_HidLedsSync);
+
+    /* If extra data GUI/HidLedsSync is not present in VM config or set
+     * to 1 then sync is enabled. Otherwise, it is disabled. */
+    if (strHidLedsSyncSettings.isEmpty() || strHidLedsSyncSettings == "1")
+        m_isHidLedsSyncEnabled = true;
+    else
+        m_isHidLedsSyncEnabled = false;
+
+    /* Subscribe to GUI_HidLedsSync extradata changes in order to
+     * be able to enable or disable feature dynamically. */
+    connect(gEDataEvents, SIGNAL(sigHidLedsSyncStateChanged(bool)), this, SLOT(sltHidLedsSyncStateChanged(bool)));
+#else
+    m_isHidLedsSyncEnabled = false;
+#endif
 }
 
@@ -718 +743 @@
             pAction->setText(gpConverter->toString(pAction->data().value<KDragAndDropMode>()));
     }
-}
-
-bool UIMachineLogic::isHidLedsSyncEnabled()
-{
-    /** If extra data GUI/HidLedsSync is not present in VM config or set to 1 then sync is enabled. Otherwise, it is disabled. */
-    QString strHidLedsSyncSettings = session().GetMachine().GetExtraData(GUI_HidLedsSync);
-    if (strHidLedsSyncSettings.isEmpty() || strHidLedsSyncSettings == "1")
-        return true;
-
-    return false;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineLogic.h

@@ -99 +99 @@
 
     /** Performs HID LEDs sync. */
-    bool isHidLedsSyncEnabled();
+    bool isHidLedsSyncEnabled() { return m_isHidLedsSyncEnabled; };
 
 protected slots:
@@ -245 +245 @@
 
     /* Handlers: Keyboard LEDs sync logic: */
+    void sltHidLedsSyncStateChanged(bool fEnabled);
     void sltSwitchKeyboardLedsToGuestLeds();
     void sltSwitchKeyboardLedsToPreviousLeds();
@@ -290 +291 @@
 
     void *m_pHostLedsState;
+    bool m_isHidLedsSyncEnabled;
 
     /* Friend classes: */