Changeset 50810 in vbox for trunk/src/VBox

Timestamp:

Mar 18, 2014 2:53:28 PM (11 years ago)

Author:

vboxsync

Message:

VBoxService/GuestCtrl: Do a HGCM reconnect on saved state restore when the guest session changed; don't try too hard though.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControl.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControl.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2012-2013 Oracle Corporation
+ * Copyright (C) 2012-2014 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -208 +208 @@
     ctxHost.uProtocol = 1;
 
+    int cRetrievalFailed = 0; /* Number of failed message retrievals in a row. */
     for (;;)
     {
@@ -217 +218 @@
         {
 #ifdef DEBUG
-            VBoxServiceVerbose(4, "Message requires %ld parameters, but only 2 supplied -- retrying request (no error!)...\n", cParms);
+            VBoxServiceVerbose(4, "Message requires %ld parameters, but only 2 supplied -- retrying request (no error!)...\n",
+                               cParms);
 #endif
             rc = VINF_SUCCESS; /* Try to get "real" message in next block below. */
         }
         else if (RT_FAILURE(rc))
-            VBoxServiceVerbose(3, "Getting host message failed with %Rrc\n", rc); /* VERR_GEN_IO_FAILURE seems to be normal if ran into timeout. */
+        {
+            /* Note: VERR_GEN_IO_FAILURE seems to be normal if ran into timeout. */
+            VBoxServiceError("Getting host message failed with %Rrc\n", rc);
+
+            /* Check for VM session change. */
+            uint64_t idNewSession = g_idControlSession;
+            int rc2 = VbglR3GetSessionId(&idNewSession);
+            if (   RT_SUCCESS(rc2)
+                && (idNewSession != g_idControlSession))
+            {
+                VBoxServiceVerbose(1, "The VM session ID changed\n");
+                g_idControlSession = idNewSession;
+
+                /* Close all opened guest sessions -- all context IDs, sessions etc.
+                 * are now invalid. */
+                rc2 = GstCntlSessionClose(&g_Session);
+                AssertRC(rc2);
+
+                /* Do a reconnect. */
+                VBoxServiceVerbose(1, "Reconnecting to HGCM service ...\n");
+                rc2 = VbglR3GuestCtrlConnect(&g_uControlSvcClientID);
+                if (RT_SUCCESS(rc2))
+                {
+                    VBoxServiceVerbose(3, "Guest control service client ID=%RU32\n",
+                                       g_uControlSvcClientID);
+                    cRetrievalFailed = 0;
+                    continue; /* Skip waiting. */
+                }
+                else
+                {
+                    VBoxServiceError("Unable to re-connect to HGCM service, rc=%Rrc, bailing out\n", rc);
+                    break;
+                }
+            }
+
+            if (++cRetrievalFailed > 16) /** @todo Make this configurable? */
+            {
+                VBoxServiceError("Too many failed attempts in a row to get next message, bailing out\n");
+                break;
+            }
+
+            RTThreadSleep(1000); /* Wait a bit before retrying. */
+        }
+
         if (RT_SUCCESS(rc))
         {
             VBoxServiceVerbose(4, "Msg=%RU32 (%RU32 parms) retrieved\n", uMsg, cParms);
+            cRetrievalFailed = 0; /* Reset failed retrieval count. */
 
             /* Set number of parameters for current host context. */