Changeset 50817 in vbox for trunk/src/VBox/HostServices/SharedOpenGL/crserverlib

Timestamp:

Mar 19, 2014 10:29:48 AM (11 years ago)

Author:

vboxsync

Message:

crOpenGL: new command submission continued

File:

• trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_main.c (modified) (13 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_main.c

@@ -62 +62 @@
 static DECLCALLBACK(int) crVBoxCrCmdCmd(HVBOXCRCMDSVR hSvr, PVBOXCMDVBVA_HDR pCmd, uint32_t cbCmd);
 
+DECLINLINE(CRClient*) crVBoxServerClientById(uint32_t u32ClientID)
+{
+    int32_t i;
+
+    if (cr_server.fCrCmdEnabled)
+        return CrHTableGet(&cr_server.clientTable, u32ClientID);
+
+    for (i = 0; i < cr_server.numClients; i++)
+    {
+        if (cr_server.clients[i] && cr_server.clients[i]->conn
+            && cr_server.clients[i]->conn->u32ClientID==u32ClientID)
+        {
+            return cr_server.clients[i];
+        }
+    }
+
+    return NULL;
+}
+
 DECLINLINE(int32_t) crVBoxServerClientGet(uint32_t u32ClientID, CRClient **ppClient)
 {
@@ -67 +86 @@
     int32_t i;
 
-    *ppClient = NULL;
-
-    for (i = 0; i < cr_server.numClients; i++)
-    {
-        if (cr_server.clients[i] && cr_server.clients[i]->conn
-            && cr_server.clients[i]->conn->u32ClientID==u32ClientID)
-        {
-            pClient = cr_server.clients[i];
-            break;
-        }
-    }
+    pClient = crVBoxServerClientById(u32ClientID);
+
     if (!pClient)
     {
-        crWarning("client not found!");
+        WARN(("client not found!"));
+        *ppClient = NULL;
         return VERR_INVALID_PARAMETER;
     }
@@ -86 +97 @@
     if (!pClient->conn->vMajor)
     {
-        crWarning("no major version specified for client!");
+        WARN(("no major version specified for client!"));
+        *ppClient = NULL;
         return VERR_NOT_SUPPORTED;
     }
@@ -337 +349 @@
 #endif
 
+    cr_server.fCrCmdEnabled = GL_FALSE;
+    CrHTableCreate(&cr_server.clientTable, CR_MAX_CLIENTS);
+
     cr_server.bUseMultipleContexts = (crGetenv( "CR_SERVER_ENABLE_MULTIPLE_CONTEXTS" ) != NULL);
 
@@ -441 +456 @@
 #endif
 
+    cr_server.fCrCmdEnabled = GL_FALSE;
+    CrHTableCreate(&cr_server.clientTable, CR_MAX_CLIENTS);
+
     cr_server.bUseMultipleContexts = (crGetenv( "CR_SERVER_ENABLE_MULTIPLE_CONTEXTS" ) != NULL);
 
@@ -591 +609 @@
 }
 
-void crVBoxServerRemoveClient(uint32_t u32ClientID)
-{
-    CRClient *pClient=NULL;
-    int32_t i;
-
-    crDebug("crServer: RemoveClient u32ClientID=%d", u32ClientID);
-
-    for (i = 0; i < cr_server.numClients; i++)
-    {
-        if (cr_server.clients[i] && cr_server.clients[i]->conn
-            && cr_server.clients[i]->conn->u32ClientID==u32ClientID)
-        {
-            pClient = cr_server.clients[i];
-            break;
-        }
-    }
-    //if (!pClient) return VERR_INVALID_PARAMETER;
-    if (!pClient)
-    {
-        crWarning("Invalid client id %u passed to crVBoxServerRemoveClient", u32ClientID);
-        return;
-    }
-
+static void crVBoxServerRemoveClientObj(CRClient *pClient)
+{
 #ifdef VBOX_WITH_CRHGSMI
     CRVBOXHGSMI_CMDDATA_ASSERT_CLEANED(&pClient->conn->CmdData);
@@ -623 +620 @@
     /* Let server clear client from the queue */
     crServerDeleteClient(pClient);
+}
+
+static void crVBoxServerRemoveAllClients()
+{
+    int32_t i;
+    for (i = cr_server.numClients - 1; i >= 0; --i)
+    {
+        Assert(cr_server.clients[i]);
+        crVBoxServerRemoveClientObj(cr_server.clients[i]);
+    }
+}
+
+void crVBoxServerRemoveClient(uint32_t u32ClientID)
+{
+    CRClient *pClient=NULL;
+    int32_t i;
+
+    crDebug("crServer: RemoveClient u32ClientID=%d", u32ClientID);
+
+    for (i = 0; i < cr_server.numClients; i++)
+    {
+        if (cr_server.clients[i] && cr_server.clients[i]->conn
+            && cr_server.clients[i]->conn->u32ClientID==u32ClientID)
+        {
+            pClient = cr_server.clients[i];
+            break;
+        }
+    }
+    //if (!pClient) return VERR_INVALID_PARAMETER;
+    if (!pClient)
+    {
+        WARN(("Invalid client id %u passed to crVBoxServerRemoveClient", u32ClientID));
+        return;
+    }
+
+    crVBoxServerRemoveClientObj(pClient);
 }
 
@@ -3263 +3296 @@
 static DECLCALLBACK(int) crVBoxCrCmdEnable(HVBOXCRCMDSVR hSvr, VBOXCRCMD_SVRENABLE_INFO *pInfo)
 {
+    Assert(!cr_server.fCrCmdEnabled);
+    Assert(!cr_server.numClients);
+
     cr_server.CrCmdClientInfo = *pInfo;
 
     crVBoxServerDefaultContextSet();
 
+    cr_server.fCrCmdEnabled = GL_TRUE;
+
     return VINF_SUCCESS;
 }
@@ -3272 +3310 @@
 static DECLCALLBACK(int) crVBoxCrCmdDisable(HVBOXCRCMDSVR hSvr)
 {
+    Assert(cr_server.fCrCmdEnabled);
+
+    crVBoxServerRemoveAllClients();
+
+    CrHTableEmpty(&cr_server.clientTable);
+
     cr_server.head_spu->dispatch_table.MakeCurrent(0, 0, 0);
 
     memset(&cr_server.CrCmdClientInfo, 0, sizeof (cr_server.CrCmdClientInfo));
 
+    cr_server.fCrCmdEnabled = GL_FALSE;
+
     return VINF_SUCCESS;
 }
@@ -3282 +3328 @@
 {
     return crVBoxServerHostCtl((VBOXCRCMDCTL*)pCmd, cbCmd);
+}
+
+static int crVBoxCrDisconnect(uint32_t u32Client)
+{
+    CRClient *pClient = (CRClient*)CrHTableRemove(&cr_server.clientTable, u32Client);
+    if (!pClient)
+    {
+        WARN(("invalid client id"));
+        return VERR_INVALID_PARAMETER;
+    }
+
+    crVBoxServerRemoveClientObj(pClient);
+
+    return VINF_SUCCESS;
+}
+
+static int crVBoxCrConnect(VBOXCMDVBVA_3DCTL_CONNECT *pConnect)
+{
+    CRClient *pClient;
+    int rc;
+    /* allocate client id */
+    uint32_t u32ClientId =  CrHTablePut(&cr_server.clientTable, (void*)1);
+    if (u32ClientId != CRHTABLE_HANDLE_INVALID)
+    {
+        rc = crVBoxServerAddClientObj(u32ClientId, &pClient);
+        if (RT_SUCCESS(rc))
+        {
+            rc = CrHTablePutToSlot(&cr_server.clientTable, u32ClientId, pClient);
+            if (RT_SUCCESS(rc))
+                return VINF_SUCCESS;
+            else
+                WARN(("CrHTablePutToSlot failed %d", rc));
+
+            crVBoxServerRemoveClientObj(pClient);
+        }
+        else
+            WARN(("crVBoxServerAddClientObj failed %d", rc));
+
+        CrHTableRemove(&cr_server.clientTable, u32ClientId);
+    }
+    else
+    {
+        WARN(("CrHTablePut failed"));
+        rc = VERR_NO_MEMORY;
+    }
+
+    return rc;
 }
 
@@ -3297 +3390 @@
         case VBOXCMDVBVA3DCTL_TYPE_CONNECT:
         {
-            VBOXCMDVBVA_3DCTL_CONNECT *pConnect = (VBOXCMDVBVA_3DCTL_CONNECT*)pCtl;
-
-            return VERR_NOT_SUPPORTED;
+            if (cbCmd != sizeof (VBOXCMDVBVA_3DCTL_CONNECT))
+            {
+                WARN(("invalid command size"));
+                return VERR_INVALID_PARAMETER;
+            }
+
+            return crVBoxCrConnect((VBOXCMDVBVA_3DCTL_CONNECT*)pCtl);
         }
         case VBOXCMDVBVA3DCTL_TYPE_DISCONNECT:
         {
-            return VERR_NOT_SUPPORTED;
+            if (cbCmd != sizeof (VBOXCMDVBVA_3DCTL))
+            {
+                WARN(("invalid command size"));
+                return VERR_INVALID_PARAMETER;
+            }
+
+            return crVBoxCrDisconnect(pCtl->u32CmdClientId);
         }
         case VBOXCMDVBVA3DCTL_TYPE_CMD:
@@ -3778 +3881 @@
     uint32_t cbCtl;
 
+    Assert(!cr_server.fCrCmdEnabled);
+
     if (cr_server.numClients)
     {
@@ -3796 +3901 @@
 int32_t crVBoxServerHgcmDisable()
 {
+    Assert(!cr_server.fCrCmdEnabled);
+
     if (cr_server.numClients)
     {