Changeset 50863 in vbox for trunk/src/VBox/VMM

Timestamp:

Mar 25, 2014 12:56:50 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

92955

Message:

VMM/IEMAllCImpl: Comment clarification about reserved bits in CR4 for raising GP.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllCImpl.cpp.h

@@ -4256 +4256 @@
             uint64_t const uOldCrX = pCtx->cr4;
 
+            /** @todo Shouldn't this look at the guest CPUID bits to determine
+             *        valid bits? e.g. if guest CPUID doesn't allow X86_CR4_OSXMMEEXCPT, we
+             *        should #GP(0). */
             /* reserved bits */
             uint32_t fValid = X86_CR4_VME | X86_CR4_PVI