Changeset 50889 in vbox for trunk/src/VBox

Timestamp:

Mar 26, 2014 1:13:56 PM (11 years ago)

Author:

vboxsync

Message:

dev/graphics: fix a race

File:

• trunk/src/VBox/Devices/Graphics/DevVGA_VDMA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA_VDMA.cpp

@@ -679 +679 @@
 {
     Assert(pThread->u32State == VBOXVDMATHREAD_STATE_TERMINATED);
+    pThread->u32State = VBOXVDMATHREAD_STATE_CREATED;
     int rc = RTSemEventSignal(pThread->hClientEvent);
     AssertRC(rc);
-    if (RT_SUCCESS(rc))
-    {
-        pThread->u32State = VBOXVDMATHREAD_STATE_CREATED;
-        return VINF_SUCCESS;
-    }
-    return rc;
+    return VINF_SUCCESS;
 }
 
@@ -1279 +1275 @@
 
     uint8_t *pu8Vram = pu8VramBase + pTransfer->Alloc.u.offVRAM;
-    bool fIn = (pTransfer->Hdr.u8Flags & VBOXCMDVBVA_OPF_PAGING_TRANSFER_IN);
+    bool fIn = !!(pTransfer->Hdr.u8Flags & VBOXCMDVBVA_OPF_PAGING_TRANSFER_IN);
 
     *ppSysMem = pSysMem;