Changeset 50922 in vbox for trunk/src/VBox

Timestamp:

Mar 28, 2014 4:16:41 PM (11 years ago)

Author:

vboxsync

Message:

6183 src-all/PCIDeviceAttachmentImpl.cpp

Location:

trunk/src/VBox/Main

Files:

• include/PCIDeviceAttachmentImpl.h (modified) (2 diffs)
• src-all/PCIDeviceAttachmentImpl.cpp (modified) (4 diffs)
• src-server/MachineImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/include/PCIDeviceAttachmentImpl.h

@@ -21 +21 @@
 #define ____H_PCIDEVICEATTACHMENTIMPL
 
-#include "VirtualBoxBase.h"
+#include "PCIDeviceAttachmentWrap.h"
 #include <VBox/settings.h>
 
 class ATL_NO_VTABLE PCIDeviceAttachment :
-    public VirtualBoxBase,
-    VBOX_SCRIPTABLE_IMPL(IPCIDeviceAttachment)
+    public PCIDeviceAttachmentWrap
 {
 public:
-    VIRTUALBOXBASE_ADD_ERRORINFO_SUPPORT(PCIDeviceAttachment, IPCIDeviceAttachment)
 
-    DECLARE_NOT_AGGREGATABLE(PCIDeviceAttachment)
-
-    DECLARE_PROTECT_FINAL_CONSTRUCT()
-
-    BEGIN_COM_MAP(PCIDeviceAttachment)
-        VBOX_DEFAULT_INTERFACE_ENTRIES(IPCIDeviceAttachment)
-    END_COM_MAP()
-
-    PCIDeviceAttachment() { }
-    ~PCIDeviceAttachment() { }
+    DECLARE_EMPTY_CTOR_DTOR(PCIDeviceAttachment)
 
     // public initializer/uninitializer for internal purposes only
@@ -52 +41 @@
 
     // settings
-    HRESULT loadSettings(IMachine * aParent,
-                         const settings::HostPCIDeviceAttachment& aHpda);
-    HRESULT saveSettings(settings::HostPCIDeviceAttachment &data);
+    HRESULT i_loadSettings(IMachine * aParent,
+                           const settings::HostPCIDeviceAttachment& aHpda);
+    HRESULT i_saveSettings(settings::HostPCIDeviceAttachment &data);
 
     HRESULT FinalConstruct();
     void FinalRelease();
 
-    // IPCIDeviceAttachment properties
-    STDMETHOD(COMGETTER(Name))(BSTR * aName);
-    STDMETHOD(COMGETTER(IsPhysicalDevice))(BOOL * aPhysical);
-    STDMETHOD(COMGETTER(HostAddress))(LONG  * hostAddress);
-    STDMETHOD(COMGETTER(GuestAddress))(LONG * guestAddress);
+private:
 
-private:
+    // wrapped IPCIDeviceAttachment properties
+    HRESULT getName(com::Utf8Str &aName);
+    HRESULT getIsPhysicalDevice(BOOL *aIsPhysicalDevice);
+    HRESULT getHostAddress(LONG *aHostAddress);
+    HRESULT getGuestAddress(LONG *aGuestAddress);
+
     struct Data;
     Data*  m;

trunk/src/VBox/Main/src-all/PCIDeviceAttachmentImpl.cpp

@@ -43 +43 @@
 // constructor / destructor
 /////////////////////////////////////////////////////////////////////////////
+DEFINE_EMPTY_CTOR_DTOR(PCIDeviceAttachment)
 
 HRESULT PCIDeviceAttachment::FinalConstruct()
@@ -71 +72 @@
 }
 
-HRESULT PCIDeviceAttachment::loadSettings(IMachine *aParent,
-                                          const settings::HostPCIDeviceAttachment &hpda)
+HRESULT PCIDeviceAttachment::i_loadSettings(IMachine *aParent,
+                                            const settings::HostPCIDeviceAttachment &hpda)
 {
     Bstr bname(hpda.strDeviceName);
@@ -79 +80 @@
 
 
-HRESULT PCIDeviceAttachment::saveSettings(settings::HostPCIDeviceAttachment &data)
+HRESULT PCIDeviceAttachment::i_saveSettings(settings::HostPCIDeviceAttachment &data)
 {
     Assert(m);
@@ -104 +105 @@
 // IPCIDeviceAttachment properties
 /////////////////////////////////////////////////////////////////////////////
-
-STDMETHODIMP PCIDeviceAttachment::COMGETTER(Name)(BSTR * aName)
+HRESULT PCIDeviceAttachment::getName(com::Utf8Str &aName)
 {
-    CheckComArgOutPointerValid(aName);
-    m->DevName.cloneTo(aName);
+    aName = m->DevName;
     return S_OK;
 }
 
-STDMETHODIMP PCIDeviceAttachment::COMGETTER(IsPhysicalDevice)(BOOL * aPhysical)
+HRESULT PCIDeviceAttachment::getIsPhysicalDevice(BOOL *aIsPhysicalDevice)
 {
-    CheckComArgOutPointerValid(aPhysical);
-    *aPhysical = m->fPhysical;
+    *aIsPhysicalDevice = m->fPhysical;
     return S_OK;
 }
 
-STDMETHODIMP PCIDeviceAttachment::COMGETTER(HostAddress)(LONG * aHostAddress)
+HRESULT PCIDeviceAttachment::getHostAddress(LONG *aHostAddress)
 {
     *aHostAddress = m->HostAddress;
     return S_OK;
 }
-
-STDMETHODIMP PCIDeviceAttachment::COMGETTER(GuestAddress)(LONG * aGuestAddress)
+HRESULT PCIDeviceAttachment::getGuestAddress(LONG *aGuestAddress)
 {
     *aGuestAddress = m->GuestAddress;
     return S_OK;
 }
-
-#ifdef VBOX_WITH_XPCOM
-NS_DECL_CLASSINFO(PCIDeviceAttachment)
-NS_IMPL_THREADSAFE_ISUPPORTS1_CI(PCIDeviceAttachment, IPCIDeviceAttachment)
-#endif

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -9498 +9498 @@
 
             pda.createObject();
-            pda->loadSettings(this, hpda);
+            pda->i_loadSettings(this, hpda);
             mHWData->mPCIDeviceAssignments.push_back(pda);
         }
@@ -10791 +10791 @@
             settings::HostPCIDeviceAttachment hpda;
 
-            rc = pda->saveSettings(hpda);
+            rc = pda->i_saveSettings(hpda);
             if (FAILED(rc)) throw rc;