Changeset 51057 in vbox for trunk/src/VBox/Devices/PC/BIOS

Timestamp:

Apr 11, 2014 9:24:29 PM (11 years ago)

Author:

vboxsync

Message:

Improved code readability slightly.

File:

• trunk/src/VBox/Devices/PC/BIOS/pmsetup.inc (modified) (2 diffs)

trunk/src/VBox/Devices/PC/BIOS/pmsetup.inc

@@ -15 +15 @@
 ;;
 
-LVT0            equ     0FEE00350h
-LVT1            equ     0FEE00360h
+LVT_LINT0       equ     0FEE00350h
+LVT_LINT1       equ     0FEE00360h
 
 public          pmode_setup
 
-;; Program LVT0/LVT1 entries in the local APIC. Some Linux kernels (e.g., RHEL4
-;; SMP 32-bit) expect the entries to be unmasked in virtual wire mode.
+;; Program LINT0/LINT1 entries in the local APIC. Some Linux kernels (e.g.,
+;; RHEL4 SMP 32-bit) expect the entries to be unmasked in virtual wire mode.
+;; Also make sure APIC timer is masked.
 
 pmode_setup     proc    near
@@ -31 +32 @@
                 cli                     ; Interrupts would kill us!
                 call    pmode_enter
+
                 mov     eax, cr0        ; Clear CR0.CD and CR0.NW
                 and     eax, 09FFFFFFFh
                 mov     cr0, eax
-                mov     esi, LVT0       ; Program LVT0 to ExtINT and unmask
+
+                mov     esi, LVT_LINT0  ; Program LINT0 to ExtINT and unmask
                 mov     eax, [esi]
                 and     eax, 0FFFE00FFh
                 or      ah,  7
                 mov     [esi], eax
-                mov     esi, LVT1       ; Program LVT1 to NMI and unmask
+
+                mov     esi, LVT_LINT1  ; Program LINT1 to NMI and unmask
                 mov     eax, [esi]
                 and     eax, 0FFFE00FFh
                 or      ah,  4
                 mov     [esi], eax
+
                 call    pmode_exit
                 popf