Changeset 51213 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

May 8, 2014 12:56:38 PM (11 years ago)

Author:

vboxsync

Message:

FE/Qt: 6660: Advanced extra-data management framework: Integrate GUI_HideDescriptionForWizards.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• extradata/UIExtraDataManager.cpp (modified) (1 diff)
• extradata/UIExtraDataManager.h (modified) (1 diff)
• wizards/UIWizard.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.cpp

@@ -241 +241 @@
 #endif /* VBOX_GUI_WITH_NETWORK_MANAGER */
 
+bool UIExtraDataManager::isDescriptionHiddenForWizard(const QString &strWizardName)
+{
+    /* True if wizard-name among the others: */
+    return extraDataStringList(GUI_HideDescriptionForWizards).contains(strWizardName);
+}
+
+void UIExtraDataManager::setDescriptionHiddenForWizard(const QString &strWizardName, bool fHidden)
+{
+    /* Get current value: */
+    QStringList oldValue = extraDataStringList(GUI_HideDescriptionForWizards);
+    QStringList newValue = oldValue;
+    /* Include wizard-name if necessary: */
+    if (fHidden && !newValue.contains(strWizardName))
+        newValue << strWizardName;
+    /* Exclude wizard-name if necessary: */
+    else if (!fHidden && newValue.contains(strWizardName))
+        newValue.removeAll(strWizardName);
+    /* Update extra-data if necessary: */
+    if (newValue != oldValue)
+        setExtraDataStringList(GUI_HideDescriptionForWizards, newValue);
+}
+
 bool UIExtraDataManager::isFirstRun(const QString &strId) const
 {

trunk/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.h

@@ -114 +114 @@
     bool shouldWeAllowApplicationUpdate() const;
 #endif /* VBOX_GUI_WITH_NETWORK_MANAGER */
+
+    /** Returns whether description should be hidden for wizard @a strWizardName. */
+    bool isDescriptionHiddenForWizard(const QString &strWizardName);
+    /** Defines whether description should be @a fHidden for wizard @a strWizardName. */
+    void setDescriptionHiddenForWizard(const QString &strWizardName, bool fHidden);
 
     /** Returns whether this machine started for the first time. */

trunk/src/VBox/Frontends/VirtualBox/src/wizards/UIWizard.cpp

@@ -28 +28 @@
 #include "VBoxGlobal.h"
 #include "QIRichTextLabel.h"
+#include "UIExtraDataManager.h"
 
 void UIWizard::sltCurrentIdChanged(int iId)
@@ -51 +52 @@
         cleanup();
 
-        /* Compose wizard's name: */
-        QString strWizardName = nameForType(m_type);
-        /* Load mode settings: */
-        QStringList wizards = vboxGlobal().virtualBox().GetExtraDataStringList(GUI_HideDescriptionForWizards);
-
         /* Switch mode: */
         switch (m_mode)
         {
-            case UIWizardMode_Basic:
-            {
-                m_mode = UIWizardMode_Expert;
-                if (!wizards.contains(strWizardName))
-                    wizards << strWizardName;
-                break;
-            }
-            case UIWizardMode_Expert:
-            {
-                m_mode = UIWizardMode_Basic;
-                if (wizards.contains(strWizardName))
-                    wizards.removeAll(strWizardName);
-                break;
-            }
-            default:
-            {
-                AssertMsgFailed(("Invalid mode: %d", m_mode));
-                break;
-            }
+            case UIWizardMode_Basic:  m_mode = UIWizardMode_Expert; break;
+            case UIWizardMode_Expert: m_mode = UIWizardMode_Basic;  break;
+            default: AssertMsgFailed(("Invalid mode: %d", m_mode)); break;
         }
 
         /* Save mode settings: */
-        vboxGlobal().virtualBox().SetExtraDataStringList(GUI_HideDescriptionForWizards, wizards);
+        gEDataManager->setDescriptionHiddenForWizard(nameForType(m_type), m_mode == UIWizardMode_Expert);
 
         /* Prepare: */
@@ -547 +527 @@
     if (type == UIWizardType_FirstRun)
         return UIWizardMode_Basic;
-    /* Get mode from extra-data: */
-    QStringList wizards = vboxGlobal().virtualBox().GetExtraDataStringList(GUI_HideDescriptionForWizards);
-    if (wizards.contains(nameForType(type)))
-        return UIWizardMode_Expert;
-    /* Return mode: */
-    return UIWizardMode_Basic;
-}
-
+    /* Otherwise get mode from extra-data manager: */
+    return gEDataManager->isDescriptionHiddenForWizard(nameForType(type))
+           ? UIWizardMode_Expert : UIWizardMode_Basic;
+}
+