Changeset 515 in vbox for trunk/src

Timestamp:

Feb 1, 2007 5:20:03 PM (18 years ago)

Author:

vboxsync

Message:

Possibly dangerous change: stop monitoring IDT patch pages when too many invalid writes have been encountered.

File:

• trunk/src/VBox/VMM/PATM/PATM.cpp (modified) (1 diff)

trunk/src/VBox/VMM/PATM/PATM.cpp

@@ -4725 +4725 @@
                         if (pPatch->cInvalidWrites > PATM_MAX_INVALID_WRITES)
                         {
-                            LogRel(("PATM: Disable block at %VGv - invalid write %VGv-%VGv \n", pPatch->pPrivInstrGC, GCPtr, GCPtr+cbWrite));
-
-                            PATMR3MarkDirtyPatch(pVM, pPatch);
-
+                            /** @note possibly dangerous assumption that all future writes will be harmless. */
+                            if (pPatch->flags & PATMFL_IDTHANDLER)
+                            {
+                                LogRel(("PATM: Stop monitoring IDT handler pages at %VGv - invalid write %VGv-%VGv \n", pPatch->pPrivInstrGC, GCPtr, GCPtr+cbWrite));
+
+                                Assert(pPatch->flags & PATMFL_CODE_MONITORED);
+                                int rc = patmRemovePatchPages(pVM, pPatch);
+                                AssertRC(rc);
+                            }
+                            else
+                            {
+                                LogRel(("PATM: Disable block at %VGv - invalid write %VGv-%VGv \n", pPatch->pPrivInstrGC, GCPtr, GCPtr+cbWrite));
+                                PATMR3MarkDirtyPatch(pVM, pPatch);
+                            }
                             /** @note jump back to the start as the pPatchPage has been deleted or changed */
                             goto invalid_write_loop_start;
                         }
-                    }
+                    } /* for */
                 }
             }