Changeset 51631 in vbox for trunk/src/VBox/Devices/Graphics

Timestamp:

Jun 17, 2014 1:02:43 PM (11 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

94384

Message:

vga: saved state fixes

Location:

trunk/src/VBox/Devices/Graphics

Files:

• DevVGASavedState.h (modified) (1 diff)
• DevVGA_VBVA.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Graphics/DevVGASavedState.h

@@ -23 +23 @@
 #define Graphics_DevVGASavedState_h
 
-#define VGA_SAVEDSTATE_VERSION              13
+#define VGA_SAVEDSTATE_VERSION              14
+#define VGA_SAVEDSTATE_VERSION_FIXED_PENDVHWA 14
 #define VGA_SAVEDSTATE_VERSION_3D           13
 #define VGA_SAVEDSTATE_VERSION_HGSMIMA      12 /* HGSMI memory allocator. */

trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp

@@ -1478 +1478 @@
     {
         case VBOXVBVASAVEDSTATE_VHWAAVAILABLE_MAGIC:
+            pData->ab2DOn[iDisplay] = true;
             return true;
         case VBOXVBVASAVEDSTATE_VHWAUNAVAILABLE_MAGIC:
+            pData->ab2DOn[iDisplay] = false;
             return false;
         default:
@@ -1655 +1657 @@
         }
     }
+
+    /* no pending commands */
+    SSMR3PutU32(pSSM, 0);
 #endif
     return rc;
@@ -1830 +1835 @@
                     vbvaVHWAHHCommandRelease(pCmd);
                     AssertRCReturn(rc, rc);
-
-                    rc = vbvaVHWACommandLoadPending(pVGAState, pSSM, u32Version);
+                    bool fLoadCommands = false;
+
+                    if (u32Version < VGA_SAVEDSTATE_VERSION_FIXED_PENDVHWA)
+                    {
+                        /* prev versions have a bug that does not allow to distinguish between the sate made with VHWA not available (on solaris box)
+                         * and VHWA disabled */
+
+                        for (uint32_t i = 0; i < pVGAState->cMonitors; ++i)
+                        {
+                            if (VhwaData.ab2DOn[i])
+                            {
+                                fLoadCommands = true;
+                                break;
+                            }
+                        }
+                    }
+                    else
+                        fLoadCommands = true;
+
+                    if (fLoadCommands)
+                    {
+                        rc = vbvaVHWACommandLoadPending(pVGAState, pSSM, u32Version);
+                        AssertRCReturn(rc, rc);
+                    }
+                }
+                else
+                {
+                    rc = VERR_OUT_OF_RESOURCES;
+                }
+#else
+                uint32_t u32;
+
+                for (uint32_t i = 0; i < pVGAState->cMonitors; ++i)
+                {
+                    rc = SSMR3PGetU32(pSSM, &u32);
                     AssertRCReturn(rc, rc);
-                }
-                else
-                {
-                    rc = VERR_OUT_OF_RESOURCES;
-                }
-#else
-                rc = SSMR3SkipToEndOfUnit(pSSM);
-                AssertRCReturn(rc, rc);
+
+                    if (u32 != VBOXVBVASAVEDSTATE_VHWAUNAVAILABLE_MAGIC)
+                    {
+                        LogRel(("2D data while 2D is not supported\n"));
+                        return VERR_NOT_SUPPORTED;
+                    }
+                }
+
+                if (u32Version >= VGA_SAVEDSTATE_VERSION_FIXED_PENDVHWA)
+                {
+                    rc = SSMR3GetU32(pSSM, &u32);
+                    AssertRCReturn(rc, rc);
+                }
+
+                if (u32)
+                {
+                    LogRel(("2D pending command while 2D is not supported\n"));
+                    return VERR_NOT_SUPPORTED;
+                }
 #endif
             }