Changeset 5190 in vbox

Timestamp:

Oct 8, 2007 6:27:49 PM (17 years ago)

Author:

vboxsync

Message:

Added MachineDebugger::getStats.

Location:

trunk/src/VBox/Main

Files:

• MachineDebuggerImpl.cpp (modified) (5 diffs)
• idl/VirtualBox.xidl (modified) (15 diffs)
• include/MachineDebuggerImpl.h (modified) (1 diff)

trunk/src/VBox/Main/MachineDebuggerImpl.cpp

@@ -131 +131 @@
 
 /**
- * Resets VM statistics
- *
- * @returns COM status code
+ * Resets VM statistics.
+ *
+ * @returns COM status code.
  */
 STDMETHODIMP MachineDebugger::ResetStats()
@@ -144 +144 @@
 
 /**
- * Dumps VM statistics to the log
- *
- * @returns COM status code
+ * Dumps VM statistics to the log.
+ *
+ * @returns COM status code.
  */
 STDMETHODIMP MachineDebugger::DumpStats()
@@ -153 +153 @@
     if (pVM.isOk())
         STAMR3Dump(pVM, NULL);
+    return S_OK;
+}
+
+/**
+ * Get the VM statistics in an XML format.
+ *
+ * @returns COM status code.
+ * @param   aPattern            The selection pattern. A bit similar to filename globbing.
+ * @param   aWithDescriptions   Whether to include the descriptions.
+ * @param   aStats              The XML document containing the statistics.
+ */
+STDMETHODIMP MachineDebugger::GetStats(INPTR BSTR aPattern, BOOL aWithDescriptions, BSTR *aStats)
+{
+    Console::SafeVMPtrQuiet pVM (mParent);
+    if (!pVM.isOk())
+        return E_FAIL;
+
+    char *pszSnapshot;
+    int vrc = STAMR3Snapshot(pVM, Utf8Str(aPattern).raw(), &pszSnapshot, NULL, aWithDescriptions);
+    if (RT_FAILURE(vrc))
+        return vrc == VERR_NO_MEMORY ? E_OUTOFMEMORY : E_FAIL;
+
+    /** @todo this is horribly inefficient! And it's kinda difficult to tell whether it failed...
+     * Must use UTF-8 or ASCII here and completely avoid these two extra copy operations.
+     * Until that's done, this method is kind of useless for debugger statistics GUI because
+     * of the amount statistics in a debug build. */
+    Bstr(pszSnapshot).cloneTo(aStats);
+
     return S_OK;
 }
@@ -480 +508 @@
 /**
  * Returns the current virtual time rate.
- * 
+ *
  * @returns COM status code.
  * @param   pct     Where to store the rate.
@@ -502 +530 @@
 /**
  * Returns the current virtual time rate.
- * 
+ *
  * @returns COM status code.
  * @param   pct     Where to store the rate.

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -18 +18 @@
  *    out/<platform>/bin/sdk/idl/VirtualBox.idl
  *    (MS COM interface definition file for Main API)
- * 
+ *
  * 2. src/VBox/Main/idl/xpidl.xsl =>
  *    out/<platform>/bin/sdk/idl/VirtualBox_XPCOM.idl
@@ -42 +42 @@
  *
      Copyright (C) 2006-2007 innotek GmbH
-    
+
      This file is part of VirtualBox Open Source Edition (OSE), as
      available from http://www.virtualbox.org. This file is free software;
@@ -398 +398 @@
     <desc>
       Scope of the operation.
-      
+
       A generic enumeration used in various methods to define the action or
       argument scope.
@@ -498 +498 @@
     <const name="MaxVal"               value="17"/>
   </enum>
- 
+
   <!--
   // IVirtualBoxErrorInfo
@@ -1617 +1617 @@
         space of the session object. There can be only one direct
         session open at a time for every virtual machine.
-      
+
         Upon successful return, the session object can be used to
         get access to the machine and to the VM console.
@@ -1647 +1647 @@
         caller (using the IConsole interface); however, within the remote
         session context, not all VM settings are available for modification.
-        
+
         This operation can take some time, so the progress object
         is returned to let the caller be informed when the session is
@@ -5060 +5060 @@
         <li>
           <i>Custom HardDisk</i>, a disk accessed via a plugin which is loaded
-          when the disk is accessed (represented by the 
+          when the disk is accessed (represented by the
           <link to="ICustomHardDisk"/> interface).
         </li>
@@ -6623 +6623 @@
       to="IFramebuffer::requestResize()"/>.
 
-      See also www.fourcc.org for more informantion about FOURCC pixel formats. 
+      See also www.fourcc.org for more informantion about FOURCC pixel formats.
     </desc>
     <const name="PixelFormatOpaque"       value="0xFFFFFFFF">
@@ -6679 +6679 @@
           This attribute must never return <link
           to="PixelFormat::PixelFormatOpaque"/> -- the format of the buffer
-          <link to="#address"/> points to must be always known. 
+          <link to="#address"/> points to must be always known.
         </note>
       </desc>
@@ -6688 +6688 @@
         Defines whether this framebuffer uses the virtual video card's memory
         buffer (guest VRAM) directly or not. See <link
-        to="IFramebuffer::requestResize()"/> for more information. 
+        to="IFramebuffer::requestResize()"/> for more information.
       </desc>
     </attribute>
@@ -7098 +7098 @@
         should issue the request and wait for a resolution change and
         after a timeout retry.
-        
+
         Specifying <tt>0</tt> for either @a width, @a height or @a bitsPerPixel
         parameters means that the corresponding values should be taken from the
@@ -7446 +7446 @@
   <interface
      name="IMachineDebugger" extends="$unknown"
-     uuid="358b05cd-6d43-42b9-9c2b-75d466a58cfc"
+     uuid="aabb012b-36c7-4d31-89fd-313f7d056034"
      wsmap="suppress"
      >
@@ -7459 +7459 @@
         Dumps VM statistics.
       </desc>
+    </method>
+
+    <method name="getStats">
+      <desc>
+        Get the VM statistics in a XMLish format.
+      </desc>
+      <param name="pattern" type="wstring" dir="in">
+        <desc>The selection pattern. A bit similar to filename globbing.</desc>
+      </param>
+      <param name="withDescriptions" type="boolean" dir="in">
+        <desc>Whether to include the descriptions.</desc>
+      </param>
+      <param name="stats" type="wstring" dir="out">
+        <desc>The XML document containing the statistics.</desc>
+      </param>
     </method>
 
@@ -8314 +8329 @@
         <li>Global definitions</li>
       </ol>
-      
+
       For example, if MyMachine has a shared folder named
       <tt>C_DRIVE</tt> (that points to <tt>C:\\</tt>), then cretaing a
@@ -8325 +8340 @@
       the prevoious (permanent) definition of <tt>C_DRIVE</tt> that points
       to <tt>C:\\</tt> if it still exists.
-      
+
       Note that permanent and transient shared folders of different machines
       are in different name spaces, so they don't overlap and don't need to

trunk/src/VBox/Main/include/MachineDebuggerImpl.h

@@ -70 +70 @@
     STDMETHOD(ResetStats());
     STDMETHOD(DumpStats());
+    STDMETHOD(GetStats(INPTR BSTR aPattern, BOOL aWithDescriptions, BSTR *aStats));
+
 
     // "public-private methods"