Changeset 51908 in vbox for trunk/src/VBox/HostDrivers/VBoxNetFlt/win/cfg

Timestamp:

Jul 7, 2014 5:44:56 PM (10 years ago)

Author:

vboxsync

Message:

VBoxNetFlt/win: Unbreak VBoxNetFltUninstall - apparently the previous changes made VBoxNetCfgWinNetFltUninstall return S_FALSE when we're not installed. Dunno if it can return this in other cases. Undid some of the Id vs ID inconsistencies introduced by that same changeset - Id was used before and that's the preferred way of doing it.

File:

• trunk/src/VBox/HostDrivers/VBoxNetFlt/win/cfg/VBoxNetCfg.cpp (modified) (7 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/win/cfg/VBoxNetCfg.cpp

@@ -593 +593 @@
 
 typedef BOOL (*VBOXNETCFGWIN_NETENUM_CALLBACK) (HDEVINFO hDevInfo, PSP_DEVINFO_DATA pDev, PVOID pContext);
-VBOXNETCFGWIN_DECL(HRESULT) VBoxNetCfgWinEnumNetDevices(LPCWSTR pwszPnPID,
+VBOXNETCFGWIN_DECL(HRESULT) VBoxNetCfgWinEnumNetDevices(LPCWSTR pwszPnPId,
                                                         VBOXNETCFGWIN_NETENUM_CALLBACK callback, PVOID pContext)
 {
-    NonStandardLogFlow(("VBoxNetCfgWinEnumNetDevices: Searching for: %S\n", pwszPnPID));
+    NonStandardLogFlow(("VBoxNetCfgWinEnumNetDevices: Searching for: %S\n", pwszPnPId));
 
     HRESULT hr;
@@ -610 +610 @@
         DWORD winEr;
 
-        DWORD dwDevID = 0;
-        size_t cPnPId = wcslen(pwszPnPID);
+        DWORD dwDevId = 0;
+        size_t cPnPId = wcslen(pwszPnPId);
 
         PBYTE pBuffer = NULL;
@@ -621 +621 @@
             Dev.cbSize = sizeof(SP_DEVINFO_DATA);
 
-            if (!SetupDiEnumDeviceInfo(hDevInfo, dwDevID, &Dev))
+            if (!SetupDiEnumDeviceInfo(hDevInfo, dwDevId, &Dev))
             {
                 winEr = GetLastError();
@@ -629 +629 @@
             }
 
-            NonStandardLogFlow(("VBoxNetCfgWinEnumNetDevices: Enumerating device %ld ... \n", dwDevID));
-            dwDevID++;
+            NonStandardLogFlow(("VBoxNetCfgWinEnumNetDevices: Enumerating device %ld ... \n", dwDevId));
+            dwDevId++;
 
             if (pBuffer)
@@ -677 +677 @@
             }
 
-            PWSTR pCurID = (PWSTR)pBuffer;
-            size_t cCurId = wcslen(pCurID);
-
-            NonStandardLogFlow(("VBoxNetCfgWinEnumNetDevices: Device %ld: %S\n", dwDevID, pCurID));
+            PWSTR pCurId = (PWSTR)pBuffer;
+            size_t cCurId = wcslen(pCurId);
+
+            NonStandardLogFlow(("VBoxNetCfgWinEnumNetDevices: Device %ld: %S\n", dwDevId, pCurId));
 
             if (cCurId >= cPnPId)
             {
-                pCurID += cCurId - cPnPId;
-                if (!wcsnicmp(pCurID, pwszPnPID, cPnPId))
+                pCurId += cCurId - cPnPId;
+                if (!wcsnicmp(pCurId, pwszPnPId, cPnPId))
                 {
                     if (!callback(hDevInfo, &Dev, pContext))
@@ -693 +693 @@
         }
 
-        NonStandardLogFlow(("VBoxNetCfgWinEnumNetDevices: Found %ld devices total\n", dwDevID));
+        NonStandardLogFlow(("VBoxNetCfgWinEnumNetDevices: Found %ld devices total\n", dwDevId));
 
         if (pBuffer)
@@ -2549 +2549 @@
                     {
                           /* get the device instance ID */
-                          TCHAR devID [MAX_DEVICE_ID_LEN];
+                          TCHAR devId[MAX_DEVICE_ID_LEN];
                           if (CM_Get_Device_ID(DeviceInfoData.DevInst,
-                                               devID, MAX_DEVICE_ID_LEN, 0) == CR_SUCCESS)
+                                               devId, MAX_DEVICE_ID_LEN, 0) == CR_SUCCESS)
                           {
                               /* compare to what we determined before */
-                              if (wcscmp(devID, lszPnPInstanceId) == 0)
+                              if (wcscmp(devId, lszPnPInstanceId) == 0)
                               {
                                   found = TRUE;