Changeset 51945 in vbox for trunk

Timestamp:

Jul 9, 2014 12:59:53 AM (10 years ago)

Author:

vboxsync

Message:

Try again for up to 5 seconds when we see STATUS_NO_SUCH_DEVICE and the driver is initializing.

Location:

trunk

Files:

• include/iprt/nt/nt.h (modified) (1 diff)
• src/VBox/HostDrivers/Support/win/SUPR3HardenedMain-win.cpp (modified) (3 diffs)

trunk/include/iprt/nt/nt.h

@@ -298 +298 @@
 #ifndef ZwCurrentThread
 # define ZwCurrentThread()                  NtCurrentThread()
+#endif
+/** @} */
+
+
+/** @name Directory object access rights.
+ * @{ */
+#ifndef DIRECTORY_QUERY
+# define DIRECTORY_QUERY                    UINT32_C(0x00000001)
+#endif
+#ifndef DIRECTORY_TRAVERSE
+# define DIRECTORY_TRAVERSE                 UINT32_C(0x00000002)
+#endif
+#ifndef DIRECTORY_CREATE_OBJECT
+# define DIRECTORY_CREATE_OBJECT            UINT32_C(0x00000004)
+#endif
+#ifndef DIRECTORY_CREATE_SUBDIRECTORY
+# define DIRECTORY_CREATE_SUBDIRECTORY      UINT32_C(0x00000008)
+#endif
+#ifndef DIRECTORY_ALL_ACCESS
+# define DIRECTORY_ALL_ACCESS               ( STANDARD_RIGHTS_REQUIRED | UINT32_C(0x0000000f) )
 #endif
 /** @} */

trunk/src/VBox/HostDrivers/Support/win/SUPR3HardenedMain-win.cpp

@@ -1386 +1386 @@
 
 
+static bool supR3HardenedWinDriverExists(const char *pszDriver)
+{
+    /*
+     * Open the driver object directory.
+     */
+    UNICODE_STRING NtDirName;
+    NtDirName.Buffer = L"\\Driver";
+    NtDirName.MaximumLength = sizeof(L"\\Driver");
+    NtDirName.Length = NtDirName.MaximumLength - sizeof(WCHAR);
+
+    OBJECT_ATTRIBUTES ObjAttr;
+    InitializeObjectAttributes(&ObjAttr, &NtDirName, OBJ_CASE_INSENSITIVE, NULL /*hRootDir*/, NULL /*pSecDesc*/);
+
+    HANDLE hDir;
+    NTSTATUS rcNt = NtOpenDirectoryObject(&hDir, DIRECTORY_QUERY | FILE_LIST_DIRECTORY, &ObjAttr);
+#ifdef VBOX_STRICT
+    SUPR3HARDENED_ASSERT_NT_SUCCESS(rcNt);
+#endif
+    if (!NT_SUCCESS(rcNt))
+        return true;
+
+    /*
+     * Enumerate it, looking for the driver.
+     */
+    bool  fFound = true;
+    ULONG uObjDirCtx = 0;
+    do
+    {
+        uint32_t    abBuffer[_64K + _1K];
+        ULONG       cbActual;
+        rcNt = NtQueryDirectoryObject(hDir,
+                                      abBuffer,
+                                      sizeof(abBuffer) - 4, /* minus four for string terminator space. */
+                                      FALSE /*ReturnSingleEntry */,
+                                      FALSE /*RestartScan*/,
+                                      &uObjDirCtx,
+                                      &cbActual);
+        if (!NT_SUCCESS(rcNt) || cbActual < sizeof(OBJECT_DIRECTORY_INFORMATION))
+            break;
+
+        POBJECT_DIRECTORY_INFORMATION pObjDir = (POBJECT_DIRECTORY_INFORMATION)abBuffer;
+        while (pObjDir->Name.Length != 0)
+        {
+            WCHAR wcSaved = pObjDir->Name.Buffer[pObjDir->Name.Length / sizeof(WCHAR)];
+            pObjDir->Name.Buffer[pObjDir->Name.Length / sizeof(WCHAR)] = '\0';
+            if (   pObjDir->Name.Length > 1
+                && RTUtf16ICmpAscii(pObjDir->Name.Buffer, pszDriver) == 0)
+            {
+                fFound = true;
+                break;
+            }
+            pObjDir->Name.Buffer[pObjDir->Name.Length / sizeof(WCHAR)] = wcSaved;
+
+            /* Next directory entry. */
+            pObjDir++;
+        }
+    } while (!fFound);
+
+    /*
+     * Clean up and return.
+     */
+    NtClose(hDir);
+
+    return fFound;
+}
+
+
 /**
  * Called by the main code if supR3HardenedWinIsReSpawnNeeded returns @c true.
@@ -1394 +1461 @@
 {
     /*
-     * Open the stub device.
-     */
-    HANDLE              hFile = RTNT_INVALID_HANDLE_VALUE;
-    IO_STATUS_BLOCK     Ios   = RTNT_IO_STATUS_BLOCK_INITIALIZER;
-
+     * Open the stub device.  Retry if we think driver might still be
+     * initializing (STATUS_NO_SUCH_DEVICE + \Drivers\VBoxDrv).
+     */
     static const WCHAR  s_wszName[] = L"\\Device\\VBoxDrvStub";
-    UNICODE_STRING      NtName;
-    NtName.Buffer        = (PWSTR)s_wszName;
-    NtName.Length        = sizeof(s_wszName) - sizeof(WCHAR);
-    NtName.MaximumLength = sizeof(s_wszName);
-
-    OBJECT_ATTRIBUTES   ObjAttr;
-    InitializeObjectAttributes(&ObjAttr, &NtName, OBJ_CASE_INSENSITIVE, NULL /*hRootDir*/, NULL /*pSecDesc*/);
-
-    NTSTATUS rcNt = NtCreateFile(&hFile,
-                                 GENERIC_READ | GENERIC_WRITE,
-                                 &ObjAttr,
-                                 &Ios,
-                                 NULL /* Allocation Size*/,
-                                 FILE_ATTRIBUTE_NORMAL,
-                                 FILE_SHARE_READ | FILE_SHARE_WRITE,
-                                 FILE_OPEN,
-                                 FILE_NON_DIRECTORY_FILE,
-                                 NULL /*EaBuffer*/,
-                                 0 /*EaLength*/);
-    if (NT_SUCCESS(rcNt))
-        rcNt = Ios.Status;
+    DWORD const         uStartTick = GetTickCount();
+    NTSTATUS            rcNt;
+    uint32_t            iTry;
+
+    for (iTry = 0;; iTry++)
+    {
+        HANDLE              hFile = RTNT_INVALID_HANDLE_VALUE;
+        IO_STATUS_BLOCK     Ios   = RTNT_IO_STATUS_BLOCK_INITIALIZER;
+
+        UNICODE_STRING      NtName;
+        NtName.Buffer        = (PWSTR)s_wszName;
+        NtName.Length        = sizeof(s_wszName) - sizeof(WCHAR);
+        NtName.MaximumLength = sizeof(s_wszName);
+
+        OBJECT_ATTRIBUTES   ObjAttr;
+        InitializeObjectAttributes(&ObjAttr, &NtName, OBJ_CASE_INSENSITIVE, NULL /*hRootDir*/, NULL /*pSecDesc*/);
+
+        rcNt = NtCreateFile(&hFile,
+                            GENERIC_READ | GENERIC_WRITE,
+                            &ObjAttr,
+                            &Ios,
+                            NULL /* Allocation Size*/,
+                            FILE_ATTRIBUTE_NORMAL,
+                            FILE_SHARE_READ | FILE_SHARE_WRITE,
+                            FILE_OPEN,
+                            FILE_NON_DIRECTORY_FILE,
+                            NULL /*EaBuffer*/,
+                            0 /*EaLength*/);
+        if (NT_SUCCESS(rcNt))
+            rcNt = Ios.Status;
+
+        /* The STATUS_NO_SUCH_DEVICE might be returned if the device is not
+           completely initialized.  Delay a little bit and try again. */
+        if (rcNt != STATUS_NO_SUCH_DEVICE)
+            break;
+        if (iTry > 0 && GetTickCount() - uStartTick > 5000)  /* 5 sec, at least two tries */
+            break;
+        if (!supR3HardenedWinDriverExists("VBoxDrv"))
+        {
+            /** @todo Consider starting the VBoxdrv.sys service. Requires 2nd process
+             *        though, rather complicated actually as CreateProcess causes all
+             *        kind of things to happen to this process which would make it hard to
+             *        pass the process verification tests... :-/ */
+            break;
+        }
+
+        LARGE_INTEGER Time;
+        if (iTry < 8)
+            Time.QuadPart = -1000000 / 100; /* 1ms in 100ns units, relative time. */
+        else
+            Time.QuadPart = -32000000 / 100; /* 32ms in 100ns units, relative time. */
+        NtDelayExecution(TRUE, &Time);
+    }
+
     if (!NT_SUCCESS(rcNt))
     {
@@ -1438 +1536 @@
             }
             supR3HardenedFatalMsg("supR3HardenedWinReSpawn", kSupInitOp_Driver, VERR_OPEN_FAILED,
-                                  "NtCreateFile(%ls) failed: %#x%s\n", s_wszName, rcNt, pszDefine);
+                                  "NtCreateFile(%ls) failed: %#x%s (%u retries)\n", s_wszName, rcNt, pszDefine, iTry);
         }
         supR3HardenedFatalMsg("supR3HardenedWinReSpawn", kSupInitOp_Driver, rc,